From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B38E1C433DB for ; Tue, 29 Dec 2020 19:00:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 61D5F2074B for ; Tue, 29 Dec 2020 19:00:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726144AbgL2TAZ (ORCPT ); Tue, 29 Dec 2020 14:00:25 -0500 Received: from mail-40134.protonmail.ch ([185.70.40.134]:46318 "EHLO mail-40134.protonmail.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726126AbgL2TAZ (ORCPT ); Tue, 29 Dec 2020 14:00:25 -0500 Date: Tue, 29 Dec 2020 18:59:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1609268382; bh=vPJn7J1kEKFxBnc6s4Rz+y18HTaQaBq0rrKnBd4xxSk=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=Mi9iFECVbTn2wsMXoe3QELmy1q1zYRK3903q55Xm6DXbAmrwx9o2TJMzGhPPafz6D FeBrRA//Db9jchacl3Vk+PuEj/JYAwBe1Axa5aTeQeYuywbabHy7jzIhwFIYlkHDTy mLTSyyQgreqERCBQylnRf61UFsuqd5xN8YdTOdcs= To: Roderick Colenbrander From: =?utf-8?Q?Barnab=C3=A1s_P=C5=91cze?= Cc: Jiri Kosina , Benjamin Tissoires , "linux-input@vger.kernel.org" , Chris Ye , Roderick Colenbrander Reply-To: =?utf-8?Q?Barnab=C3=A1s_P=C5=91cze?= Subject: Re: [PATCH 09/13] HID: playstation: add DualSense lightbar support Message-ID: In-Reply-To: References: <20201219062336.72568-1-roderick@gaikai.com> <20201219062336.72568-10-roderick@gaikai.com> <_n_Seien29lcWzPT6LHN7MEtqlVZpJOBRKw-qe01hEhSGbKKL7cffbmSGPjZZIN8Q4B8fInhwChsV0JB70F-wqj44ZQILevS6y3FXYaDtw8=@protonmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org 2020. december 28., h=C3=A9tf=C5=91 22:26 keltez=C3=A9ssel, Roderick Colenb= rander =C3=ADrta: > [...] > > > +/* Create a DualSense/DualShock4 RGB lightbar represented by a multi= color LED. */ > > > +static struct led_classdev_mc *ps_lightbar_create(struct ps_device *= ps_dev, > > > + int (*brightness_set)(struct led_classdev *, enum led_brightnes= s)) > > > +{ > > > + struct hid_device *hdev =3D ps_dev->hdev; > > > + struct led_classdev_mc *lightbar_mc_dev; > > > + struct mc_subled *mc_led_info; > > > + struct led_classdev *led_cdev; > > > + int ret; > > > + > > > + lightbar_mc_dev =3D devm_kzalloc(&hdev->dev, sizeof(*lightbar_m= c_dev), GFP_KERNEL); > > > + if (!lightbar_mc_dev) > > > + return ERR_PTR(-ENOMEM); > > > + > > > + mc_led_info =3D devm_kzalloc(&hdev->dev, 3*sizeof(*mc_led_info)= , GFP_KERNEL); > > > + if (!mc_led_info) > > > + return ERR_PTR(-ENOMEM); > > > + > > > > Is there any reason why these are dynamically allocated? > > No particular reason. I should probably at least not dynamically > allocate 'mc_dev' and pass it in similar to regular LED registration > (previously I had my regular LEDs dynamically allocated). The > mc_led_info I will probably keep dynamic. It feels a bit nasty to have > the caller be aware of these internal details. > [...] Could you please elaborate what you mean by "It feels a bit nasty to have the caller be aware of these internal details."? I don't think I fully unde= rstand what you're referring to.