From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S968232AbdEWWIA (ORCPT ); Tue, 23 May 2017 18:08:00 -0400 Received: from mail-pf0-f178.google.com ([209.85.192.178]:34941 "EHLO mail-pf0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966071AbdEWWH4 (ORCPT ); Tue, 23 May 2017 18:07:56 -0400 Date: Tue, 23 May 2017 15:07:55 -0700 (PDT) X-Google-Original-Date: Tue, 23 May 2017 15:07:29 PDT (-0700) From: Palmer Dabbelt To: geert@linux-m68k.org CC: linux-kernel@vger.kernel.org CC: Arnd Bergmann CC: olof@lixom.net CC: albert@sifive.com Subject: Re: [PATCH 5/7] RISC-V: arch/riscv/lib In-Reply-To: Message-ID: Mime-Version: 1.0 (MHng) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 23 May 2017 03:47:34 PDT (-0700), geert@linux-m68k.org wrote: > Hi Palmer, > > On Tue, May 23, 2017 at 2:41 AM, Palmer Dabbelt wrote: >> arch/riscv/lib/Makefile | 5 ++ >> arch/riscv/lib/ashldi3.c | 42 ++++++++++++++++ > > At least this one has already two identical copies in arch/score/lib/ashldi3.c > and arch/sh/lib/ashldi3.c. Probably these should be moved to lib/, and built > depending on a new config symbol that is selected on score, sh, and riscv. > > Didn't check the others. Thanks. It looks like there's actually a lot of these on many architectures. I have another patch set to correct all of these that you're To'd on, I'll just pick up the first patch in the set for v2 https://lkml.org/lkml/2017/5/23/1280