From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E729EC4708F for ; Sat, 29 May 2021 20:38:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BDBBD60E09 for ; Sat, 29 May 2021 20:38:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229842AbhE2Ujs (ORCPT ); Sat, 29 May 2021 16:39:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59762 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229718AbhE2Ujr (ORCPT ); Sat, 29 May 2021 16:39:47 -0400 Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com [IPv6:2607:f8b0:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68324C061574 for ; Sat, 29 May 2021 13:38:10 -0700 (PDT) Received: by mail-pg1-x52a.google.com with SMTP id f22so5243538pgb.9 for ; Sat, 29 May 2021 13:38:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dabbelt-com.20150623.gappssmtp.com; s=20150623; h=date:subject:in-reply-to:cc:from:to:message-id:mime-version :content-transfer-encoding; bh=FaKAKWgTGAF75nlDcT+nxeoW3pPMI6Wa1hWEXx7JRJ8=; b=KXbwErhInDJmgxHoBTPjt5gjPSnwxW/kBZkRBej1XQMnaCtmbDhJRo0arQU5oisUhn i1n/WsF3V61hp2fEjB3OJ3BRYReI2yeacvqwhLBZ1bRIKrwopmtLE5Ip8WsBqDAkfDM0 FyII2aoYRtjhlHrjnRdJBqQqo+eDwQr5qmxYJNp3hAnILtTCkcjG60J3zj6+X1fwssyJ XWnVQUozzo5fI+NuJgx68Z9czl+MxxgNzEe1MjgwOwABntF2M6FWx+mmyqLxbl7tteCp CkfvA7tERJveQgFXUk6lWnxTKdkCC1wIJT8I0zy9vX7SW42NftuG2hJZp8rdjeX54T95 zv3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:subject:in-reply-to:cc:from:to:message-id :mime-version:content-transfer-encoding; bh=FaKAKWgTGAF75nlDcT+nxeoW3pPMI6Wa1hWEXx7JRJ8=; b=SWCJU0RPR+kKKYGXR/v8Srq6+5rbh6dNrrkblYYLLjxSP3wgxfKD/RW6gdWAMCG0mO Mlc8tVwjch3tI/eb5jPEWlwaWv1e371JTBBXKTKhGM5RT5sJu0nXRIpW+SemWLPxYic9 G/wc4GP+QM1wXa+2t0oDywqvSPCdMLnRDcenh1CsU+bZ5hpZMYZ7VBqmAqmBquWJ7y5V LON19zhTDwDIgxoiW1PLQx+NQ/jPtDZWh2rAPObIUV0CVOhuCiFFMcB2MUdQQYQT9obb pF4UMJrmeJsnOlRL/X4tSBAMKAxY98KU+732zvrGsGhrCjfR06pTcDX3Q+5IexY66fAZ wx5Q== X-Gm-Message-State: AOAM533KuB3T+au69f3pj3PiUn5KeLD8q3FGe4ssVjGt6V2JlIIz9MKx qu494NQ7kLDsSA8YO/8LY7Tsdw== X-Google-Smtp-Source: ABdhPJxYikI3/E8XUsCFa1Je+83ieoXbfxo1EPLo2zpTY2HKbPRWYOimxaJlg0ZHL3KOfFy1R8OTAg== X-Received: by 2002:a63:d30e:: with SMTP id b14mr15331161pgg.237.1622320689748; Sat, 29 May 2021 13:38:09 -0700 (PDT) Received: from localhost (76-210-143-223.lightspeed.sntcca.sbcglobal.net. [76.210.143.223]) by smtp.gmail.com with ESMTPSA id o7sm7740814pgs.45.2021.05.29.13.38.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 May 2021 13:38:09 -0700 (PDT) Date: Sat, 29 May 2021 13:38:09 -0700 (PDT) X-Google-Original-Date: Sat, 29 May 2021 13:37:27 PDT (-0700) Subject: Re: [PATCH v2] riscv: Map the kernel with correct permissions the first time In-Reply-To: CC: Christoph Hellwig , Paul Walmsley , aou@eecs.berkeley.edu, jszhang@kernel.org, zong.li@sifive.com, anup@brainfault.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org From: Palmer Dabbelt To: alex@ghiti.fr Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 28 May 2021 01:24:43 PDT (-0700), alex@ghiti.fr wrote: > Hi Christoph, > > Le 27/05/2021 à 08:35, Christoph Hellwig a écrit : >> On Wed, May 26, 2021 at 03:41:10PM +0200, Alexandre Ghiti wrote: >>> #ifdef CONFIG_64BIT >>> +#define is_kernel_mapping(x) ((x) >= kernel_virt_addr && (x) < (kernel_virt_addr + load_sz)) >>> +#define is_linear_mapping(x) ((x) >= PAGE_OFFSET && (x) < kernel_virt_addr) >>> + >> >> Overly long lines. Independ of that complex macros are generally much >> more readable if they are written more function-like, that is the name >> and paramtes are kept on a line of their own: >> >> #define is_kernel_mapping(x) \ >> ((x) >= kernel_virt_addr && (x) < (kernel_virt_addr + load_sz)) >> >> But what is the reason to not make them type-safe inline functions >> anyway? > > No reason. I will then make those macros inline functions and send > another patchset to make the below macro an inline function too. > >> >>> #define __va_to_pa_nodebug(x) ({ \ >>> unsigned long _x = x; \ >>> - (_x < kernel_virt_addr) ? \ >>> + is_linear_mapping(_x) ? \ >>> linear_mapping_va_to_pa(_x) : kernel_mapping_va_to_pa(_x); \ >>> }) >> >> ... especially for something complex like this. >> >>> +static inline bool is_va_kernel_lm_alias_text(uintptr_t va) >>> +{ >>> + return (va >= (uintptr_t)lm_alias(_start) && va < (uintptr_t)lm_alias(__init_text_begin)); >> >> Overly long line as well. And useless braces. > > Ok. > >> >>> +static inline bool is_va_kernel_init_text(uintptr_t va) >>> +{ >>> + return (va >= (uintptr_t)__init_text_begin && va < (uintptr_t)__init_data_begin); >>> +} >> >> Same here. > > checkpatch does not complain about those lines which are under 100 > characters, what's the point in breaking them on multiple lines? > >> >>> +#ifdef CONFIG_STRICT_KERNEL_RWX >>> +static __init pgprot_t pgprot_from_va(uintptr_t va) >>> +{ >>> +#ifdef CONFIG_64BIT >>> + if (is_va_kernel_text(va) || is_va_kernel_init_text(va)) >>> + return PAGE_KERNEL_READ_EXEC; >>> + >>> + /* >>> + * We must mark only text as read-only as init text will get freed later >>> + * and rodata section is marked readonly in mark_rodata_ro. >>> + */ >>> + if (is_va_kernel_lm_alias_text(va)) >>> + return PAGE_KERNEL_READ; >>> + >>> + return PAGE_KERNEL; >>> +#else >>> + if (is_va_kernel_text(va)) >>> + return PAGE_KERNEL_READ_EXEC; >>> + >>> + if (is_va_kernel_init_text(va)) >>> + return PAGE_KERNEL_EXEC; >>> + >>> + return PAGE_KERNEL; >>> +#endif /* CONFIG_64BIT */ >>> +} >> >> If the entire function is different for config symbols please just >> split it into two separate functions. But to make the difference more >> clear IS_ENABLED might fit better here: >> >> static __init pgprot_t pgprot_from_va(uintptr_t va) >> { >> if (is_va_kernel_text(va)) >> return PAGE_KERNEL_READ_EXEC; >> if (is_va_kernel_init_text(va)) >> return IS_ENABLED(CONFIG_64BIT) ? >> PAGE_KERNEL_READ_EXEC : PAGE_KERNEL_EXEC; >> if (IS_ENABLED(CONFIG_64BIT) && is_va_kernel_lm_alias_text(va)) >> return PAGE_KERNEL_READ; >> return PAGE_KERNEL; >> } >> >> Preferable with comments explaining the 32-bit vs 64-bit difference. > > Ok this is more compact, I'll do that with the comment. > >> >>> +void mark_rodata_ro(void) >>> +{ >>> + unsigned long rodata_start = (unsigned long)__start_rodata; >>> + unsigned long data_start = (unsigned long)_data; >>> + unsigned long __maybe_unused lm_rodata_start = (unsigned long)lm_alias(__start_rodata); >>> + unsigned long __maybe_unused lm_data_start = (unsigned long)lm_alias(_data); >>> + >>> + set_memory_ro(rodata_start, (data_start - rodata_start) >> PAGE_SHIFT); >>> +#ifdef CONFIG_64BIT >>> + set_memory_ro(lm_rodata_start, (lm_data_start - lm_rodata_start) >> PAGE_SHIFT); >>> +#endif >> >> Lots of unreadable overly lone lines. Why not add a helper and do >> something like: >> >> static void set_kernel_memory_ro(char *startp, char *endp) >> { >> unsigned long start = (unsigned long)startp; >> unsigned long end = (unsigned long)endp; >> >> set_memory_ro(start, (start - end) >> PAGE_SHIFT); >> } >> >> set_kernel_memory_ro(_start_rodata, _data); >> if (IS_ENABLED(CONFIG_64BIT)) >> set_kernel_memory_ro(lm_alias(__start_rodata), lm_alias(_data)); >> >> > > Ok, that's better indeed. I will do something like that instead, to > avoid multiple versions of this helper: > > int set_kernel_memory(char *startp, char *endp, > > int (*set_memory)(unsigned long start, int > num_pages)) > >>> +static __init pgprot_t pgprot_from_va(uintptr_t va) >>> +{ >>> +#ifdef CONFIG_64BIT >>> + if (is_kernel_mapping(va)) >>> + return PAGE_KERNEL_EXEC; >>> + >>> + if (is_linear_mapping(va)) >>> + return PAGE_KERNEL; >>> + >>> + return PAGE_KERNEL; >>> +#else >>> + return PAGE_KERNEL_EXEC; >>> +#endif /* CONFIG_64BIT */ >>> +} >>> +#endif /* CONFIG_STRICT_KERNEL_RWX */ >>> + >> >> Same comment as for the other version. This could become: >> >> static __init pgprot_t pgprot_from_va(uintptr_t va) >> { >> if (IS_ENABLED(CONFIG_64BIT) && !is_kernel_mapping(va)) >> return PAGE_KERNEL; >> return PAGE_KERNEL_EXEC; >> } > > Ok I'll do that. > >> >>> -static void __init create_kernel_page_table(pgd_t *pgdir, uintptr_t map_size) >>> +static void __init create_kernel_page_table(pgd_t *pgdir, uintptr_t map_size, bool early) >> >> Overly long line. >> >>> for (va = kernel_virt_addr; va < end_va; va += map_size) >>> create_pgd_mapping(pgdir, va, >>> load_pa + (va - kernel_virt_addr), >>> - map_size, PAGE_KERNEL_EXEC); >>> + map_size, early ? PAGE_KERNEL_EXEC : pgprot_from_va(va)); >> >> Same here. But why not pass in a "pgprot_t ram_pgprot" instead of the >> bool, which would be self-documenting. > > This function is used to map the kernel mapping, the pgprot_t is then > different in create_kernel_page_table depending on the virtual address > so I can't pass a single pgprot_t for that or I would need a dummy > pgprot_t to test anyway. Thanks. I've got a riscv-wx-mappings branch with the fix on it, I'll take this on there when we have something ready to go and then merge both into for-next so we can avoid merge conflicts. > > Thank you for your review, > > Alex > >> >> _______________________________________________ >> linux-riscv mailing list >> linux-riscv@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-riscv >> From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0963C4708F for ; Sat, 29 May 2021 20:38:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 95DA561107 for ; Sat, 29 May 2021 20:38:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 95DA561107 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=dabbelt.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Mime-Version:Message-ID:To:From:CC:In-Reply-To: Subject:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References:List-Owner; bh=pDdL2SyymBwgDsxjSM/p/r894nJYpwdikK6HRv5Q9JQ=; b=N4Vnf8nud2AO2DtsOwEfikZfDM Q7/521aTPQWYZ50wbz7f91Qt7dyP9SWFa7aNR5EZ/aaZkAoMwxknm/e4gdxlmGyiTvEUwQXHA0Cko hglzQUiEgO3UNkw1Ur1wRE5nO6JFpaag+qEpuOaZ7E14Jk2zU7Zn+9YxeTiO8XgPO9tPmZtLXynF3 PN/t9vkIxjKjSPN5EB2sJ1AVNl8x6pvrvfIy5TtMMLyMu1UI3OkbRORtfBCqdn+C0W3cWVnTu3CWX u9niWmEM6ET1roVcZhpbpo5zk/JPmBHpYoEVAWpfqXh8NGHAH2RwT0ViVultzMSkzp/peaGqYbwfh fjJmk/hg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ln5in-008JxU-IH; Sat, 29 May 2021 20:38:13 +0000 Received: from mail-pg1-x533.google.com ([2607:f8b0:4864:20::533]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ln5ik-008Jwu-QO for linux-riscv@lists.infradead.org; Sat, 29 May 2021 20:38:12 +0000 Received: by mail-pg1-x533.google.com with SMTP id 27so5262369pgy.3 for ; Sat, 29 May 2021 13:38:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dabbelt-com.20150623.gappssmtp.com; s=20150623; h=date:subject:in-reply-to:cc:from:to:message-id:mime-version :content-transfer-encoding; bh=FaKAKWgTGAF75nlDcT+nxeoW3pPMI6Wa1hWEXx7JRJ8=; b=KXbwErhInDJmgxHoBTPjt5gjPSnwxW/kBZkRBej1XQMnaCtmbDhJRo0arQU5oisUhn i1n/WsF3V61hp2fEjB3OJ3BRYReI2yeacvqwhLBZ1bRIKrwopmtLE5Ip8WsBqDAkfDM0 FyII2aoYRtjhlHrjnRdJBqQqo+eDwQr5qmxYJNp3hAnILtTCkcjG60J3zj6+X1fwssyJ XWnVQUozzo5fI+NuJgx68Z9czl+MxxgNzEe1MjgwOwABntF2M6FWx+mmyqLxbl7tteCp CkfvA7tERJveQgFXUk6lWnxTKdkCC1wIJT8I0zy9vX7SW42NftuG2hJZp8rdjeX54T95 zv3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:subject:in-reply-to:cc:from:to:message-id :mime-version:content-transfer-encoding; bh=FaKAKWgTGAF75nlDcT+nxeoW3pPMI6Wa1hWEXx7JRJ8=; b=DacuXqfdSo4Id9k3ev/97Uwnjee+p6iVfLYMj5HoHhE5W/Jf69R023mXwiu+FRsBsm U5xAbQ3oQNItL48FQp4OEYmBl0LhrYUtXF9r67SbITwxu0fkjEg3ndo4CpZq9/xd8Car LxaD90s+vHimtfNvmVdmz8+bcNiAJ37b96UwOGrpnTL/h8Z/3OUDK3HwsFmDd5JzauIM GJLqMQJV0WxKanztA30Ph1RkGaESK9EuR/zYc+7XoaVA78rgEYRZY/5A0q8/E2C0HYSY Shx+b45VVSCbBzaRIQ1RFg166b5vzQ+Z2eDlPDHQlFBzw3gSwbpQg4Tfs37t5V+IGOn/ peJA== X-Gm-Message-State: AOAM531tIoPD1b5VLNLUfkvOmWjZsDE+UyO1wokr0tmYju5R88Ci1XGb A2IXfYrZ9GQk73CQe8YpAkjYqw== X-Google-Smtp-Source: ABdhPJxYikI3/E8XUsCFa1Je+83ieoXbfxo1EPLo2zpTY2HKbPRWYOimxaJlg0ZHL3KOfFy1R8OTAg== X-Received: by 2002:a63:d30e:: with SMTP id b14mr15331161pgg.237.1622320689748; Sat, 29 May 2021 13:38:09 -0700 (PDT) Received: from localhost (76-210-143-223.lightspeed.sntcca.sbcglobal.net. [76.210.143.223]) by smtp.gmail.com with ESMTPSA id o7sm7740814pgs.45.2021.05.29.13.38.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 May 2021 13:38:09 -0700 (PDT) Date: Sat, 29 May 2021 13:38:09 -0700 (PDT) X-Google-Original-Date: Sat, 29 May 2021 13:37:27 PDT (-0700) Subject: Re: [PATCH v2] riscv: Map the kernel with correct permissions the first time In-Reply-To: CC: Christoph Hellwig , Paul Walmsley , aou@eecs.berkeley.edu, jszhang@kernel.org, zong.li@sifive.com, anup@brainfault.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org From: Palmer Dabbelt To: alex@ghiti.fr Message-ID: Mime-Version: 1.0 (MHng) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210529_133810_958435_5BBA5A97 X-CRM114-Status: GOOD ( 35.11 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gRnJpLCAyOCBNYXkgMjAyMSAwMToyNDo0MyBQRFQgKC0wNzAwKSwgYWxleEBnaGl0aS5mciB3 cm90ZToKPiBIaSBDaHJpc3RvcGgsCj4KPiBMZSAyNy8wNS8yMDIxIMOgIDA4OjM1LCBDaHJpc3Rv cGggSGVsbHdpZyBhIMOpY3JpdMKgOgo+PiBPbiBXZWQsIE1heSAyNiwgMjAyMSBhdCAwMzo0MTox MFBNICswMjAwLCBBbGV4YW5kcmUgR2hpdGkgd3JvdGU6Cj4+PiAgICNpZmRlZiBDT05GSUdfNjRC SVQKPj4+ICsjZGVmaW5lIGlzX2tlcm5lbF9tYXBwaW5nKHgpCSgoeCkgPj0ga2VybmVsX3ZpcnRf YWRkciAmJiAoeCkgPCAoa2VybmVsX3ZpcnRfYWRkciArIGxvYWRfc3opKQo+Pj4gKyNkZWZpbmUg aXNfbGluZWFyX21hcHBpbmcoeCkJKCh4KSA+PSBQQUdFX09GRlNFVCAmJiAoeCkgPCBrZXJuZWxf dmlydF9hZGRyKQo+Pj4gKwo+Pgo+PiBPdmVybHkgbG9uZyBsaW5lcy4gIEluZGVwZW5kIG9mIHRo YXQgY29tcGxleCBtYWNyb3MgYXJlIGdlbmVyYWxseSBtdWNoCj4+IG1vcmUgcmVhZGFibGUgaWYg dGhleSBhcmUgd3JpdHRlbiBtb3JlIGZ1bmN0aW9uLWxpa2UsIHRoYXQgaXMgdGhlIG5hbWUKPj4g YW5kIHBhcmFtdGVzIGFyZSBrZXB0IG9uIGEgbGluZSBvZiB0aGVpciBvd246Cj4+Cj4+ICNkZWZp bmUgaXNfa2VybmVsX21hcHBpbmcoeCkgXAo+PiAJKCh4KSA+PSBrZXJuZWxfdmlydF9hZGRyICYm ICh4KSA8IChrZXJuZWxfdmlydF9hZGRyICsgbG9hZF9zeikpCj4+Cj4+IEJ1dCB3aGF0IGlzIHRo ZSByZWFzb24gdG8gbm90IG1ha2UgdGhlbSB0eXBlLXNhZmUgaW5saW5lIGZ1bmN0aW9ucwo+PiBh bnl3YXk/Cj4KPiBObyByZWFzb24uIEkgd2lsbCB0aGVuIG1ha2UgdGhvc2UgbWFjcm9zIGlubGlu ZSBmdW5jdGlvbnMgYW5kIHNlbmQKPiBhbm90aGVyIHBhdGNoc2V0IHRvIG1ha2UgdGhlIGJlbG93 IG1hY3JvIGFuIGlubGluZSBmdW5jdGlvbiB0b28uCj4KPj4KPj4+ICAgI2RlZmluZSBfX3ZhX3Rv X3BhX25vZGVidWcoeCkJKHsJCQkJCQlcCj4+PiAgIAl1bnNpZ25lZCBsb25nIF94ID0geDsJCQkJ CQkJXAo+Pj4gLQkoX3ggPCBrZXJuZWxfdmlydF9hZGRyKSA/CQkJCQkJXAo+Pj4gKwlpc19saW5l YXJfbWFwcGluZyhfeCkgPwkJCQkJCQlcCj4+PiAgIAkJbGluZWFyX21hcHBpbmdfdmFfdG9fcGEo X3gpIDoga2VybmVsX21hcHBpbmdfdmFfdG9fcGEoX3gpOwlcCj4+PiAgIAl9KQo+Pgo+PiAuLi4g ZXNwZWNpYWxseSBmb3Igc29tZXRoaW5nIGNvbXBsZXggbGlrZSB0aGlzLgo+Pgo+Pj4gK3N0YXRp YyBpbmxpbmUgYm9vbCBpc192YV9rZXJuZWxfbG1fYWxpYXNfdGV4dCh1aW50cHRyX3QgdmEpCj4+ PiArewo+Pj4gKwlyZXR1cm4gKHZhID49ICh1aW50cHRyX3QpbG1fYWxpYXMoX3N0YXJ0KSAmJiB2 YSA8ICh1aW50cHRyX3QpbG1fYWxpYXMoX19pbml0X3RleHRfYmVnaW4pKTsKPj4KPj4gT3Zlcmx5 IGxvbmcgbGluZSBhcyB3ZWxsLiAgQW5kIHVzZWxlc3MgYnJhY2VzLgo+Cj4gT2suCj4KPj4KPj4+ ICtzdGF0aWMgaW5saW5lIGJvb2wgaXNfdmFfa2VybmVsX2luaXRfdGV4dCh1aW50cHRyX3QgdmEp Cj4+PiArewo+Pj4gKwlyZXR1cm4gKHZhID49ICh1aW50cHRyX3QpX19pbml0X3RleHRfYmVnaW4g JiYgdmEgPCAodWludHB0cl90KV9faW5pdF9kYXRhX2JlZ2luKTsKPj4+ICt9Cj4+Cj4+IFNhbWUg aGVyZS4KPgo+IGNoZWNrcGF0Y2ggZG9lcyBub3QgY29tcGxhaW4gYWJvdXQgdGhvc2UgbGluZXMg d2hpY2ggYXJlIHVuZGVyIDEwMAo+IGNoYXJhY3RlcnMsIHdoYXQncyB0aGUgcG9pbnQgaW4gYnJl YWtpbmcgdGhlbSBvbiBtdWx0aXBsZSBsaW5lcz8KPgo+Pgo+Pj4gKyNpZmRlZiBDT05GSUdfU1RS SUNUX0tFUk5FTF9SV1gKPj4+ICtzdGF0aWMgX19pbml0IHBncHJvdF90IHBncHJvdF9mcm9tX3Zh KHVpbnRwdHJfdCB2YSkKPj4+ICt7Cj4+PiArI2lmZGVmIENPTkZJR182NEJJVAo+Pj4gKwlpZiAo aXNfdmFfa2VybmVsX3RleHQodmEpIHx8IGlzX3ZhX2tlcm5lbF9pbml0X3RleHQodmEpKQo+Pj4g KwkJcmV0dXJuIFBBR0VfS0VSTkVMX1JFQURfRVhFQzsKPj4+ICsKPj4+ICsJLyoKPj4+ICsJICog V2UgbXVzdCBtYXJrIG9ubHkgdGV4dCBhcyByZWFkLW9ubHkgYXMgaW5pdCB0ZXh0IHdpbGwgZ2V0 IGZyZWVkIGxhdGVyCj4+PiArCSAqIGFuZCByb2RhdGEgc2VjdGlvbiBpcyBtYXJrZWQgcmVhZG9u bHkgaW4gbWFya19yb2RhdGFfcm8uCj4+PiArCSAqLwo+Pj4gKwlpZiAoaXNfdmFfa2VybmVsX2xt X2FsaWFzX3RleHQodmEpKQo+Pj4gKwkJcmV0dXJuIFBBR0VfS0VSTkVMX1JFQUQ7Cj4+PiArCj4+ PiArCXJldHVybiBQQUdFX0tFUk5FTDsKPj4+ICsjZWxzZQo+Pj4gKwlpZiAoaXNfdmFfa2VybmVs X3RleHQodmEpKQo+Pj4gKwkJcmV0dXJuIFBBR0VfS0VSTkVMX1JFQURfRVhFQzsKPj4+ICsKPj4+ ICsJaWYgKGlzX3ZhX2tlcm5lbF9pbml0X3RleHQodmEpKQo+Pj4gKwkJcmV0dXJuIFBBR0VfS0VS TkVMX0VYRUM7Cj4+PiArCj4+PiArCXJldHVybiBQQUdFX0tFUk5FTDsKPj4+ICsjZW5kaWYgLyog Q09ORklHXzY0QklUICovCj4+PiArfQo+Pgo+PiBJZiB0aGUgZW50aXJlIGZ1bmN0aW9uIGlzIGRp ZmZlcmVudCBmb3IgY29uZmlnIHN5bWJvbHMgcGxlYXNlIGp1c3QKPj4gc3BsaXQgaXQgaW50byB0 d28gc2VwYXJhdGUgZnVuY3Rpb25zLiAgQnV0IHRvIG1ha2UgdGhlIGRpZmZlcmVuY2UgbW9yZQo+ PiBjbGVhciBJU19FTkFCTEVEIG1pZ2h0IGZpdCBiZXR0ZXIgaGVyZToKPj4KPj4gc3RhdGljIF9f aW5pdCBwZ3Byb3RfdCBwZ3Byb3RfZnJvbV92YSh1aW50cHRyX3QgdmEpCj4+IHsKPj4gCWlmIChp c192YV9rZXJuZWxfdGV4dCh2YSkpCj4+IAkJcmV0dXJuIFBBR0VfS0VSTkVMX1JFQURfRVhFQzsK Pj4gCWlmIChpc192YV9rZXJuZWxfaW5pdF90ZXh0KHZhKSkKPj4gCQlyZXR1cm4gSVNfRU5BQkxF RChDT05GSUdfNjRCSVQpID8KPj4gCQkJUEFHRV9LRVJORUxfUkVBRF9FWEVDIDogUEFHRV9LRVJO RUxfRVhFQzsKPj4gCWlmIChJU19FTkFCTEVEKENPTkZJR182NEJJVCkgJiYgaXNfdmFfa2VybmVs X2xtX2FsaWFzX3RleHQodmEpKQo+PiAJCXJldHVybiBQQUdFX0tFUk5FTF9SRUFEOwo+PiAJcmV0 dXJuIFBBR0VfS0VSTkVMOwo+PiB9Cj4+Cj4+IFByZWZlcmFibGUgd2l0aCBjb21tZW50cyBleHBs YWluaW5nIHRoZSAzMi1iaXQgdnMgNjQtYml0IGRpZmZlcmVuY2UuCj4KPiBPayB0aGlzIGlzIG1v cmUgY29tcGFjdCwgSSdsbCBkbyB0aGF0IHdpdGggdGhlIGNvbW1lbnQuCj4KPj4KPj4+ICt2b2lk IG1hcmtfcm9kYXRhX3JvKHZvaWQpCj4+PiArewo+Pj4gKwl1bnNpZ25lZCBsb25nIHJvZGF0YV9z dGFydCA9ICh1bnNpZ25lZCBsb25nKV9fc3RhcnRfcm9kYXRhOwo+Pj4gKwl1bnNpZ25lZCBsb25n IGRhdGFfc3RhcnQgPSAodW5zaWduZWQgbG9uZylfZGF0YTsKPj4+ICsJdW5zaWduZWQgbG9uZyBf X21heWJlX3VudXNlZCBsbV9yb2RhdGFfc3RhcnQgPSAodW5zaWduZWQgbG9uZylsbV9hbGlhcyhf X3N0YXJ0X3JvZGF0YSk7Cj4+PiArCXVuc2lnbmVkIGxvbmcgX19tYXliZV91bnVzZWQgbG1fZGF0 YV9zdGFydCA9ICh1bnNpZ25lZCBsb25nKWxtX2FsaWFzKF9kYXRhKTsKPj4+ICsKPj4+ICsJc2V0 X21lbW9yeV9ybyhyb2RhdGFfc3RhcnQsIChkYXRhX3N0YXJ0IC0gcm9kYXRhX3N0YXJ0KSA+PiBQ QUdFX1NISUZUKTsKPj4+ICsjaWZkZWYgQ09ORklHXzY0QklUCj4+PiArCXNldF9tZW1vcnlfcm8o bG1fcm9kYXRhX3N0YXJ0LCAobG1fZGF0YV9zdGFydCAtIGxtX3JvZGF0YV9zdGFydCkgPj4gUEFH RV9TSElGVCk7Cj4+PiArI2VuZGlmCj4+Cj4+IExvdHMgb2YgdW5yZWFkYWJsZSBvdmVybHkgbG9u ZSBsaW5lcy4gIFdoeSBub3QgYWRkIGEgaGVscGVyIGFuZCBkbwo+PiBzb21ldGhpbmcgbGlrZToK Pj4KPj4gc3RhdGljIHZvaWQgc2V0X2tlcm5lbF9tZW1vcnlfcm8oY2hhciAqc3RhcnRwLCBjaGFy ICplbmRwKQo+PiB7Cj4+ICAgICAgICAgIHVuc2lnbmVkIGxvbmcgc3RhcnQgPSAodW5zaWduZWQg bG9uZylzdGFydHA7Cj4+IAl1bnNpZ25lZCBsb25nIGVuZCA9ICh1bnNpZ25lZCBsb25nKWVuZHA7 Cj4+Cj4+IAlzZXRfbWVtb3J5X3JvKHN0YXJ0LCAoc3RhcnQgLSBlbmQpID4+IFBBR0VfU0hJRlQp Owo+PiB9Cj4+Cj4+ICAgICAgICAgIHNldF9rZXJuZWxfbWVtb3J5X3JvKF9zdGFydF9yb2RhdGEs IF9kYXRhKTsKPj4gCWlmIChJU19FTkFCTEVEKENPTkZJR182NEJJVCkpCj4+IAkJc2V0X2tlcm5l bF9tZW1vcnlfcm8obG1fYWxpYXMoX19zdGFydF9yb2RhdGEpLCBsbV9hbGlhcyhfZGF0YSkpOwo+ Pgo+Pgo+Cj4gT2ssIHRoYXQncyBiZXR0ZXIgaW5kZWVkLiBJIHdpbGwgZG8gc29tZXRoaW5nIGxp a2UgdGhhdCBpbnN0ZWFkLCB0bwo+IGF2b2lkIG11bHRpcGxlIHZlcnNpb25zIG9mIHRoaXMgaGVs cGVyOgo+Cj4gaW50IHNldF9rZXJuZWxfbWVtb3J5KGNoYXIgKnN0YXJ0cCwgY2hhciAqZW5kcCwK Pgo+ICAgICAgICAgICAgICAgICAgICAgICAgaW50ICgqc2V0X21lbW9yeSkodW5zaWduZWQgbG9u ZyBzdGFydCwgaW50Cj4gbnVtX3BhZ2VzKSkKPgo+Pj4gK3N0YXRpYyBfX2luaXQgcGdwcm90X3Qg cGdwcm90X2Zyb21fdmEodWludHB0cl90IHZhKQo+Pj4gK3sKPj4+ICsjaWZkZWYgQ09ORklHXzY0 QklUCj4+PiArCWlmIChpc19rZXJuZWxfbWFwcGluZyh2YSkpCj4+PiArCQlyZXR1cm4gUEFHRV9L RVJORUxfRVhFQzsKPj4+ICsKPj4+ICsJaWYgKGlzX2xpbmVhcl9tYXBwaW5nKHZhKSkKPj4+ICsJ CXJldHVybiBQQUdFX0tFUk5FTDsKPj4+ICsKPj4+ICsJcmV0dXJuIFBBR0VfS0VSTkVMOwo+Pj4g KyNlbHNlCj4+PiArCXJldHVybiBQQUdFX0tFUk5FTF9FWEVDOwo+Pj4gKyNlbmRpZiAvKiBDT05G SUdfNjRCSVQgKi8KPj4+ICt9Cj4+PiArI2VuZGlmIC8qIENPTkZJR19TVFJJQ1RfS0VSTkVMX1JX WCAqLwo+Pj4gKwo+Pgo+PiBTYW1lIGNvbW1lbnQgYXMgZm9yIHRoZSBvdGhlciB2ZXJzaW9uLiAg VGhpcyBjb3VsZCBiZWNvbWU6Cj4+Cj4+IHN0YXRpYyBfX2luaXQgcGdwcm90X3QgcGdwcm90X2Zy b21fdmEodWludHB0cl90IHZhKQo+PiB7Cj4+IAlpZiAoSVNfRU5BQkxFRChDT05GSUdfNjRCSVQp ICYmICFpc19rZXJuZWxfbWFwcGluZyh2YSkpCj4+IAkJcmV0dXJuIFBBR0VfS0VSTkVMOwo+PiAJ cmV0dXJuIFBBR0VfS0VSTkVMX0VYRUM7Cj4+IH0KPgo+IE9rIEknbGwgZG8gdGhhdC4KPgo+Pgo+ Pj4gLXN0YXRpYyB2b2lkIF9faW5pdCBjcmVhdGVfa2VybmVsX3BhZ2VfdGFibGUocGdkX3QgKnBn ZGlyLCB1aW50cHRyX3QgbWFwX3NpemUpCj4+PiArc3RhdGljIHZvaWQgX19pbml0IGNyZWF0ZV9r ZXJuZWxfcGFnZV90YWJsZShwZ2RfdCAqcGdkaXIsIHVpbnRwdHJfdCBtYXBfc2l6ZSwgYm9vbCBl YXJseSkKPj4KPj4gT3Zlcmx5IGxvbmcgbGluZS4KPj4KPj4+ICAgCWZvciAodmEgPSBrZXJuZWxf dmlydF9hZGRyOyB2YSA8IGVuZF92YTsgdmEgKz0gbWFwX3NpemUpCj4+PiAgIAkJY3JlYXRlX3Bn ZF9tYXBwaW5nKHBnZGlyLCB2YSwKPj4+ICAgCQkJCSAgIGxvYWRfcGEgKyAodmEgLSBrZXJuZWxf dmlydF9hZGRyKSwKPj4+IC0JCQkJICAgbWFwX3NpemUsIFBBR0VfS0VSTkVMX0VYRUMpOwo+Pj4g KwkJCQkgICBtYXBfc2l6ZSwgZWFybHkgPyBQQUdFX0tFUk5FTF9FWEVDIDogcGdwcm90X2Zyb21f dmEodmEpKTsKPj4KPj4gU2FtZSBoZXJlLiAgQnV0IHdoeSBub3QgcGFzcyBpbiBhICJwZ3Byb3Rf dCByYW1fcGdwcm90IiBpbnN0ZWFkIG9mIHRoZQo+PiBib29sLCB3aGljaCB3b3VsZCBiZSBzZWxm LWRvY3VtZW50aW5nLgo+Cj4gVGhpcyBmdW5jdGlvbiBpcyB1c2VkIHRvIG1hcCB0aGUga2VybmVs IG1hcHBpbmcsIHRoZSBwZ3Byb3RfdCBpcyB0aGVuCj4gZGlmZmVyZW50IGluIGNyZWF0ZV9rZXJu ZWxfcGFnZV90YWJsZSBkZXBlbmRpbmcgb24gdGhlIHZpcnR1YWwgYWRkcmVzcwo+IHNvIEkgY2Fu J3QgcGFzcyBhIHNpbmdsZSBwZ3Byb3RfdCBmb3IgdGhhdCBvciBJIHdvdWxkIG5lZWQgYSBkdW1t eQo+IHBncHJvdF90IHRvIHRlc3QgYW55d2F5LgoKVGhhbmtzLiAgSSd2ZSBnb3QgYSByaXNjdi13 eC1tYXBwaW5ncyBicmFuY2ggd2l0aCB0aGUgZml4IG9uIGl0LCBJJ2xsIAp0YWtlIHRoaXMgb24g dGhlcmUgd2hlbiB3ZSBoYXZlIHNvbWV0aGluZyByZWFkeSB0byBnbyBhbmQgdGhlbiBtZXJnZSAK Ym90aCBpbnRvIGZvci1uZXh0IHNvIHdlIGNhbiBhdm9pZCBtZXJnZSBjb25mbGljdHMuCgo+Cj4g VGhhbmsgeW91IGZvciB5b3VyIHJldmlldywKPgo+IEFsZXgKPgo+Pgo+PiBfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+PiBsaW51eC1yaXNjdiBtYWlsaW5n IGxpc3QKPj4gbGludXgtcmlzY3ZAbGlzdHMuaW5mcmFkZWFkLm9yZwo+PiBodHRwOi8vbGlzdHMu aW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJpc2N2Cj4+CgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1yaXNjdiBtYWlsaW5n IGxpc3QKbGludXgtcmlzY3ZAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFk ZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJpc2N2Cg==