From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759514AbdEWEtj (ORCPT ); Tue, 23 May 2017 00:49:39 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:33037 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759432AbdEWEth (ORCPT ); Tue, 23 May 2017 00:49:37 -0400 Date: Mon, 22 May 2017 21:49:35 -0700 (PDT) X-Google-Original-Date: Mon, 22 May 2017 21:44:34 PDT (-0700) From: Palmer Dabbelt To: rdunlap@infradead.org CC: olof@lixom.net CC: linux-kernel@vger.kernel.org CC: Arnd Bergmann CC: albert@sifive.com CC: patches@groups.riscv.org Subject: Re: [PATCH 2/7] RISC-V: arch/riscv Makefile and Kconfigs In-Reply-To: <4a5c4bcc-6975-265e-40c5-a4d708712b8c@infradead.org> Message-ID: Mime-Version: 1.0 (MHng) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 22 May 2017 18:31:08 PDT (-0700), rdunlap@infradead.org wrote: > On 05/22/17 18:27, Olof Johansson wrote: >> Hi, >> >> >> On Mon, May 22, 2017 at 5:41 PM, Palmer Dabbelt wrote: >>> --- >>> arch/riscv/.gitignore | 35 ++++ >>> arch/riscv/Kconfig | 300 +++++++++++++++++++++++++++++++++++ >>> arch/riscv/Makefile | 64 ++++++++ >>> arch/riscv/configs/riscv32_spike | 47 ++++++ >>> arch/riscv/configs/riscv64_freedom-u | 52 ++++++ >>> arch/riscv/configs/riscv64_qemu | 64 ++++++++ >>> arch/riscv/configs/riscv64_spike | 45 ++++++ >>> 7 files changed, 607 insertions(+) >>> create mode 100644 arch/riscv/.gitignore >>> create mode 100644 arch/riscv/Kconfig >>> create mode 100644 arch/riscv/Makefile >>> create mode 100644 arch/riscv/configs/riscv32_spike >>> create mode 100644 arch/riscv/configs/riscv64_freedom-u >>> create mode 100644 arch/riscv/configs/riscv64_qemu >>> create mode 100644 arch/riscv/configs/riscv64_spike >> >> Nearly all other platforms have _defconfig in the config names. It >> might get a bit excessive to prepend riscv{32,64} to all of them >> though. Most other platforms have shortened it to, for example, >> spike_defconfig, spike64_defconfig, qemu_defconfig, >> freedom-u_defconfig. >> >> Not going to argue too much about the color of the shed here, but >> using the _defconfig naming is recommended. > > well, the top-level Makefile looks for "make *config" to indicate that > there is a config-command in progress (or in process), so they usually > have to end in the string "config". > > Have these been tested? Ah, that's much better -- I've just been copying them to .config :). I've already renamed them to things that end in defconfig. Thanks!