From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751053AbdGZFUx (ORCPT ); Wed, 26 Jul 2017 01:20:53 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:35311 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750971AbdGZFUw (ORCPT ); Wed, 26 Jul 2017 01:20:52 -0400 Date: Tue, 25 Jul 2017 22:20:50 -0700 (PDT) X-Google-Original-Date: Tue, 25 Jul 2017 22:20:10 PDT (-0700) Subject: Re: [patches] [PATCH 17/17] RISC-V: Build Infastructure In-Reply-To: <20170726025717.lob7jlrb6ipa6rel@latitude> CC: patches@groups.riscv.org, Olof Johansson , Arnd Bergmann , akpm@linux-foundation.org, albert@sifive.com, yamada.masahiro@socionext.com, mmarek@suse.com, will.deacon@arm.com, peterz@infradead.org, boqun.feng@gmail.com, mingo@redhat.com, daniel.lezcano@linaro.org, tglx@linutronix.de, jason@lakedaemon.net, marc.zyngier@arm.com, gregkh@linuxfoundation.org, jslaby@suse.com, davem@davemloft.net, mchehab@kernel.org, sfr@canb.auug.org.au, fweisbec@gmail.com, viro@zeniv.linux.org.uk, mcgrof@kernel.org, dledford@redhat.com, bart.vanassche@sandisk.com, sstabellini@kernel.org, daniel.vetter@ffwll.ch, mpe@ellerman.id.au, msalter@redhat.com, nicolas.dichtel@6wind.com, james.hogan@imgtec.com, paul.gortmaker@windriver.com, linux@roeck-us.net, heiko.carstens@de.ibm.com, schwidefsky@de.ibm.com, linux-kernel@vger.kernel.org From: Palmer Dabbelt To: j.neuschaefer@gmx.net Message-ID: Mime-Version: 1.0 (MHng) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 25 Jul 2017 19:57:17 PDT (-0700), j.neuschaefer@gmx.net wrote: > On Tue, Jul 11, 2017 at 06:31:30PM -0700, Palmer Dabbelt wrote: >> This patch contains all the build infastructure that actually enables >> the RISC-V port. This includes Makefiles, linker scripts, and Kconfig >> files. It also contains the only top-level change, which adds RISC-V to >> the list of architectures that need a sed run to produce the ARCH >> variable when building locally. >> >> Signed-off-by: Palmer Dabbelt >> --- > [...] >> +config ISA_C >> + bool "Emit compressed instructions when building Linux" > > As a user, I'd prefer to have slightly more globally-recognisable names > than ISA_ for RISC-V instruction set architecture > extensions. A quick "git grep -A2 'config ISA'" shows the following > Kconfig symbols: > > * ISA, ISA_BUS_API, ISA_DMA_API, ISAPNP: > Settings related to the historic ISA bus. > * ISA_ARCOMPACT/ISA_ARCV2 (arch/arc), > ISA_M32R/ISA_M32R2/ISA_DSP_LEVEL2/ISA_DUAL_ISSUE (arch/m32r): > Instruction set options. > > Four out of the six instruction set options have ARC/M32R in the name, > and I think that makes things slightly more readable. Therefore I > humbly propose something longer, and with a hint of RISC-V in the name, > such as ISA_RVC. > > (Take this with a grain of salt, perhaps.) Good timing: I was about to submit a v6 patch set. I'm cool with CONFIG_ISA_RVC and friends, do you mind submitting a patch?