From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 038ACC2D0FB for ; Tue, 12 May 2020 23:00:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D894620740 for ; Tue, 12 May 2020 23:00:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=dabbelt-com.20150623.gappssmtp.com header.i=@dabbelt-com.20150623.gappssmtp.com header.b="eqwTzxzf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731524AbgELXA1 (ORCPT ); Tue, 12 May 2020 19:00:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33162 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725938AbgELXA0 (ORCPT ); Tue, 12 May 2020 19:00:26 -0400 Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 61E7AC061A0C for ; Tue, 12 May 2020 16:00:26 -0700 (PDT) Received: by mail-pg1-x541.google.com with SMTP id l12so6864630pgr.10 for ; Tue, 12 May 2020 16:00:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dabbelt-com.20150623.gappssmtp.com; s=20150623; h=date:subject:in-reply-to:cc:from:to:message-id:mime-version :content-transfer-encoding; bh=ANYA6Uqt8JmQsCZkIHeMhChyGR2ABYbN7ab10n0Cyr8=; b=eqwTzxzfiHOX9idt3KO/0v/oXs46V6+ltH8+ODxDgE0xTtbWLhrQqjj/I4MLeTo7qx XH01gBCpb1wq6pkrBgTdUvNaHUet6KIGOrw+El7Q0VATiiu5Hm3ud0zB9mQ6vWmG+TXj lPrFz2yeuuqPPDExkB4Ui+7wK2wO1wcIk1DCnfKN+v7JH7HpAkPwVg2eg1udvimBywzs HMWSz5VlN5LaHs9s+FDqffjRlIrM1FDVkvPKUQxik3z9ZLS3LnM/OzYDTa+1rOwxB58H aJ7Nm9BiiVb+HxaLiOGxmNB5rkCNad2b2Bn7VaGNst1546ZG/wZIGmwNZ7PYKNZh5IhU pxBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:subject:in-reply-to:cc:from:to:message-id :mime-version:content-transfer-encoding; bh=ANYA6Uqt8JmQsCZkIHeMhChyGR2ABYbN7ab10n0Cyr8=; b=CajXRYDU5PSiP0uOX+erqgvv0mx/CkFIz1YFVbG2uMEY67j2zawu4VWMnhzNwA/4Wz i4jLGvNKTepodxCElbQkNKzeYuCVrymvH931qUGe6rA3+qEVvOjqvEpiUSB5+H/VBoF4 5tXhw6GCRitm/twF42V28X596rWnHZVVG9x76GD7B9+qOA717IK+ENvQ20swWfuhvDyG acHyO8etRotoSfNjBthC4LkrxmAYpo7VySEoOzmtioiNqa8RjxqiAqIaFfPbzHLGX2vL WmxS3ZaM+sRzHFO5xi3GCI/23SNO5WJSm6OH34VW/Aa8PmTx7gm/iTwdiTPIaJ3Ew3Ca g1rQ== X-Gm-Message-State: AGi0PuZiTOTwUpwWlQLDVKX5+NuILrbBkqCj4LcdnW8S1OsB9kWYcCUx Xhm3j/kz+kktFOTUm3u5JBkQ3A== X-Google-Smtp-Source: APiQypKpItiCTq+LL3cwMHlGAk6EceSJc41DnTPbVWgGyBzY+wmrmmIeI/2RQL5jF31HJQFyTVmDkA== X-Received: by 2002:a63:d742:: with SMTP id w2mr21237526pgi.180.1589324425601; Tue, 12 May 2020 16:00:25 -0700 (PDT) Received: from localhost (76-210-143-223.lightspeed.sntcca.sbcglobal.net. [76.210.143.223]) by smtp.gmail.com with ESMTPSA id b9sm12707480pfp.12.2020.05.12.16.00.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 May 2020 16:00:23 -0700 (PDT) Date: Tue, 12 May 2020 16:00:23 -0700 (PDT) X-Google-Original-Date: Tue, 12 May 2020 14:10:27 PDT (-0700) Subject: Re: [PATCH v1 1/1] tty: serial: add missing spin_lock_init for SiFive serial console In-Reply-To: <1589019852-21505-2-git-send-email-sagar.kadam@sifive.com> CC: linux-serial@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Paul Walmsley , aou@eecs.berkeley.edu, Atish Patra , Anup Patel , sagar.kadam@sifive.com From: Palmer Dabbelt To: sagar.kadam@sifive.com, Greg KH Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 09 May 2020 03:24:12 PDT (-0700), sagar.kadam@sifive.com wrote: > An uninitialised spin lock for sifive serial console raises a bad > magic spin_lock error as reported and discussed here [1]. > Initialising the spin lock resolves the issue. > > The fix is tested on HiFive Unleashed A00 board with Linux 5.7-rc4 > and OpenSBI v0.7 > > [1] https://lore.kernel.org/linux-riscv/b9fe49483a903f404e7acc15a6efbef756db28ae.camel@wdc.com > > Fixes: 45c054d0815b ("tty: serial: add driver for the SiFive UART") > Reported-by: Atish Patra > Signed-off-by: Sagar Shrikant Kadam > --- > drivers/tty/serial/sifive.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/tty/serial/sifive.c b/drivers/tty/serial/sifive.c > index 13eadcb..0b5110d 100644 > --- a/drivers/tty/serial/sifive.c > +++ b/drivers/tty/serial/sifive.c > @@ -883,6 +883,7 @@ console_initcall(sifive_console_init); > > static void __ssp_add_console_port(struct sifive_serial_port *ssp) > { > + spin_lock_init(&ssp->port.lock); > sifive_serial_console_ports[ssp->port.line] = ssp; > } Reviewed-by: Palmer Dabbelt Acked-by: Palmer Dabbelt I'm assuming it's going in through Greg's tree. Thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38F85C2D0FB for ; Tue, 12 May 2020 23:00:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0614620747 for ; Tue, 12 May 2020 23:00:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="p7tYJtFu"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=dabbelt-com.20150623.gappssmtp.com header.i=@dabbelt-com.20150623.gappssmtp.com header.b="eqwTzxzf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0614620747 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=dabbelt.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Content-Transfer-Encoding:Content-Type:Mime-Version:Message-ID:To:From: In-Reply-To:Subject:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=ANYA6Uqt8JmQsCZkIHeMhChyGR2ABYbN7ab10n0Cyr8=; b=p7tYJtFuJZPMi+ RtQuf51p/qJ66S1wh3j0HbpXx8xsjBWdujgZtsdv2U7+MVXWAGpgoq1WRUADELcqEpOon5rn48os0 ofzkgthazYnEZIk8Udzp6ulx4/EXYOzcx2QeLp8V2QfeTU/o9saeEqsIEtdBsqgyYcAUsrBzus1mM HHh8INgcZkXCMo9VlORS427ncZUzgUGUnPWObbuRp40geAXu7Sgawspr5/K9NgqDbOKNcYkYLTXly NMXzPis2iM5WQSmbqTtcN2d39O/6DX0lwkw5JUVnXVx9HjkoSI3lqTV/Wjn0GcsA84uF0Z7XsQr8/ r9Tccui7fZLe289Z7hqg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jYdsz-0004eZ-Gg; Tue, 12 May 2020 23:00:29 +0000 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jYdsx-0004e2-97 for linux-riscv@lists.infradead.org; Tue, 12 May 2020 23:00:28 +0000 Received: by mail-pg1-x543.google.com with SMTP id t11so6877945pgg.2 for ; Tue, 12 May 2020 16:00:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dabbelt-com.20150623.gappssmtp.com; s=20150623; h=date:subject:in-reply-to:cc:from:to:message-id:mime-version :content-transfer-encoding; bh=ANYA6Uqt8JmQsCZkIHeMhChyGR2ABYbN7ab10n0Cyr8=; b=eqwTzxzfiHOX9idt3KO/0v/oXs46V6+ltH8+ODxDgE0xTtbWLhrQqjj/I4MLeTo7qx XH01gBCpb1wq6pkrBgTdUvNaHUet6KIGOrw+El7Q0VATiiu5Hm3ud0zB9mQ6vWmG+TXj lPrFz2yeuuqPPDExkB4Ui+7wK2wO1wcIk1DCnfKN+v7JH7HpAkPwVg2eg1udvimBywzs HMWSz5VlN5LaHs9s+FDqffjRlIrM1FDVkvPKUQxik3z9ZLS3LnM/OzYDTa+1rOwxB58H aJ7Nm9BiiVb+HxaLiOGxmNB5rkCNad2b2Bn7VaGNst1546ZG/wZIGmwNZ7PYKNZh5IhU pxBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:subject:in-reply-to:cc:from:to:message-id :mime-version:content-transfer-encoding; bh=ANYA6Uqt8JmQsCZkIHeMhChyGR2ABYbN7ab10n0Cyr8=; b=P13tIDqSps4RFD4ItoQYROoa187r2SdbiGAg8YP9AhlT2XzuAimz51k9lWcypMkITi OUeeM4L4skrtZQCjZnCmYtN8d9Vo+kFU4BWrb95gBUV/hRjEMkwWwIp6PqFrBXGDQRfn 4Li9VuV32XdlKM5MwmpjYhL/tuvyL2ie8PDO5w5MYz5R35AHscEte9+I4TpINqBYRwrg bV1DYmQcmeqksWl0udHei76q9kQFJqu0kNk94bn9gzILRjJjrVBhuNOJeLqpwP/XdK0K R9FlfUjKFKSbGv0+9RGgg5qttIfwQtiWJNJPy57ZFrphGSaJQJBg5rhkN6K8z6HlmOCR gKQA== X-Gm-Message-State: AGi0Pubq6omqIIKVSw/O6sIIcbRMlfCScFz1CkOmSXGscWgky7M6UInN 0WKhjTPsgo03Hyj5WfItF1Kk4Q== X-Google-Smtp-Source: APiQypKpItiCTq+LL3cwMHlGAk6EceSJc41DnTPbVWgGyBzY+wmrmmIeI/2RQL5jF31HJQFyTVmDkA== X-Received: by 2002:a63:d742:: with SMTP id w2mr21237526pgi.180.1589324425601; Tue, 12 May 2020 16:00:25 -0700 (PDT) Received: from localhost (76-210-143-223.lightspeed.sntcca.sbcglobal.net. [76.210.143.223]) by smtp.gmail.com with ESMTPSA id b9sm12707480pfp.12.2020.05.12.16.00.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 May 2020 16:00:23 -0700 (PDT) Date: Tue, 12 May 2020 16:00:23 -0700 (PDT) X-Google-Original-Date: Tue, 12 May 2020 14:10:27 PDT (-0700) Subject: Re: [PATCH v1 1/1] tty: serial: add missing spin_lock_init for SiFive serial console In-Reply-To: <1589019852-21505-2-git-send-email-sagar.kadam@sifive.com> From: Palmer Dabbelt To: sagar.kadam@sifive.com, Greg KH Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200512_160027_368541_F7DB7317 X-CRM114-Status: GOOD ( 16.26 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: aou@eecs.berkeley.edu, Anup Patel , linux-kernel@vger.kernel.org, Atish Patra , sagar.kadam@sifive.com, linux-serial@vger.kernel.org, Paul Walmsley , linux-riscv@lists.infradead.org Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org On Sat, 09 May 2020 03:24:12 PDT (-0700), sagar.kadam@sifive.com wrote: > An uninitialised spin lock for sifive serial console raises a bad > magic spin_lock error as reported and discussed here [1]. > Initialising the spin lock resolves the issue. > > The fix is tested on HiFive Unleashed A00 board with Linux 5.7-rc4 > and OpenSBI v0.7 > > [1] https://lore.kernel.org/linux-riscv/b9fe49483a903f404e7acc15a6efbef756db28ae.camel@wdc.com > > Fixes: 45c054d0815b ("tty: serial: add driver for the SiFive UART") > Reported-by: Atish Patra > Signed-off-by: Sagar Shrikant Kadam > --- > drivers/tty/serial/sifive.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/tty/serial/sifive.c b/drivers/tty/serial/sifive.c > index 13eadcb..0b5110d 100644 > --- a/drivers/tty/serial/sifive.c > +++ b/drivers/tty/serial/sifive.c > @@ -883,6 +883,7 @@ console_initcall(sifive_console_init); > > static void __ssp_add_console_port(struct sifive_serial_port *ssp) > { > + spin_lock_init(&ssp->port.lock); > sifive_serial_console_ports[ssp->port.line] = ssp; > } Reviewed-by: Palmer Dabbelt Acked-by: Palmer Dabbelt I'm assuming it's going in through Greg's tree. Thanks!