From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0658EC433F5 for ; Wed, 6 Oct 2021 16:52:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E2B7E61130 for ; Wed, 6 Oct 2021 16:52:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233365AbhJFQyq (ORCPT ); Wed, 6 Oct 2021 12:54:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43416 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229835AbhJFQyn (ORCPT ); Wed, 6 Oct 2021 12:54:43 -0400 Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F795C061755 for ; Wed, 6 Oct 2021 09:52:51 -0700 (PDT) Received: by mail-pl1-x62b.google.com with SMTP id n2so2027152plk.12 for ; Wed, 06 Oct 2021 09:52:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:subject:in-reply-to:cc:from:to:message-id:mime-version :content-transfer-encoding; bh=tE2mxdh37dnyxx/6GEpmhKLL+VCgiyppriZBIEN9Yek=; b=ZgSYszkACVNYbPHRv6dT0Y71PsmUfzugPsUa5R+6KzBhBz4OXDPWevSFbzHG7TTBrx O8hidqI1gV5G8yuWIAwdZe1qu2PgHRfI/GiPxgzXg6Z4gfjM/WGjc3jAwGCC6kA44aQK dkLxOk42bZuJmnjwg84M/m6XZb+JBjBg/27Yd9aN8+PRmGfu0Fh+ahVMfZ4kEefzNU6J d/1PWGJRMFij2Mj/Rrz1oOf85Ryu0YoxOtWsbCpCDjOAjre797K799fPHa0WKplUU4VQ /r0VoP+HkKKJ705siLyeDGON4T9AB90BkuvBG/A6zp/SyPab3luVPsTV1kIEfQh7ptsm WY9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:subject:in-reply-to:cc:from:to:message-id :mime-version:content-transfer-encoding; bh=tE2mxdh37dnyxx/6GEpmhKLL+VCgiyppriZBIEN9Yek=; b=aYYN+3YN5N8PhT5oc0HMPXO2+k1G4VD/NK619N4H11XRPmqXvaeTpotIfHGD2Sn5rz 2CSSuxjjfqKb7XJ0WBeY66M7NNyJLpFuiyQquMmfYWCn0xMlS5VY0jN/2WVRhLoPkmq0 4oLrLLZqlqHXmDKaVRm1ZvJf2ELSfrJFw+LCRB847IOLD9jnsDPWfrTvceo1WzC0JNWI iXQMTxgwpj+wZVBF2fIW1ZTpg7gVSeIznuMOHYUTRAI3FwAkzyxFprm+yr11mImSFN6+ t5v/mCHPd740Ezv1ozV5ogN3TcGYjzDKdCLzo682A7VSCJKhJ0oR2rRBQPPh3Dr+QIdP nvNA== X-Gm-Message-State: AOAM530/FeLbph3qDerDrVAvLlPLX0fcMX1Oz7x9mozeqqjlaPgbCf+v WsSCpG0XUffGMaRiE6uOU5x7dHyimqxv8g== X-Google-Smtp-Source: ABdhPJwTBcQVmbKGkS9vwq4EiC9JTSG8DwDNpJPlsNCPI/DX2wwEwAFi6KDnd7CVB87LQIBKqStMNw== X-Received: by 2002:a17:902:ea93:b0:13e:c727:3026 with SMTP id x19-20020a170902ea9300b0013ec7273026mr12001089plb.53.1633539170709; Wed, 06 Oct 2021 09:52:50 -0700 (PDT) Received: from localhost (76-210-143-223.lightspeed.sntcca.sbcglobal.net. [76.210.143.223]) by smtp.gmail.com with ESMTPSA id r130sm14086047pfc.89.2021.10.06.09.52.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Oct 2021 09:52:50 -0700 (PDT) Date: Wed, 06 Oct 2021 09:52:50 -0700 (PDT) X-Google-Original-Date: Wed, 06 Oct 2021 09:52:48 PDT (-0700) Subject: Re: [PATCH] asm-generic: correct reference to GENERIC_LIB_DEVMEM_IS_ALLOWED In-Reply-To: CC: lukas.bulwahn@gmail.com, Arnd Bergmann , mcgrof@kernel.org, linux-arch@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org From: Palmer Dabbelt To: Arnd Bergmann Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 06 Oct 2021 08:17:38 PDT (-0700), Arnd Bergmann wrote: > On Wed, Oct 6, 2021 at 5:00 PM Lukas Bulwahn wrote: >> >> Commit 527701eda5f1 ("lib: Add a generic version of devmem_is_allowed()") >> introduces the config symbol GENERIC_LIB_DEVMEM_IS_ALLOWED, but then >> falsely refers to CONFIG_GENERIC_DEVMEM_IS_ALLOWED (note the missing LIB >> in the reference) in ./include/asm-generic/io.h. >> >> Luckily, ./scripts/checkkconfigsymbols.py warns on non-existing configs: >> >> GENERIC_DEVMEM_IS_ALLOWED >> Referencing files: include/asm-generic/io.h >> >> Correct the name of the config to the intended one. >> >> Fixes: 527701eda5f1 ("lib: Add a generic version of devmem_is_allowed()") >> Signed-off-by: Lukas Bulwahn > > Acked-by: Arnd Bergmann Reviewed-by: Palmer Dabbelt Acked-by: Palmer Dabbelt Thanks. I'm going to assume this is going in through some other tree, but IIUC I sent the buggy patch up so LMK if you're expecting it to go through mine.