From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93A4BC54FD0 for ; Thu, 23 Apr 2020 22:43:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 703B220715 for ; Thu, 23 Apr 2020 22:43:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=dabbelt-com.20150623.gappssmtp.com header.i=@dabbelt-com.20150623.gappssmtp.com header.b="jxWUUAHc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726079AbgDWWnc (ORCPT ); Thu, 23 Apr 2020 18:43:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726071AbgDWWnb (ORCPT ); Thu, 23 Apr 2020 18:43:31 -0400 Received: from mail-pf1-x444.google.com (mail-pf1-x444.google.com [IPv6:2607:f8b0:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CAABEC09B042 for ; Thu, 23 Apr 2020 15:43:31 -0700 (PDT) Received: by mail-pf1-x444.google.com with SMTP id 18so3756957pfx.6 for ; Thu, 23 Apr 2020 15:43:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dabbelt-com.20150623.gappssmtp.com; s=20150623; h=date:subject:in-reply-to:cc:from:to:message-id:mime-version :content-transfer-encoding; bh=N/UJzAr5dtehQTHBzXy34ZuA/CAq9RTQL58DIHmSsDU=; b=jxWUUAHcZRLKkUCvwG3LxBUbKC0Gy7M7XkL63S5P+Xc5a3iB/dxyTwjsaiq4YSnhnt nIliNPSoyS+0tv7rEPxJKt7d8S1w6c/T+RHiHtG22tL7VE5ho57cXV+QrFES49a64tsJ BZ6PVIAu3W3xz8b0WQzrCxrf2DoTSi8VGlPxqsH9j/2/nJE3pj8A+EKCsXYC+jH4qEf8 Gg37qlnOEK3/IALDBKMZVl9POHEbSulN/OrRyrTizHNo2f30rBVjCawgISMTyrBzimDB 3YiXkmmIIMeQo17eMp9Tfm9Kz7wNhm1YB7QQ8LZX2coRgsw2xGX2ODlWk32ivaBvC1cU ZnrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:subject:in-reply-to:cc:from:to:message-id :mime-version:content-transfer-encoding; bh=N/UJzAr5dtehQTHBzXy34ZuA/CAq9RTQL58DIHmSsDU=; b=N18u0PGUQESxc2FWSWZdQeeb1mnV/YGmeK3A7XtBAHr7H0G3bEIV44RViWqhv8r0vP lC/30CglOnDY0KyJvnBiYdpcih+UU6v5UEL3a+zuXlaY8jRXCMMvegxY6KYOcoUjoM75 qGewMy6F8NVTr2FQoGBSo8oBOwTlFT04+JQNB43znFf7jJ8IY53B1jRQfCTk2I5JDjic BTULyb5HD+ggZXI8+03LWNUp6Kimlu5Pl+mHWHbeFcLsdKOIUlNYmO4C+v8jZKSRyo2y hvdwjoNfTiQjLwk0TKQbU6VQOMBdCmiGpkOz313TXIQ4oz7LQRJtvMCPQk6GxKoG2SU2 GRpg== X-Gm-Message-State: AGi0PuY3+hGtIwvkmKLRd7KbdYnqrUrNmcP2PUjfD3/7JQKbXGcikKJd rstNusoLboEKATyTrmfEc5KGtxJ5W4n5hA== X-Google-Smtp-Source: APiQypK+qFJjBWZIM4JseuejIHzEpgez/1Eb2rNDWCq0/ARVphGcY6JqUI7zr0Fw6Lx1kMeyag+eTA== X-Received: by 2002:a62:25c6:: with SMTP id l189mr6346111pfl.28.1587681810670; Thu, 23 Apr 2020 15:43:30 -0700 (PDT) Received: from localhost (76-210-143-223.lightspeed.sntcca.sbcglobal.net. [76.210.143.223]) by smtp.gmail.com with ESMTPSA id o9sm3280699pje.47.2020.04.23.15.43.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2020 15:43:29 -0700 (PDT) Date: Thu, 23 Apr 2020 15:43:29 -0700 (PDT) X-Google-Original-Date: Thu, 23 Apr 2020 15:43:27 PDT (-0700) Subject: Re: [PATCH v5 0/7] Add UEFI support for RISC-V In-Reply-To: <20200422172414.6662-1-ardb@kernel.org> CC: linux-efi@vger.kernel.org, ardb@kernel.org, Atish Patra , Paul Walmsley , aou@eecs.berkeley.edu, linux-riscv@lists.infradead.org From: Palmer Dabbelt To: ardb@kernel.org Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-efi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-efi@vger.kernel.org On Wed, 22 Apr 2020 10:24:07 PDT (-0700), ardb@kernel.org wrote: > This is a rework of Atish's series [0] to add EFI stub loader support > to the RISC-V port. The purpose is to split the code in a way that makes > it amenable to being merged via different trees during the same cycle. > While at it, I added a patch to disable initrd= loading for new ports, > given that it is deprecated and replaced with a method based on a > special UEFI device path. > > My changes are logged in the individual patches. > > I propose to take the first four patches via the EFI tree, and expose > them via a stable tag so that the RISC-V maintainers can merge it before > applying the remaining patches. That will ensure that both trees remain > in a buildable state, with working EFI stub support on the riscv branch. Works for me. Thanks! > > Cc: Atish Patra > Cc: Palmer Dabbelt > Cc: Paul Walmsley > Cc: Albert Ou > Cc: linux-riscv@lists.infradead.org > > Ard Biesheuvel (1): > efi/libstub: Make initrd file loader configurable > > Atish Patra (6): > efi/libstub: Move arm-stub to a common file > efi/libstub/riscv: add arch specific efi.h header file > include: pe.h: Add RISC-V related PE definition > RISC-V: Define fixmap bindings for generic early ioremap support > RISC-V: Add PE/COFF header for EFI stub > RISC-V: Add EFI stub support. > > arch/arm/Kconfig | 2 +- > arch/arm64/Kconfig | 2 +- > arch/riscv/Kconfig | 21 ++++ > arch/riscv/Makefile | 1 + > arch/riscv/configs/defconfig | 1 + > arch/riscv/include/asm/Kbuild | 1 + > arch/riscv/include/asm/efi.h | 41 +++++++ > arch/riscv/include/asm/fixmap.h | 18 +++ > arch/riscv/include/asm/io.h | 1 + > arch/riscv/include/asm/sections.h | 13 +++ > arch/riscv/kernel/Makefile | 4 + > arch/riscv/kernel/efi-header.S | 100 ++++++++++++++++ > arch/riscv/kernel/head.S | 16 +++ > arch/riscv/kernel/image-vars.h | 53 +++++++++ > arch/riscv/kernel/vmlinux.lds.S | 22 +++- > drivers/firmware/efi/Kconfig | 15 ++- > drivers/firmware/efi/libstub/Makefile | 22 +++- > .../efi/libstub/{arm-stub.c => efi-stub.c} | 0 > drivers/firmware/efi/libstub/file.c | 3 + > drivers/firmware/efi/libstub/riscv-stub.c | 109 ++++++++++++++++++ > include/linux/pe.h | 3 + > 21 files changed, 436 insertions(+), 12 deletions(-) > create mode 100644 arch/riscv/include/asm/efi.h > create mode 100644 arch/riscv/include/asm/sections.h > create mode 100644 arch/riscv/kernel/efi-header.S > create mode 100644 arch/riscv/kernel/image-vars.h > rename drivers/firmware/efi/libstub/{arm-stub.c => efi-stub.c} (100%) > create mode 100644 drivers/firmware/efi/libstub/riscv-stub.c From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB9DBC54FCB for ; Thu, 23 Apr 2020 22:43:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AAA9620724 for ; Thu, 23 Apr 2020 22:43:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Fha7WGkb"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=dabbelt-com.20150623.gappssmtp.com header.i=@dabbelt-com.20150623.gappssmtp.com header.b="jxWUUAHc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AAA9620724 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=dabbelt.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Content-Transfer-Encoding:Content-Type:Mime-Version:Message-ID:To:From: In-Reply-To:Subject:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=N/UJzAr5dtehQTHBzXy34ZuA/CAq9RTQL58DIHmSsDU=; b=Fha7WGkbUWWq4k oAHL2KkMW95+1Eu3Ovgk2gjTkNh7NMBmqc7t9yXE4APyPEnrRgcrXkNvr69OuhsltlM3JE+t6+bPx qshsXIXX5wpLOecnZdEh3UfRiae9Tz1fHbZSmUv3yFpokPi+6aoEPtpfXK2zUhi8tivn3Lfyy+zc8 nNMZuJpy/CK5F+3Jeg6xBYmwUyU+OViDBXpgGYdT83zuf6GIZeoBqBQXzPaV0vNfEyrt5scgjAvvl 9W7nvLsHqBqSg1s0w5X8VT+MTxuKq1WYcatYlnCCPaxKWI05abw7+1ppXGgajO24b+76d8izNnyeK KpaPMg2rZufTicekPLkQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jRkZE-0008Nm-O9; Thu, 23 Apr 2020 22:43:36 +0000 Received: from mail-pf1-x442.google.com ([2607:f8b0:4864:20::442]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jRkZB-0008Mq-4i for linux-riscv@lists.infradead.org; Thu, 23 Apr 2020 22:43:34 +0000 Received: by mail-pf1-x442.google.com with SMTP id x77so3778516pfc.0 for ; Thu, 23 Apr 2020 15:43:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dabbelt-com.20150623.gappssmtp.com; s=20150623; h=date:subject:in-reply-to:cc:from:to:message-id:mime-version :content-transfer-encoding; bh=N/UJzAr5dtehQTHBzXy34ZuA/CAq9RTQL58DIHmSsDU=; b=jxWUUAHcZRLKkUCvwG3LxBUbKC0Gy7M7XkL63S5P+Xc5a3iB/dxyTwjsaiq4YSnhnt nIliNPSoyS+0tv7rEPxJKt7d8S1w6c/T+RHiHtG22tL7VE5ho57cXV+QrFES49a64tsJ BZ6PVIAu3W3xz8b0WQzrCxrf2DoTSi8VGlPxqsH9j/2/nJE3pj8A+EKCsXYC+jH4qEf8 Gg37qlnOEK3/IALDBKMZVl9POHEbSulN/OrRyrTizHNo2f30rBVjCawgISMTyrBzimDB 3YiXkmmIIMeQo17eMp9Tfm9Kz7wNhm1YB7QQ8LZX2coRgsw2xGX2ODlWk32ivaBvC1cU ZnrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:subject:in-reply-to:cc:from:to:message-id :mime-version:content-transfer-encoding; bh=N/UJzAr5dtehQTHBzXy34ZuA/CAq9RTQL58DIHmSsDU=; b=qzFnhN4OKdtRatu/8HjBUxcM2k73z5/l4949F3WKdQ0B/ohhto0xHpHxiAZoT96jPa KknZuKos+Ygtwd8oz1c9RiNjJ5+HtsG0p1wSjQucPzJUNYV4AVLQNjdrE9+7Ua1FuT9O Z6pxPae0tGPIZf8zAxgpbQj/70Yu8FbrZcaXSKBAV81zqiqEFtnnRhEC2OTsN4/P4NWm 2qWmaM710BY8yMvVsHbuKh40/BPRPrsF08wvtLDYytcVx1GImhbWWFu0pzN2J5mY/VbW vV2Q+RTfeJE/oc0V8/NT3ng9v/NoeFrolAFJMy4mM5mD12Qq+isGBvXGKz4VcDVpnrZC UvTg== X-Gm-Message-State: AGi0Pua/u31CwurFziNRO1j+HK8uYDGRT8ahFnw9ten1IRxN+Z7TQQrj IfXapA9135AVBg2iKPS/supZhA== X-Google-Smtp-Source: APiQypK+qFJjBWZIM4JseuejIHzEpgez/1Eb2rNDWCq0/ARVphGcY6JqUI7zr0Fw6Lx1kMeyag+eTA== X-Received: by 2002:a62:25c6:: with SMTP id l189mr6346111pfl.28.1587681810670; Thu, 23 Apr 2020 15:43:30 -0700 (PDT) Received: from localhost (76-210-143-223.lightspeed.sntcca.sbcglobal.net. [76.210.143.223]) by smtp.gmail.com with ESMTPSA id o9sm3280699pje.47.2020.04.23.15.43.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2020 15:43:29 -0700 (PDT) Date: Thu, 23 Apr 2020 15:43:29 -0700 (PDT) X-Google-Original-Date: Thu, 23 Apr 2020 15:43:27 PDT (-0700) Subject: Re: [PATCH v5 0/7] Add UEFI support for RISC-V In-Reply-To: <20200422172414.6662-1-ardb@kernel.org> From: Palmer Dabbelt To: ardb@kernel.org Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200423_154333_208341_8E55847B X-CRM114-Status: GOOD ( 14.56 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-efi@vger.kernel.org, Atish Patra , aou@eecs.berkeley.edu, Paul Walmsley , linux-riscv@lists.infradead.org, ardb@kernel.org Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org On Wed, 22 Apr 2020 10:24:07 PDT (-0700), ardb@kernel.org wrote: > This is a rework of Atish's series [0] to add EFI stub loader support > to the RISC-V port. The purpose is to split the code in a way that makes > it amenable to being merged via different trees during the same cycle. > While at it, I added a patch to disable initrd= loading for new ports, > given that it is deprecated and replaced with a method based on a > special UEFI device path. > > My changes are logged in the individual patches. > > I propose to take the first four patches via the EFI tree, and expose > them via a stable tag so that the RISC-V maintainers can merge it before > applying the remaining patches. That will ensure that both trees remain > in a buildable state, with working EFI stub support on the riscv branch. Works for me. Thanks! > > Cc: Atish Patra > Cc: Palmer Dabbelt > Cc: Paul Walmsley > Cc: Albert Ou > Cc: linux-riscv@lists.infradead.org > > Ard Biesheuvel (1): > efi/libstub: Make initrd file loader configurable > > Atish Patra (6): > efi/libstub: Move arm-stub to a common file > efi/libstub/riscv: add arch specific efi.h header file > include: pe.h: Add RISC-V related PE definition > RISC-V: Define fixmap bindings for generic early ioremap support > RISC-V: Add PE/COFF header for EFI stub > RISC-V: Add EFI stub support. > > arch/arm/Kconfig | 2 +- > arch/arm64/Kconfig | 2 +- > arch/riscv/Kconfig | 21 ++++ > arch/riscv/Makefile | 1 + > arch/riscv/configs/defconfig | 1 + > arch/riscv/include/asm/Kbuild | 1 + > arch/riscv/include/asm/efi.h | 41 +++++++ > arch/riscv/include/asm/fixmap.h | 18 +++ > arch/riscv/include/asm/io.h | 1 + > arch/riscv/include/asm/sections.h | 13 +++ > arch/riscv/kernel/Makefile | 4 + > arch/riscv/kernel/efi-header.S | 100 ++++++++++++++++ > arch/riscv/kernel/head.S | 16 +++ > arch/riscv/kernel/image-vars.h | 53 +++++++++ > arch/riscv/kernel/vmlinux.lds.S | 22 +++- > drivers/firmware/efi/Kconfig | 15 ++- > drivers/firmware/efi/libstub/Makefile | 22 +++- > .../efi/libstub/{arm-stub.c => efi-stub.c} | 0 > drivers/firmware/efi/libstub/file.c | 3 + > drivers/firmware/efi/libstub/riscv-stub.c | 109 ++++++++++++++++++ > include/linux/pe.h | 3 + > 21 files changed, 436 insertions(+), 12 deletions(-) > create mode 100644 arch/riscv/include/asm/efi.h > create mode 100644 arch/riscv/include/asm/sections.h > create mode 100644 arch/riscv/kernel/efi-header.S > create mode 100644 arch/riscv/kernel/image-vars.h > rename drivers/firmware/efi/libstub/{arm-stub.c => efi-stub.c} (100%) > create mode 100644 drivers/firmware/efi/libstub/riscv-stub.c