From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B3BEC0650E for ; Thu, 4 Jul 2019 07:20:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 37DF82189E for ; Thu, 4 Jul 2019 07:20:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727333AbfGDHU2 (ORCPT ); Thu, 4 Jul 2019 03:20:28 -0400 Received: from mx2.suse.de ([195.135.220.15]:57058 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725920AbfGDHU2 (ORCPT ); Thu, 4 Jul 2019 03:20:28 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 4B9FBB116; Thu, 4 Jul 2019 07:20:27 +0000 (UTC) From: Andreas Schwab To: Alistair Francis Cc: Alistair Francis , linux-riscv@lists.infradead.org, Arnd Bergmann , linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND 0/2] RISC-V: Handle the siginfo_t offset problem References: <20190703005202.7578-1-alistair.francis@wdc.com> X-Yow: First, I'm going to give you all the ANSWERS to today's test.. So just plug in your SONY WALKMANS and relax!! Date: Thu, 04 Jul 2019 09:20:26 +0200 In-Reply-To: (Alistair Francis's message of "Wed, 3 Jul 2019 11:40:39 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Jul 03 2019, Alistair Francis wrote: > On Wed, Jul 3, 2019 at 12:08 AM Andreas Schwab wrote: >> >> On Jul 02 2019, Alistair Francis wrote: >> >> > In the RISC-V 32-bit glibc port [1] the siginfo_t struct in the kernel >> > doesn't line up with the struct in glibc. In glibc world the _sifields >> > union is 8 byte alligned (although I can't figure out why) >> >> Try ptype/o in gdb. > > That's a useful tip, I'll be sure to use that next time. It was a serious note. If the structs don't line up then there is a mismatch in types that cannot be solved by adding spurious padding. You need to fix the types instead. Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F567C0650E for ; Thu, 4 Jul 2019 07:20:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 74B192189E for ; Thu, 4 Jul 2019 07:20:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="E+vDQFa2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 74B192189E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-Reply-To: Date:References:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IXrb25Sls4bANDvFog7RCqASCNH28Qxz5g/P6uA3w1I=; b=E+vDQFa2LomzSo wLk5Om0nnJQf0fu8Oo3/gXcMYCpJ/Kda7Tk2HqoeeNLNj/bDbkzeharCV2cXS+pivNyEU7OLhjXOr i5nXya+VJdVa6oTb19/xSIO1TQZ1QP2qJFu0eSFLcKDB8eiA5+o3vT+0EgrUitFv3QUCZoz6vhj7A sCy6dlBtiykMpr9/LFt+WC4Mh6htiTeuQaFkWQ4KdvrCQJDir2FkkFtiLNEHp8cm6LQ/xJScMcWHG z9ZNpxTajGUjv/mBnzzZfzMoo5Do0NWJnfMPW276x2DMWlYeMxWOswS//qBkSX95nCQFx+ftsDuPz GRSz4FXgEigoOmg6MC2Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hiw2j-0004SV-GT; Thu, 04 Jul 2019 07:20:33 +0000 Received: from mx2.suse.de ([195.135.220.15] helo=mx1.suse.de) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hiw2h-0004RX-22 for linux-riscv@lists.infradead.org; Thu, 04 Jul 2019 07:20:32 +0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 4B9FBB116; Thu, 4 Jul 2019 07:20:27 +0000 (UTC) From: Andreas Schwab To: Alistair Francis Subject: Re: [PATCH RESEND 0/2] RISC-V: Handle the siginfo_t offset problem References: <20190703005202.7578-1-alistair.francis@wdc.com> X-Yow: First, I'm going to give you all the ANSWERS to today's test.. So just plug in your SONY WALKMANS and relax!! Date: Thu, 04 Jul 2019 09:20:26 +0200 In-Reply-To: (Alistair Francis's message of "Wed, 3 Jul 2019 11:40:39 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2.90 (gnu/linux) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190704_002031_251309_7CF54F8A X-CRM114-Status: GOOD ( 10.72 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-riscv@lists.infradead.org, Alistair Francis , linux-kernel@vger.kernel.org, Arnd Bergmann Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org On Jul 03 2019, Alistair Francis wrote: > On Wed, Jul 3, 2019 at 12:08 AM Andreas Schwab wrote: >> >> On Jul 02 2019, Alistair Francis wrote: >> >> > In the RISC-V 32-bit glibc port [1] the siginfo_t struct in the kernel >> > doesn't line up with the struct in glibc. In glibc world the _sifields >> > union is 8 byte alligned (although I can't figure out why) >> >> Try ptype/o in gdb. > > That's a useful tip, I'll be sure to use that next time. It was a serious note. If the structs don't line up then there is a mismatch in types that cannot be solved by adding spurious padding. You need to fix the types instead. Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv