From: Koen Kooi <koen@dominion.thruhere.net>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [meta-oe][PATCH] opencv: Make gphoto2 dep optional via PACKAGECONFIG
Date: Thu, 2 Jun 2016 11:46:44 +0200 [thread overview]
Message-ID: <niova4$jt0$1@ger.gmane.org> (raw)
In-Reply-To: <1464784422-7127-1-git-send-email-ricardo.ribalda@gmail.com>
Op 01-06-16 om 14:33 schreef Ricardo Ribalda Delgado:
> Opencv can build without support for gphoto2 if needed.
You're changing the default without mentioning it, so please add 'gphoto2'
into the default PACKAGECONFIG in v2 of this patch.
>
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> ---
> meta-oe/recipes-support/opencv/opencv_3.1.bb | 3 ++- 1 file changed, 2
> insertions(+), 1 deletion(-)
>
> diff --git a/meta-oe/recipes-support/opencv/opencv_3.1.bb
> b/meta-oe/recipes-support/opencv/opencv_3.1.bb index
> 789512f9e0ac..512f1b3dea9b 100644 ---
> a/meta-oe/recipes-support/opencv/opencv_3.1.bb +++
> b/meta-oe/recipes-support/opencv/opencv_3.1.bb @@ -10,7 +10,7 @@
> ARM_INSTRUCTION_SET_armv5 = "arm"
>
> DEFAULT_PREFERENCE = "-1"
>
> -DEPENDS = "python-numpy libtool swig swig-native python bzip2 zlib
> glib-2.0 libwebp libgphoto2 protobuf protobuf-native" +DEPENDS =
> "python-numpy libtool swig swig-native python bzip2 zlib glib-2.0 libwebp
> protobuf protobuf-native"
>
> SRCREV_opencv = "92387b1ef8fad15196dd5f7fb4931444a68bc93a" SRCREV_contrib
> = "5409d5ad560523c85c6796cc5a009347072d883c" @@ -54,6 +54,7 @@
> PACKAGECONFIG ??= "eigen jpeg png tiff v4l libv4l gstreamer samples tbb
> \ PACKAGECONFIG[amdblas] =
> "-DWITH_OPENCLAMDBLAS=ON,-DWITH_OPENCLAMDBLAS=OFF,libclamdblas,"
> PACKAGECONFIG[amdfft] =
> "-DWITH_OPENCLAMDFFT=ON,-DWITH_OPENCLAMDFFT=OFF,libclamdfft,"
> PACKAGECONFIG[eigen] = "-DWITH_EIGEN=ON,-DWITH_EIGEN=OFF,libeigen,"
> +PACKAGECONFIG[gphoto2] =
> "-DWITH_GPHOTO2=ON,-DWITH_GPHOTO2=OFF,libgphoto2,"
> PACKAGECONFIG[gstreamer] =
> "-DWITH_GSTREAMER=ON,-DWITH_GSTREAMER=OFF,gstreamer1.0
> gstreamer1.0-plugins-base," PACKAGECONFIG[gtk] =
> "-DWITH_GTK=ON,-DWITH_GTK=OFF,gtk+3," PACKAGECONFIG[jasper] =
> "-DWITH_JASPER=ON,-DWITH_JASPER=OFF,jasper,"
>
prev parent reply other threads:[~2016-06-02 9:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-01 12:33 [meta-oe][PATCH] opencv: Make gphoto2 dep optional via PACKAGECONFIG Ricardo Ribalda Delgado
2016-06-01 13:43 ` Otavio Salvador
2016-06-02 9:46 ` Koen Kooi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='niova4$jt0$1@ger.gmane.org' \
--to=koen@dominion.thruhere.net \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.