From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: "Junio C Hamano" <gitster@pobox.com>,
git@vger.kernel.org, "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
"Anthony Ramine" <n.oxyde@gmail.com>,
"Johannes Sixt" <j6t@kdbg.org>,
"Adam Dinwoodie" <adam@dinwoodie.org>
Subject: Re: [PATCH v4 8/7] wildmatch test: skip file creation tests on Windows proper
Date: Mon, 8 Jan 2018 13:46:24 +0100 (STD) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.1801081331540.31@ZVAVAG-6OXH6DA.rhebcr.pbec.zvpebfbsg.pbz> (raw)
In-Reply-To: <87mv1raz9p.fsf@evledraar.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 16867 bytes --]
Hi Ævar,
On Sat, 6 Jan 2018, Ævar Arnfjörð Bjarmason wrote:
> Can you please provide me with the output of the test under -v -x -d
> from github.com:avar/git.git wildmatch-refactor-8 branch?
With -v -x -i:
-- snip --
[...]
expecting success:
printf '%s' '?a?b' >expect &&
git --glob-pathspecs ls-files -z -- '\??\?b' >actual.raw 2>actual.err &&
tr -d '\0' <actual.raw >actual &&
>expect.err &&
test_cmp expect.err actual.err &&
test_cmp expect actual
++ printf %s '?a?b'
++ git --glob-pathspecs ls-files -z -- '\??\?b'
+ test_eval_ret_=128
+ want_trace
+ test t = t
+ test t = t
+ set +x
error: last command exited with $?=128
not ok 734 - wildmatch(ls): match '\??\?b' '?a?b'
#
# printf '%s' '?a?b' >expect &&
# git --glob-pathspecs ls-files -z
# -- '\??\?b' >actual.raw
# 2>actual.err &&
#
# tr -d '\0' <actual.raw >actual &&
# >expect.err &&
# test_cmp expect.err actual.err &&
# test_cmp expect actual
#
real 2m9.127s
user 0m10.026s
sys 1m0.617s
-- snap --
and
-- snip --
$ cat ./trash\ directory.t3070-wildmatch/actual.err
fatal: Invalid path '/??': No such file or directory
-- snap --
As to the speed:
-- snip --
# still have 144 known breakage(s)
# failed 28 among remaining 1746 test(s)
1..1890
real 5m55.162s
user 0m26.396s
sys 2m34.152s
-- snap --
... seems to be in the same ballpark. You are just leaning way too heavily
on Unix shell scripting.
FWIW the breakages are:
-- snip --
not ok 734 - wildmatch(ls): match '\??\?b' '?a?b'
#
# printf '%s' '?a?b' >expect &&
# git --glob-pathspecs ls-files -z
# -- '\??\?b' >actual.raw
# 2>actual.err &&
#
# tr -d '\0' <actual.raw >actual &&
# >expect.err &&
# test_cmp expect.err actual.err &&
# test_cmp expect actual
#
ok 735 - iwildmatch: match '?a?b' '\??\?b'
not ok 736 - iwildmatch(ls): match '\??\?b' '?a?b'
#
# printf '%s' '?a?b' >expect &&
# git --glob-pathspecs
# --icase-pathspecs ls-files -z --
# '\??\?b' >actual.raw 2>actual.err
# &&
#
# tr -d '\0' <actual.raw >actual &&
# >expect.err &&
# test_cmp expect.err actual.err &&
# test_cmp expect actual
#
ok 737 - pathmatch: match '?a?b' '\??\?b'
not ok 738 - pathmatch(ls): match '\??\?b' '?a?b'
#
# printf '%s' '?a?b' >expect &&
# git ls-files -z -- '\??\?b'
# >actual.raw 2>actual.err &&
#
# tr -d '\0' <actual.raw >actual &&
# >expect.err &&
# test_cmp expect.err actual.err &&
# test_cmp expect actual
#
ok 739 - ipathmatch: match '?a?b' '\??\?b'
not ok 740 - ipathmatch(ls): match '\??\?b' '?a?b'
#
# printf '%s' '?a?b' >expect &&
# git --icase-pathspecs ls-files -z
# -- '\??\?b' >actual.raw
# 2>actual.err &&
#
# tr -d '\0' <actual.raw >actual &&
# >expect.err &&
# test_cmp expect.err actual.err &&
# test_cmp expect actual
#
ok 741 - cleanup after previous file test
ok 742 - setup wildtest file test for abc
ok 743 - wildmatch: match 'abc' '\a\b\c'
not ok 744 - wildmatch(ls): match '\a\b\c' 'abc'
#
# printf '%s' 'abc' >expect &&
# git --glob-pathspecs ls-files -z
# -- '\a\b\c' >actual.raw
# 2>actual.err &&
#
# tr -d '\0' <actual.raw >actual &&
# >expect.err &&
# test_cmp expect.err actual.err &&
# test_cmp expect actual
#
ok 745 - iwildmatch: match 'abc' '\a\b\c'
not ok 746 - iwildmatch(ls): match '\a\b\c' 'abc'
#
# printf '%s' 'abc' >expect &&
# git --glob-pathspecs
# --icase-pathspecs ls-files -z --
# '\a\b\c' >actual.raw 2>actual.err
# &&
#
# tr -d '\0' <actual.raw >actual &&
# >expect.err &&
# test_cmp expect.err actual.err &&
# test_cmp expect actual
#
ok 747 - pathmatch: match 'abc' '\a\b\c'
not ok 748 - pathmatch(ls): match '\a\b\c' 'abc'
#
# printf '%s' 'abc' >expect &&
# git ls-files -z -- '\a\b\c'
# >actual.raw 2>actual.err &&
#
# tr -d '\0' <actual.raw >actual &&
# >expect.err &&
# test_cmp expect.err actual.err &&
# test_cmp expect actual
#
ok 749 - ipathmatch: match 'abc' '\a\b\c'
not ok 750 - ipathmatch(ls): match '\a\b\c' 'abc'
#
# printf '%s' 'abc' >expect &&
# git --icase-pathspecs ls-files -z
# -- '\a\b\c' >actual.raw
# 2>actual.err &&
#
# tr -d '\0' <actual.raw >actual &&
# >expect.err &&
# test_cmp expect.err actual.err &&
# test_cmp expect actual
#
[...]
not ok 964 - wildmatch(ls): match '[\-_]' '-'
#
# printf '%s' '-' >expect &&
# git --glob-pathspecs ls-files -z
# -- '[\-_]' >actual.raw
# 2>actual.err &&
#
# tr -d '\0' <actual.raw >actual &&
# >expect.err &&
# test_cmp expect.err actual.err &&
# test_cmp expect actual
#
ok 965 - iwildmatch: match '-' '[\-_]'
not ok 966 - iwildmatch(ls): match '[\-_]' '-'
#
# printf '%s' '-' >expect &&
# git --glob-pathspecs
# --icase-pathspecs ls-files -z --
# '[\-_]' >actual.raw 2>actual.err
# &&
#
# tr -d '\0' <actual.raw >actual &&
# >expect.err &&
# test_cmp expect.err actual.err &&
# test_cmp expect actual
#
ok 967 - pathmatch: match '-' '[\-_]'
not ok 968 - pathmatch(ls): match '[\-_]' '-'
#
# printf '%s' '-' >expect &&
# git ls-files -z -- '[\-_]'
# >actual.raw 2>actual.err &&
#
# tr -d '\0' <actual.raw >actual &&
# >expect.err &&
# test_cmp expect.err actual.err &&
# test_cmp expect actual
#
ok 969 - ipathmatch: match '-' '[\-_]'
not ok 970 - ipathmatch(ls): match '[\-_]' '-'
#
# printf '%s' '-' >expect &&
# git --icase-pathspecs ls-files -z
# -- '[\-_]' >actual.raw
# 2>actual.err &&
#
# tr -d '\0' <actual.raw >actual &&
# >expect.err &&
# test_cmp expect.err actual.err &&
# test_cmp expect actual
#
ok 971 - cleanup after previous file test
ok 972 - setup wildtest file test for ]
ok 973 - wildmatch: match ']' '[\]]'
not ok 974 - wildmatch(ls): match '[\]]' ']'
#
# printf '%s' ']' >expect &&
# git --glob-pathspecs ls-files -z
# -- '[\]]' >actual.raw 2>actual.err
# &&
#
# tr -d '\0' <actual.raw >actual &&
# >expect.err &&
# test_cmp expect.err actual.err &&
# test_cmp expect actual
#
ok 975 - iwildmatch: match ']' '[\]]'
not ok 976 - iwildmatch(ls): match '[\]]' ']'
#
# printf '%s' ']' >expect &&
# git --glob-pathspecs
# --icase-pathspecs ls-files -z --
# '[\]]' >actual.raw 2>actual.err &&
#
# tr -d '\0' <actual.raw >actual &&
# >expect.err &&
# test_cmp expect.err actual.err &&
# test_cmp expect actual
#
ok 977 - pathmatch: match ']' '[\]]'
not ok 978 - pathmatch(ls): match '[\]]' ']'
#
# printf '%s' ']' >expect &&
# git ls-files -z -- '[\]]'
# >actual.raw 2>actual.err &&
#
# tr -d '\0' <actual.raw >actual &&
# >expect.err &&
# test_cmp expect.err actual.err &&
# test_cmp expect actual
#
ok 979 - ipathmatch: match ']' '[\]]'
not ok 980 - ipathmatch(ls): match '[\]]' ']'
#
# printf '%s' ']' >expect &&
# git --icase-pathspecs ls-files -z
# -- '[\]]' >actual.raw 2>actual.err
# &&
#
# tr -d '\0' <actual.raw >actual &&
# >expect.err &&
# test_cmp expect.err actual.err &&
# test_cmp expect actual
#
[...]
not ok 1284 - wildmatch(ls): match '[A-\\]' 'G'
#
# printf '%s' 'G' >expect &&
# git --glob-pathspecs ls-files -z
# -- '[A-\\]' >actual.raw
# 2>actual.err &&
#
# tr -d '\0' <actual.raw >actual &&
# >expect.err &&
# test_cmp expect.err actual.err &&
# test_cmp expect actual
#
ok 1285 - iwildmatch: match 'G' '[A-\\]'
not ok 1286 - iwildmatch(ls): match '[A-\\]' 'G'
#
# printf '%s' 'G' >expect &&
# git --glob-pathspecs
# --icase-pathspecs ls-files -z --
# '[A-\\]' >actual.raw 2>actual.err
# &&
#
# tr -d '\0' <actual.raw >actual &&
# >expect.err &&
# test_cmp expect.err actual.err &&
# test_cmp expect actual
#
ok 1287 - pathmatch: match 'G' '[A-\\]'
not ok 1288 - pathmatch(ls): match '[A-\\]' 'G'
#
# printf '%s' 'G' >expect &&
# git ls-files -z -- '[A-\\]'
# >actual.raw 2>actual.err &&
#
# tr -d '\0' <actual.raw >actual &&
# >expect.err &&
# test_cmp expect.err actual.err &&
# test_cmp expect actual
#
ok 1289 - ipathmatch: match 'G' '[A-\\]'
not ok 1290 - ipathmatch(ls): match '[A-\\]' 'G'
#
# printf '%s' 'G' >expect &&
# git --icase-pathspecs ls-files -z
# -- '[A-\\]' >actual.raw
# 2>actual.err &&
#
# tr -d '\0' <actual.raw >actual &&
# >expect.err &&
# test_cmp expect.err actual.err &&
# test_cmp expect actual
#
[...]
not ok 1374 - wildmatch(ls): match '[\1-\3]' '2'
#
# printf '%s' '2' >expect &&
# git --glob-pathspecs ls-files -z
# -- '[\1-\3]' >actual.raw
# 2>actual.err &&
#
# tr -d '\0' <actual.raw >actual &&
# >expect.err &&
# test_cmp expect.err actual.err &&
# test_cmp expect actual
#
ok 1375 - iwildmatch: match '2' '[\1-\3]'
not ok 1376 - iwildmatch(ls): match '[\1-\3]' '2'
#
# printf '%s' '2' >expect &&
# git --glob-pathspecs
# --icase-pathspecs ls-files -z --
# '[\1-\3]' >actual.raw 2>actual.err
# &&
#
# tr -d '\0' <actual.raw >actual &&
# >expect.err &&
# test_cmp expect.err actual.err &&
# test_cmp expect actual
#
ok 1377 - pathmatch: match '2' '[\1-\3]'
not ok 1378 - pathmatch(ls): match '[\1-\3]' '2'
#
# printf '%s' '2' >expect &&
# git ls-files -z -- '[\1-\3]'
# >actual.raw 2>actual.err &&
#
# tr -d '\0' <actual.raw >actual &&
# >expect.err &&
# test_cmp expect.err actual.err &&
# test_cmp expect actual
#
ok 1379 - ipathmatch: match '2' '[\1-\3]'
not ok 1380 - ipathmatch(ls): match '[\1-\3]' '2'
#
# printf '%s' '2' >expect &&
# git --icase-pathspecs ls-files -z
# -- '[\1-\3]' >actual.raw
# 2>actual.err &&
#
# tr -d '\0' <actual.raw >actual &&
# >expect.err &&
# test_cmp expect.err actual.err &&
# test_cmp expect actual
#
[...]
not ok 1424 - wildmatch(ls): match '[[-\]]' ']'
#
# printf '%s' ']' >expect &&
# git --glob-pathspecs ls-files -z
# -- '[[-\]]' >actual.raw
# 2>actual.err &&
#
# tr -d '\0' <actual.raw >actual &&
# >expect.err &&
# test_cmp expect.err actual.err &&
# test_cmp expect actual
#
ok 1425 - iwildmatch: match ']' '[[-\]]'
not ok 1426 - iwildmatch(ls): match '[[-\]]' ']'
#
# printf '%s' ']' >expect &&
# git --glob-pathspecs
# --icase-pathspecs ls-files -z --
# '[[-\]]' >actual.raw 2>actual.err
# &&
#
# tr -d '\0' <actual.raw >actual &&
# >expect.err &&
# test_cmp expect.err actual.err &&
# test_cmp expect actual
#
ok 1427 - pathmatch: match ']' '[[-\]]'
not ok 1428 - pathmatch(ls): match '[[-\]]' ']'
#
# printf '%s' ']' >expect &&
# git ls-files -z -- '[[-\]]'
# >actual.raw 2>actual.err &&
#
# tr -d '\0' <actual.raw >actual &&
# >expect.err &&
# test_cmp expect.err actual.err &&
# test_cmp expect actual
#
ok 1429 - ipathmatch: match ']' '[[-\]]'
not ok 1430 - ipathmatch(ls): match '[[-\]]' ']'
#
# printf '%s' ']' >expect &&
# git --icase-pathspecs ls-files -z
# -- '[[-\]]' >actual.raw
# 2>actual.err &&
#
# tr -d '\0' <actual.raw >actual &&
# >expect.err &&
# test_cmp expect.err actual.err &&
# test_cmp expect actual
#
-- snap --
Ciao,
Dscho
next prev parent reply other threads:[~2018-01-08 12:46 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-23 21:30 [PATCH 0/6] increase wildmatch test coverage Ævar Arnfjörð Bjarmason
2017-12-23 21:30 ` [PATCH 1/6] wildmatch test: indent with tabs, not spaces Ævar Arnfjörð Bjarmason
2017-12-23 21:30 ` [PATCH 2/6] wildmatch test: use more standard shell style Ævar Arnfjörð Bjarmason
2017-12-23 21:30 ` [PATCH 3/6] wildmatch test: use a paranoia pattern from nul_match() Ævar Arnfjörð Bjarmason
2017-12-23 21:30 ` [PATCH 4/6] wildmatch test: remove dead fnmatch() test code Ævar Arnfjörð Bjarmason
2017-12-23 21:30 ` [PATCH 5/6] wildmatch test: perform all tests under all wildmatch() modes Ævar Arnfjörð Bjarmason
2017-12-23 21:30 ` [PATCH 6/6] wildmatch test: create & test files on disk in addition to in-memory Ævar Arnfjörð Bjarmason
2017-12-24 9:24 ` Johannes Sixt
2017-12-24 11:06 ` Ævar Arnfjörð Bjarmason
2017-12-24 11:51 ` Johannes Sixt
2017-12-25 0:28 ` [PATCH v2 0/7] increase wildmatch test coverage Ævar Arnfjörð Bjarmason
2017-12-28 22:48 ` Junio C Hamano
2017-12-28 23:49 ` Ævar Arnfjörð Bjarmason
2017-12-28 23:28 ` [PATCH v3 " Ævar Arnfjörð Bjarmason
2017-12-28 23:28 ` [PATCH v3 1/7] wildmatch test: indent with tabs, not spaces Ævar Arnfjörð Bjarmason
2017-12-28 23:28 ` [PATCH v3 2/7] wildmatch test: use more standard shell style Ævar Arnfjörð Bjarmason
2017-12-28 23:28 ` [PATCH v3 3/7] wildmatch test: don't try to vertically align our output Ævar Arnfjörð Bjarmason
2017-12-28 23:28 ` [PATCH v3 4/7] wildmatch test: use a paranoia pattern from nul_match() Ævar Arnfjörð Bjarmason
2017-12-28 23:28 ` [PATCH v3 5/7] wildmatch test: remove dead fnmatch() test code Ævar Arnfjörð Bjarmason
2017-12-28 23:28 ` [PATCH v3 6/7] wildmatch test: perform all tests under all wildmatch() modes Ævar Arnfjörð Bjarmason
2017-12-28 23:28 ` [PATCH v3 7/7] wildmatch test: create & test files on disk in addition to in-memory Ævar Arnfjörð Bjarmason
2017-12-29 0:16 ` Ævar Arnfjörð Bjarmason
2017-12-25 0:28 ` [PATCH v2 1/7] wildmatch test: indent with tabs, not spaces Ævar Arnfjörð Bjarmason
2017-12-25 0:28 ` [PATCH v2 2/7] wildmatch test: use more standard shell style Ævar Arnfjörð Bjarmason
2017-12-25 0:28 ` [PATCH v2 3/7] wildmatch test: don't try to vertically align our output Ævar Arnfjörð Bjarmason
2017-12-25 0:28 ` [PATCH v2 4/7] wildmatch test: use a paranoia pattern from nul_match() Ævar Arnfjörð Bjarmason
2017-12-25 0:28 ` [PATCH v2 5/7] wildmatch test: remove dead fnmatch() test code Ævar Arnfjörð Bjarmason
2017-12-25 0:28 ` [PATCH v2 6/7] wildmatch test: perform all tests under all wildmatch() modes Ævar Arnfjörð Bjarmason
2017-12-28 20:28 ` Junio C Hamano
2017-12-25 0:28 ` [PATCH v2 7/7] wildmatch test: create & test files on disk in addition to in-memory Ævar Arnfjörð Bjarmason
2017-12-25 9:26 ` Johannes Sixt
2017-12-27 19:07 ` Junio C Hamano
2018-01-03 13:02 ` Adam Dinwoodie
2018-01-03 13:31 ` Ævar Arnfjörð Bjarmason
2018-01-03 14:41 ` Adam Dinwoodie
2018-01-03 19:14 ` Ævar Arnfjörð Bjarmason
2018-01-04 11:50 ` Adam Dinwoodie
2018-01-04 19:26 ` [PATCH v4 0/7] increase wildmatch test coverage Ævar Arnfjörð Bjarmason
2018-01-30 21:21 ` [PATCH v5 00/10] " Ævar Arnfjörð Bjarmason
2018-01-30 21:21 ` [PATCH v5 01/10] wildmatch test: indent with tabs, not spaces Ævar Arnfjörð Bjarmason
2018-01-30 21:21 ` [PATCH v5 02/10] wildmatch test: use more standard shell style Ævar Arnfjörð Bjarmason
2018-01-30 21:21 ` [PATCH v5 03/10] wildmatch test: don't try to vertically align our output Ævar Arnfjörð Bjarmason
2018-01-30 21:21 ` [PATCH v5 04/10] wildmatch test: use a paranoia pattern from nul_match() Ævar Arnfjörð Bjarmason
2018-01-30 21:21 ` [PATCH v5 05/10] wildmatch test: remove dead fnmatch() test code Ævar Arnfjörð Bjarmason
2018-01-30 21:21 ` [PATCH v5 06/10] wildmatch test: use test_must_fail, not ! for test-wildmatch Ævar Arnfjörð Bjarmason
2018-01-30 21:21 ` [PATCH v5 07/10] wildmatch test: perform all tests under all wildmatch() modes Ævar Arnfjörð Bjarmason
2018-01-30 21:21 ` [PATCH v5 08/10] wildmatch test: create & test files on disk in addition to in-memory Ævar Arnfjörð Bjarmason
2018-01-30 21:21 ` [PATCH v5 09/10] test-lib: add an EXPENSIVE_ON_WINDOWS prerequisite Ævar Arnfjörð Bjarmason
2018-01-30 21:21 ` [PATCH v5 10/10] wildmatch test: mark test as EXPENSIVE_ON_WINDOWS Ævar Arnfjörð Bjarmason
2018-01-04 19:26 ` [PATCH v4 1/7] wildmatch test: indent with tabs, not spaces Ævar Arnfjörð Bjarmason
2018-01-04 19:26 ` [PATCH v4 2/7] wildmatch test: use more standard shell style Ævar Arnfjörð Bjarmason
2018-01-04 19:26 ` [PATCH v4 3/7] wildmatch test: don't try to vertically align our output Ævar Arnfjörð Bjarmason
2018-01-04 19:26 ` [PATCH v4 4/7] wildmatch test: use a paranoia pattern from nul_match() Ævar Arnfjörð Bjarmason
2018-01-04 19:26 ` [PATCH v4 5/7] wildmatch test: remove dead fnmatch() test code Ævar Arnfjörð Bjarmason
2018-01-04 19:26 ` [PATCH v4 6/7] wildmatch test: perform all tests under all wildmatch() modes Ævar Arnfjörð Bjarmason
2018-01-04 19:26 ` [PATCH v4 7/7] wildmatch test: create & test files on disk in addition to in-memory Ævar Arnfjörð Bjarmason
2018-01-05 16:41 ` Johannes Schindelin
2018-01-05 19:08 ` Ævar Arnfjörð Bjarmason
2018-01-05 20:48 ` Johannes Schindelin
2018-01-05 22:12 ` [PATCH v4 8/7] wildmatch test: skip file creation tests on Windows proper Ævar Arnfjörð Bjarmason
2018-01-05 23:13 ` Junio C Hamano
2018-01-06 12:51 ` Johannes Schindelin
2018-01-06 13:32 ` Ævar Arnfjörð Bjarmason
2018-01-06 20:46 ` Johannes Schindelin
2018-01-08 12:46 ` Johannes Schindelin [this message]
2018-01-08 18:49 ` Junio C Hamano
2018-01-07 2:51 ` Duy Nguyen
2018-01-08 12:25 ` Johannes Schindelin
2018-01-10 9:07 ` Duy Nguyen
2018-01-10 10:38 ` Adam Dinwoodie
2018-01-10 10:52 ` Duy Nguyen
2018-01-10 20:24 ` Johannes Schindelin
2018-01-11 9:25 ` Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.1801081331540.31@ZVAVAG-6OXH6DA.rhebcr.pbec.zvpebfbsg.pbz \
--to=johannes.schindelin@gmx.de \
--cc=adam@dinwoodie.org \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=n.oxyde@gmail.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.