From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Cc: Junio C Hamano <gitster@pobox.com>,
Philippe Blain <levraiphilippeblain@gmail.com>,
jrnieder@gmail.com, git@vger.kernel.org
Subject: Re: Patchwork instance "Submitter" attribution and GitGitGadget
Date: Fri, 8 Jan 2021 16:07:03 +0100 (CET) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.2101081604470.2213@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <20210107223755.6fg77xjdbqiscwb2@chatter.i7.local>
Hi Konst,
On Thu, 7 Jan 2021, Konstantin Ryabitsev wrote:
> On Thu, Jan 07, 2021 at 03:35:54PM +0100, Johannes Schindelin wrote:
> > > Would it help to use the "Sender:" header? IIUC right now GGG
> > > records its name on "From:" with its e-mail and a human-readable
> > > name derived from the author of the ptach, but if it can record the
> > > true author on "From:" and leave GGG's name on the "Sender:", would
> > > patchwork use the "From:" side of the identity instead?
> >
> > To tie up that loose end: GMail seemed to insist in my tests on replacing
> > the `From:` header, therefore we cannot implement this `Sender:` idea, not
> > using GMail to deliver the GitGitGadget patch series at least.
>
> Can you possibly set X-Original-From: in the header?
Potentially. But unfortunately, I am too short on time to perform such
experiments right now. And it is always subject to the question what GMail
does with this header in the future. `Sender:` used to work IIRC, but now
it doesn't.
> Patchwork almost does the right thing with it, though right now it
> expects that the From: will be set to the list's email address (which is
> only correct for google groups).
>
> We have a workaround for the current situation on patchwork.kernel.org [1],
> but it requires parsing the body of the message instead of just relying on the
> headers.
>
> > > If that works, it would have an additional benefit of not having to
> > > add the in-body "From:" to override the mail-header "From:", to avoid
> > > attributing the authorship to GGG.
>
> Using the in-body From: is both good and proper for such service. Trying to
> put the author's email into the actual From will run afoul of SPF.
Indeed.
Therefore, I would prefer to keep doing that in GitGitGadget: send from
its regular email address, and add the contributor's info in-body.
Ciao,
Johannes
>
> -K
>
> [1] https://git.kernel.org/pub/scm/infra/patchwork/procmail.git/tree/git.rc
>
prev parent reply other threads:[~2021-01-08 15:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-18 18:51 Patchwork instance "Submitter" attribution and GitGitGadget Philippe Blain
2020-01-20 12:16 ` Johannes Schindelin
2020-01-21 17:53 ` Junio C Hamano
2021-01-07 14:35 ` Johannes Schindelin
2021-01-07 22:37 ` Konstantin Ryabitsev
2021-01-08 15:07 ` Johannes Schindelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.2101081604470.2213@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=konstantin@linuxfoundation.org \
--cc=levraiphilippeblain@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.