Re: [PATCH 0/2] Use the built-in implementation of the interactive add command by default

[Johannes Schindelin <Johannes.Schindelin@gmx.de>]

[-- Attachment #1: Type: text/plain, Size: 1334 bytes --]

Hi Philippe,

On Fri, 3 Dec 2021, Philippe Blain wrote:

> Le 2021-11-30 à 09:14, Johannes Schindelin via GitGitGadget a écrit :
> > Over two years ago, Slavica Đukić participated in the Outreachy project,
> > starting to implement a built-in version of the interactive git add command.
> > A little over a year ago, Git turned on that mode whenever users were
> > running with feature.experimental = true.
> >
> > It is time to declare this implementation robust, to use it by default, and
> > to start deprecating the scripted implementation.
> >
> > Johannes Schindelin (2):
> >    t2016: require the PERL prereq only when necessary
> >    add -i: default to the built-in implementation
> >
> >   Documentation/config/add.txt |  6 +++---
> >   builtin/add.c                | 15 +++++--------
> >   ci/run-build-and-tests.sh    |  2 +-
> >   t/README                     |  2 +-
> >   t/t2016-checkout-patch.sh    | 42 +++++++++++++++++++-----------------
> >   5 files changed, 32 insertions(+), 35 deletions(-)
>
> I just noticed that 'INSTALL' mentions that Perl is needed for 'git add
> interactive'
> et al, so maybe we would want to tweak the wording a bit in there when switch
> the default
> to the C version ?

Not yet. Only once we remove `git-add--interactive.perl`.

Thanks,
Dscho