Re: [PATCH v2] livepatch: unpatch all klp_objects if klp_module_coming fails

From: Jiri Kosina <jikos@kernel.org>
To: Joe Lawrence <joe.lawrence@redhat.com>
Cc: live-patching@vger.kernel.org, linux-kernel@vger.kernel.org,
	Josh Poimboeuf <jpoimboe@redhat.com>,
	Jessica Yu <jeyu@kernel.org>, Miroslav Benes <mbenes@suse.cz>,
	Petr Mladek <pmladek@suse.com>
Subject: Re: [PATCH v2] livepatch: unpatch all klp_objects if klp_module_coming fails
Date: Wed, 11 Oct 2017 15:39:18 +0200 (CEST)	[thread overview]
Message-ID: <nycvar.YFH.7.76.1710111539070.14384@jbgna.fhfr.qr> (raw)
In-Reply-To: <1506959808-23838-1-git-send-email-joe.lawrence@redhat.com>

On Mon, 2 Oct 2017, Joe Lawrence wrote:

> When an incoming module is considered for livepatching by
> klp_module_coming(), it iterates over multiple patches and multiple
> kernel objects in this order:
> 
> 	list_for_each_entry(patch, &klp_patches, list) {
> 		klp_for_each_object(patch, obj) {
> 
> which means that if one of the kernel objects fails to patch,
> klp_module_coming()'s error path needs to unpatch and cleanup any kernel
> objects that were already patched by a previous patch.
> 
> Reported-by: Miroslav Benes <mbenes@suse.cz>
> Suggested-by: Petr Mladek <pmladek@suse.com>
> Signed-off-by: Joe Lawrence <joe.lawrence@redhat.com>
> ---
> v2:
> 
>  - cleanup comment describing the new function
>  - s/klp_cleanup_module_objects_limited/klp_cleanup_module_patches_limited
>  - added a suggested-by tag for Petr since he suggested both code and
>    commentary :)

Appplied to for-4.14/upstream-fixes. Thanks,

-- 
Jiri Kosina
SUSE Labs