* [PATCH] floppy: Add floppy prefix to pr_info
@ 2017-07-28 7:25 Corentin Labbe
2017-10-12 13:34 ` Jiri Kosina
0 siblings, 1 reply; 2+ messages in thread
From: Corentin Labbe @ 2017-07-28 7:25 UTC (permalink / raw)
To: jikos; +Cc: linux-kernel, Corentin Labbe
When booting a qemu virtual machine I got in dmesg the following message
alone: "work still pending".
Without prefix, it is hard to know which subsystem got work pending.
This patch add a "floppy:" prefix to this message.
Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
---
drivers/block/floppy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c
index 9c00f29e40c1..61eb80c8894b 100644
--- a/drivers/block/floppy.c
+++ b/drivers/block/floppy.c
@@ -4872,7 +4872,7 @@ static void floppy_release_irq_and_dma(void)
if (delayed_work_pending(&fd_timer))
pr_info("auxiliary floppy timer still active\n");
if (work_pending(&floppy_work))
- pr_info("work still pending\n");
+ pr_info("floppy: work still pending\n");
old_fdc = fdc;
for (fdc = 0; fdc < N_FDC; fdc++)
if (FDCS->address != -1)
--
2.13.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] floppy: Add floppy prefix to pr_info
2017-07-28 7:25 [PATCH] floppy: Add floppy prefix to pr_info Corentin Labbe
@ 2017-10-12 13:34 ` Jiri Kosina
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Kosina @ 2017-10-12 13:34 UTC (permalink / raw)
To: Corentin Labbe; +Cc: linux-kernel
On Fri, 28 Jul 2017, Corentin Labbe wrote:
> When booting a qemu virtual machine I got in dmesg the following message
> alone: "work still pending".
> Without prefix, it is hard to know which subsystem got work pending.
>
> This patch add a "floppy:" prefix to this message.
>
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> ---
> drivers/block/floppy.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c
> index 9c00f29e40c1..61eb80c8894b 100644
> --- a/drivers/block/floppy.c
> +++ b/drivers/block/floppy.c
> @@ -4872,7 +4872,7 @@ static void floppy_release_irq_and_dma(void)
> if (delayed_work_pending(&fd_timer))
> pr_info("auxiliary floppy timer still active\n");
> if (work_pending(&floppy_work))
> - pr_info("work still pending\n");
> + pr_info("floppy: work still pending\n");
I think it'd actually be much better to fix this globally for all such
instances in that file, and define pr_fmt proper.
Could you please do that instead?
Thanks,
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-12 13:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-28 7:25 [PATCH] floppy: Add floppy prefix to pr_info Corentin Labbe
2017-10-12 13:34 ` Jiri Kosina
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.