From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752088AbeAWOkZ (ORCPT ); Tue, 23 Jan 2018 09:40:25 -0500 Received: from mx2.suse.de ([195.135.220.15]:50707 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751565AbeAWOkY (ORCPT ); Tue, 23 Jan 2018 09:40:24 -0500 Date: Tue, 23 Jan 2018 15:40:21 +0100 (CET) From: Jiri Kosina To: Tomasz Kramkowski cc: Benjamin Tissoires , Yuxuan Shui , =?ISO-8859-15?Q?Diego_Elio_Petten=F2?= , Alex Manoussakis , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] HID: elecom: rewrite report fixup for EX-G and future mice In-Reply-To: <20171219204436.27737-1-tk@the-tk.com> Message-ID: References: <20171204205550.2621-1-tk@the-tk.com> <20171219204436.27737-1-tk@the-tk.com> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 19 Dec 2017, Tomasz Kramkowski wrote: > This patch rewrites the mouse report fixup used for the DEFT and HUGE > elecom trackballs in order to make it generic enough to fix other > elecom mice with similar issues. This patch also uses this new report > fixup function to fix the Elecom EX-G trackball which has 6 physical > buttons and a similar issue to the other two mice. > > Elecom's track record has so far shown that they like to re-use the > same report descriptor for multiple different mice regardless of the > number of buttons the mouse has. This means that the missing buttons > on multiple mice can be fixed in one function without introducing > phantom buttons which would in turn cause the number of mouse buttons > to be misreported to userspace. > > This patch drops the very verbose report descriptor "diff" comment for > a more abridged yet hopefully just as informative generic version. > > Signed-off-by: Tomasz Kramkowski > --- > v2 changes: > * pass rsize directly to mouse_button_fixup > * add support for wireless EX-G variant > v1: https://marc.info/?i=20171204205550.2621-1-tk@the-tk.com Applied, thanks. -- Jiri Kosina SUSE Labs