From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752557AbeC0MGF (ORCPT ); Tue, 27 Mar 2018 08:06:05 -0400 Received: from mx2.suse.de ([195.135.220.15]:39949 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752511AbeC0MGC (ORCPT ); Tue, 27 Mar 2018 08:06:02 -0400 Date: Tue, 27 Mar 2018 14:05:59 +0200 (CEST) From: Jiri Kosina To: Christophe JAILLET cc: masaki.ota@jp.alps.com, benjamin.tissoires@redhat.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 0/4] HID: alps: Fix some bugs and improve code around 't4_read_write_register()' In-Reply-To: Message-ID: References: User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 19 Mar 2018, Christophe JAILLET wrote: > All is said in the subject and below. > > These patches are untested. Especially, patch 1 slightly changes the behavior > of 't4_read_write_register()'. > This looks logical to me, but please, review it carefully. > > Christophe JAILLET (4): > HID: alps: Report an error if we receive invalid data in > 't4_read_write_register()' > HID: alps: Save a memory allocation in 't4_read_write_register()' when > writing data > HID: alps: Check errors returned by 't4_read_write_register()' > HID: alps: Fix some style in 't4_read_write_register()' > > drivers/hid/hid-alps.c | 27 ++++++++++++++++++++++----- > 1 file changed, 22 insertions(+), 5 deletions(-) Masaki-san, do you have any comments to Christophe's patchset please? Thanks, -- Jiri Kosina SUSE Labs From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Kosina Date: Tue, 27 Mar 2018 12:05:59 +0000 Subject: Re: [PATCH 0/4] HID: alps: Fix some bugs and improve code around 't4_read_write_register()' Message-Id: List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Christophe JAILLET Cc: masaki.ota@jp.alps.com, benjamin.tissoires@redhat.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org On Mon, 19 Mar 2018, Christophe JAILLET wrote: > All is said in the subject and below. > > These patches are untested. Especially, patch 1 slightly changes the behavior > of 't4_read_write_register()'. > This looks logical to me, but please, review it carefully. > > Christophe JAILLET (4): > HID: alps: Report an error if we receive invalid data in > 't4_read_write_register()' > HID: alps: Save a memory allocation in 't4_read_write_register()' when > writing data > HID: alps: Check errors returned by 't4_read_write_register()' > HID: alps: Fix some style in 't4_read_write_register()' > > drivers/hid/hid-alps.c | 27 ++++++++++++++++++++++----- > 1 file changed, 22 insertions(+), 5 deletions(-) Masaki-san, do you have any comments to Christophe's patchset please? Thanks, -- Jiri Kosina SUSE Labs