All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Engelhardt <jengelh@inai.de>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH 1/7] build: change @foo@ to $(foo) in automake makefiles
Date: Sat, 24 Nov 2018 14:27:59 +0100 (CET)	[thread overview]
Message-ID: <nycvar.YFH.7.76.1811241421150.5864@n3.vanv.qr> (raw)
In-Reply-To: <CABBYNZL0jgnZTYSQ+c+54_fHudK+0fg-GwS_-LUzw7gde_aMyA@mail.gmail.com>

On Thursday 2018-11-22 10:47, Luiz Augusto von Dentz wrote:

>Hi Jan,
>> When using automake, all AC_SUBSTed variables are made available as
>> make variables, so that they can also be set at make time. Therefore,
>> they need not use the @harcoded@ style.
>>
>> -pkglibexecdir = @libexecdir@/bluetooth
>> +pkglibexecdir = $(libexecdir)/bluetooth
>> -includedir = @includedir@/bluetooth
>> +includedir = $(includedir)/bluetooth
>
>Makefile:2392: *** Recursive variable 'includedir' references itself
>(eventually).  Stop.

Thank you. Not sure why my system does not give the recursive warning here (it
*did* for libexecdir though, which is what brought commit 78bce48009 forth).
I'll do the distcheck too (apparently that --enables-android, which I missed).

  reply	other threads:[~2018-11-24 13:28 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-18 16:07 [PATCH bluez] build system refresh Jan Engelhardt
2018-11-18 16:07 ` [PATCH 1/8] build: rename libexecdir to pkglibexecdir Jan Engelhardt
2018-11-21 11:29   ` Luiz Augusto von Dentz
2018-11-21 12:57     ` Jan Engelhardt
2018-11-21 12:57       ` [PATCH 1/7] build: change @foo@ to $(foo) in automake makefiles Jan Engelhardt
2018-11-22  9:47         ` Luiz Augusto von Dentz
2018-11-24 13:27           ` Jan Engelhardt [this message]
2018-11-25  9:20           ` [PATCH bluez] build system refresh (take 3) Jan Engelhardt
2018-11-25  9:20             ` [PATCH 1/8] build: rename includedir to pkgincludedir Jan Engelhardt
2018-11-25  9:20             ` [PATCH 2/8] build: change @foo@ to $(foo) in automake makefiles Jan Engelhardt
2018-11-25  9:20             ` [PATCH 3/8] build: -l arguments to belong into LDADD/LIBADD not LDFLAGS Jan Engelhardt
2018-11-25  9:20             ` [PATCH 4/8] build: -D/-I arguments go into CPPFLAGS Jan Engelhardt
2018-11-25  9:20             ` [PATCH 5/8] build: add missing ELL_CFLAGS Jan Engelhardt
2018-11-25  9:20             ` [PATCH 6/8] build: add missing UDEV_CFLAGS Jan Engelhardt
2018-11-25  9:20             ` [PATCH 7/8] build: add missing ALSA_CFLAGS Jan Engelhardt
2018-11-25  9:20             ` [PATCH 8/8] build: add missing BACKTRACE_CFLAGS Jan Engelhardt
2018-11-26 10:45             ` [PATCH bluez] build system refresh (take 3) Luiz Augusto von Dentz
2018-11-28 14:38               ` Luiz Augusto von Dentz
2018-11-28 15:04                 ` Jan Engelhardt
2018-11-28 15:06                   ` Luiz Augusto von Dentz
2018-11-28 15:45                     ` [PATCH] build: make building with --coverage work again Jan Engelhardt
2018-11-29 11:57                       ` Luiz Augusto von Dentz
2018-11-21 12:57       ` [PATCH 2/7] build: -l arguments to belong into LDADD/LIBADD not LDFLAGS Jan Engelhardt
2018-11-21 12:57       ` [PATCH 3/7] build: -D/-I arguments go into CPPFLAGS Jan Engelhardt
2018-11-21 12:57       ` [PATCH 4/7] build: add missing ELL_CFLAGS Jan Engelhardt
2018-11-21 12:57       ` [PATCH 5/7] build: add missing UDEV_CFLAGS Jan Engelhardt
2018-11-21 12:57       ` [PATCH 6/7] build: add missing ALSA_CFLAGS Jan Engelhardt
2018-11-21 12:57       ` [PATCH 7/7] build: add missing BACKTRACE_CFLAGS Jan Engelhardt
2018-11-18 16:07 ` [PATCH 2/8] build: change @foo@ to $(foo) in automake makefiles Jan Engelhardt
2018-11-18 16:07 ` [PATCH 3/8] build: -l arguments to belong into LDADD/LIBADD not LDFLAGS Jan Engelhardt
2018-11-18 16:07 ` [PATCH 4/8] build: -D/-I arguments go into CPPFLAGS Jan Engelhardt
2018-11-18 16:07 ` [PATCH 5/8] build: add missing ELL_CFLAGS Jan Engelhardt
2018-11-18 16:08 ` [PATCH 6/8] build: add missing UDEV_CFLAGS Jan Engelhardt
2018-11-18 16:08 ` [PATCH 7/8] build: add missing ALSA_CFLAGS Jan Engelhardt
2018-11-18 16:08 ` [PATCH 8/8] build: add missing BACKTRACE_CFLAGS Jan Engelhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=nycvar.YFH.7.76.1811241421150.5864@n3.vanv.qr \
    --to=jengelh@inai.de \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.