All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Kosina <jikos@kernel.org>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Miroslav Benes <mbenes@suse.cz>,
	yamada.masahiro@socionext.com, michal.lkml@markovi.net,
	jeyu@kernel.org, pmladek@suse.com, linux-kbuild@vger.kernel.org,
	live-patching@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kbuild: use -flive-patching when CONFIG_LIVEPATCH is enabled
Date: Wed, 19 Dec 2018 17:58:53 +0100 (CET)	[thread overview]
Message-ID: <nycvar.YFH.7.76.1812191756450.17216@cbobk.fhfr.pm> (raw)
In-Reply-To: <20181219165428.5udrppedpdvf2u7k@treble>

On Wed, 19 Dec 2018, Josh Poimboeuf wrote:

> This option only makes sense for source-based patch generation, so isn't 
> it a bit premature to make this change without proper source-based patch 
> tooling?

The reality is though that before the full-fledged patch tooling exists, 
people are actually already writing livepatches by hand, so this option is 
useful for them.

> Also the commit message needs an analysis of the performance impacts.

Agreed. Especially as it's expected (*) to be completely in the noise 
particularly for the kernel, it'd be good to have that documented in the 
changelog.

(*) actually measured already for some subset of the IPA optimizations

Thanks,

-- 
Jiri Kosina
SUSE Labs


  reply	other threads:[~2018-12-19 16:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-19 14:17 [PATCH] kbuild: use -flive-patching when CONFIG_LIVEPATCH is enabled Miroslav Benes
2018-12-19 16:54 ` Josh Poimboeuf
2018-12-19 16:58   ` Jiri Kosina [this message]
2018-12-19 17:21     ` Josh Poimboeuf
2018-12-19 18:10       ` Jiri Kosina
2018-12-20  8:33         ` Miroslav Benes
2018-12-20 14:46           ` Josh Poimboeuf
2018-12-21  9:45             ` Miroslav Benes
2018-12-20 21:47           ` Joao Moreira
2018-12-21  9:48             ` Miroslav Benes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=nycvar.YFH.7.76.1812191756450.17216@cbobk.fhfr.pm \
    --to=jikos@kernel.org \
    --cc=jeyu@kernel.org \
    --cc=jpoimboe@redhat.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=live-patching@vger.kernel.org \
    --cc=mbenes@suse.cz \
    --cc=michal.lkml@markovi.net \
    --cc=pmladek@suse.com \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.