From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Kosina Subject: Re: [PATCH v3 09/26] compat_ioctl: move drivers to compat_ptr_ioctl Date: Tue, 16 Apr 2019 22:31:24 +0200 (CEST) Message-ID: References: <20190416202013.4034148-1-arnd@arndb.de> <20190416202013.4034148-10-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190416202013.4034148-10-arnd@arndb.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Arnd Bergmann Cc: linux-usb@vger.kernel.org, kvm@vger.kernel.org, "Michael S. Tsirkin" , Alexander Shishkin , Jarkko Sakkinen , virtualization@lists.linux-foundation.org, Benjamin Tissoires , linux-mtd@lists.infradead.org, Peter Huewe , linux1394-devel@lists.sourceforge.net, linux-stm32@st-md-mailman.stormreply.com, devel@driverdev.osuosl.org, Jason Gunthorpe , y2038@lists.linaro.org, Richard Weinberger , Marek Vasut , Jason Gunthorpe , linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org, Tomas Winkler , Alexandre Torgue , Alexander Viro , Stefan Hajnoczi , Willem List-Id: virtualization@lists.linuxfoundation.org On Tue, 16 Apr 2019, Arnd Bergmann wrote: > Each of these drivers has a copy of the same trivial helper function to > convert the pointer argument and then call the native ioctl handler. > > We now have a generic implementation of that, so use it. > > Acked-by: Greg Kroah-Hartman > Reviewed-by: Jarkko Sakkinen > Reviewed-by: Jason Gunthorpe > Signed-off-by: Arnd Bergmann > --- > drivers/char/ppdev.c | 12 +--------- > drivers/char/tpm/tpm_vtpm_proxy.c | 12 +--------- > drivers/firewire/core-cdev.c | 12 +--------- > drivers/hid/usbhid/hiddev.c | 11 +-------- For hiddev.c: Reviewed-by: Jiri Kosina -- Jiri Kosina SUSE Labs