From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24E73C46470 for ; Wed, 29 May 2019 16:27:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E958F23D81 for ; Wed, 29 May 2019 16:27:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559147225; bh=jpOp7EoUMeWEqkI+UWuufre8c2qL/FWHtQg28/LCXHc=; h=Date:From:To:cc:Subject:In-Reply-To:References:List-ID:From; b=j9VZuSmDhG2fnRji8WauajGB6wXuAypGclnUSJY7QjXVN0hpferVbl9h+IQdDziJo MM9Av1zEAk5rgTY2pyndIP9gm+AWem8xl5FaOcZs2xLimrtGPjSNNWtcayYiX1Gwvp NtyWxjiBzZaeJZy9qJYxJzF9ADJG7ihcdHFENLNk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727215AbfE2Q1E (ORCPT ); Wed, 29 May 2019 12:27:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:54134 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726062AbfE2Q1D (ORCPT ); Wed, 29 May 2019 12:27:03 -0400 Received: from pobox.suse.cz (prg-ext-pat.suse.com [213.151.95.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 792D423D61; Wed, 29 May 2019 16:27:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559147223; bh=jpOp7EoUMeWEqkI+UWuufre8c2qL/FWHtQg28/LCXHc=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=dvz3s46lOxyXsLQ/D8guvasY1EuJFeDJKaTJ8GRUHAFxqgDtDireFEhObYeoThI9h M4aXfiEfutjr03JjlCEh9J1aXxiBR9uXSAUK/mc/IVTR69j62tvbU1+azKybFXgai4 b/uMMuomDBYln7Brt+X3pcLw2HEWltA3kXcemm3Q= Date: Wed, 29 May 2019 18:26:59 +0200 (CEST) From: Jiri Kosina To: Josh Poimboeuf cc: "Rafael J. Wysocki" , Pavel Machek , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Peter Zijlstra , x86@kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] x86/power: Fix 'nosmt' vs. hibernation triple fault during resume In-Reply-To: <20190529161028.a6kpywzpjazgql5u@treble> Message-ID: References: <20190529161028.a6kpywzpjazgql5u@treble> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 29 May 2019, Josh Poimboeuf wrote: > hibernation_restore() is called by user space at runtime, via ioctl or > sysfs. So I think this still doesn't fix the case where you've disabled > CPUs at runtime via sysfs, and then resumed from hibernation. Or are we > declaring that this is not a supported scenario? Yeah I personally find that scenario awkward :) Anyway, cpuhp_smt_enable() is going to online even those potentially "manually" offlined CPUs, isn't it? Are you perhaps suggesting to call enable_nonboot_cpus() instead of cpuhp_smt_enable() here to make it more explicit? > Is there are reason why maxcpus= doesn't do the CR4.MCE booted_once > dance? I am not sure whether it's really needed. My understanding is that the MCE issue happens only after primary sibling has been brought up; if that never happened, MCE wouldn't be broadcasted to that core at all in the first place. But this needs to be confirmed by Intel. -- Jiri Kosina SUSE Labs