From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D57A1C28CC3 for ; Fri, 31 May 2019 14:54:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ABFBB26B18 for ; Fri, 31 May 2019 14:54:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559314466; bh=ut6HGUXoVdKpKxWkBmLKfiQdl1KWbFSfImiaNPxTLes=; h=Date:From:To:cc:Subject:In-Reply-To:References:List-ID:From; b=BkM/PhnGZ0Lx4GCBkEPmLXy/nTcsl4QieGhlsbNJzLESaxfGCGQJHWhqqOrbgGKKz kPAlS5YPapUHhUEFn4IwZ8K7C21A6P4AHxaUdS/bB3A5/dppsMVLn2TBIEsBFqzvem XceGMX7h8sEBRtNt1mh+8LvH+dk7B1XY5Dw9iD4s= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726693AbfEaOyZ (ORCPT ); Fri, 31 May 2019 10:54:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:45414 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726418AbfEaOyZ (ORCPT ); Fri, 31 May 2019 10:54:25 -0400 Received: from pobox.suse.cz (prg-ext-pat.suse.com [213.151.95.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 78D9326B11; Fri, 31 May 2019 14:54:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559314464; bh=ut6HGUXoVdKpKxWkBmLKfiQdl1KWbFSfImiaNPxTLes=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=dtMoYgEbe/Pum8dAabX3qtFT9mAjn3HZSFuHy0mwILYh9Ui1Y+W/JhgzAE4Nfq2ku YOvaYRm/5M9b6O9Is8whzrh2+SS0zwG6yLEfcalSeD/TRsG11SNpvMlN8vsuoAVFPZ g4pOv/CJ07M/7HJItd7xbthrqoy0BCAmv7KHlC7Q= Date: Fri, 31 May 2019 16:54:20 +0200 (CEST) From: Jiri Kosina To: Andy Lutomirski cc: Andy Lutomirski , "Rafael J. Wysocki" , Josh Poimboeuf , "Rafael J. Wysocki" , Thomas Gleixner , the arch/x86 maintainers , Pavel Machek , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Peter Zijlstra , Linux PM , Linux Kernel Mailing List Subject: Re: [PATCH v4] x86/power: Fix 'nosmt' vs. hibernation triple fault during resume In-Reply-To: Message-ID: References: <20190531051456.fzkvn62qlkf6wqra@treble> <5564116.e9OFvgDRbB@kreacher> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 31 May 2019, Andy Lutomirski wrote: > For that matter, what actually happens if we get an SMI while halted? > Does RSM go directly to sleep or does it re-fetch the HLT? Our mails just crossed, I replied to Josh's mwait() proposal patch a minute ago. HLT is guaranteed to be re-entered if SMM interrupted it, while MWAIT is not. So as a short-term fix for 5.2, I still believe in v4 of my patch that does the mwait->hlt->mwait transition across hibernate/resume, and for 5.3 I can look into forcing it to wait-for-SIPI proper. -- Jiri Kosina SUSE Labs