All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Kosina <jikos@kernel.org>
To: Peter Hutterer <peter.hutterer@who-t.net>
Cc: linux-input@vger.kernel.org,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Wen He <wen.he_1@nxp.com>
Subject: Re: [PATCH v2] HID: input: do not run GET_REPORT unless there's a Resolution Multiplier
Date: Tue, 16 Jun 2020 17:25:48 +0200 (CEST)	[thread overview]
Message-ID: <nycvar.YFH.7.76.2006161724080.13242@cbobk.fhfr.pm> (raw)
In-Reply-To: <20200609060319.GA36844@jelly>

On Tue, 9 Jun 2020, Peter Hutterer wrote:

> hid-multitouch currently runs GET_REPORT for Contact Max and again to
> retrieve the Win8 blob. If both are within the same report, the
> Resolution Multiplier code calls GET_FEATURE again and this time,
> possibly due to timing, it causes the ILITEK-TP device interpret the
> GET_FEATURE as an instruction to change the mode and effectively stop
> the device from functioning as expected.
> 
> Notably: the device doesn't even have a Resolution Multiplier so it
> shouldn't be affected by any of this at all.
> 
> Fix this by making sure we only execute GET_REPORT if there is
> a Resolution Multiplier in the respective report. Where the
> HID_QUIRK_NO_INIT_REPORTS field is set we just bail out immediately. This
> shouldn't be triggered by any real device anyway.
> 
> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
> Tested-by: Wen He <wen.he_1@nxp.com>
> ---
> Changes to v1:
> - bail out in case of HID_QUIRK_NO_INIT_REPORTS

Applied, thanks Peter.

-- 
Jiri Kosina
SUSE Labs


      reply	other threads:[~2020-06-16 15:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-14 11:14 [PATCH] HID: input: do not run GET_REPORT unless there's a Resolution Multiplier Peter Hutterer
2020-05-14 12:31 ` Benjamin Tissoires
2020-05-14 22:49   ` [PATCH RESEND] " Peter Hutterer
2020-05-15  7:48     ` Benjamin Tissoires
2020-05-28  3:03       ` Peter Hutterer
2020-06-09  6:03 ` [PATCH v2] " Peter Hutterer
2020-06-16 15:25   ` Jiri Kosina [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=nycvar.YFH.7.76.2006161724080.13242@cbobk.fhfr.pm \
    --to=jikos@kernel.org \
    --cc=benjamin.tissoires@redhat.com \
    --cc=linux-input@vger.kernel.org \
    --cc=peter.hutterer@who-t.net \
    --cc=wen.he_1@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.