From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97414C433E1 for ; Fri, 19 Jun 2020 07:43:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 68B9C20890 for ; Fri, 19 Jun 2020 07:43:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592552597; bh=igD+XH9+v5JkWSf/ZVPl/nrnFrjVmI77x+1KYy2Hk3c=; h=Date:From:To:cc:Subject:In-Reply-To:References:List-ID:From; b=TU2EwfiShiWjADBNGewQyKHpXKJPcrRm3jV4uRyBQ3PzaHl7TOdSV4mFHfLmaoYIV Gyd7UthaYSxthI0lv8wghGYLjKEOqiNbb9lWGBq+fMLIw2Oem+m3sg4Mu+KVigFvFa xGs4awdgZEVfvvq1PVzSpPVWc+4SIY6ajPYOhSrU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730902AbgFSHnP (ORCPT ); Fri, 19 Jun 2020 03:43:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:59252 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729548AbgFSHnP (ORCPT ); Fri, 19 Jun 2020 03:43:15 -0400 Received: from pobox.suse.cz (nat1.prg.suse.com [195.250.132.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C27742073E; Fri, 19 Jun 2020 07:43:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592552594; bh=igD+XH9+v5JkWSf/ZVPl/nrnFrjVmI77x+1KYy2Hk3c=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=WSJqxw3yD55O+KDsVUnbhyTSDHFOt68q5n15ICp61DnemstIKpFwc3gcqC+4VOdkm aB4utH+/LYo+Y+y0E0SHgcZH+RX3NnHF/huUt5D2va+LbRe4+2UlJI2SUfTtViTb1G nGO3MJoerV+4W716YskGvo0FFSatmWK4g700DJzc= Date: Fri, 19 Jun 2020 09:43:11 +0200 (CEST) From: Jiri Kosina To: Kai-Heng Feng cc: Srinivas Pandruvada , "Rafael J. Wysocki" , Benjamin Tissoires , Zhang Lixu , Even Xu , Alexios Zavras , Thomas Gleixner , Song Hongyan , "open list:INTEL INTEGRATED SENSOR HUB DRIVER" , open list Subject: Re: [PATCH] HID: intel-ish-hid: Replace PCI_DEV_FLAGS_NO_D3 with pci_save_state In-Reply-To: <68C336BB-C2E1-4DE4-8137-18F7FBEF140C@canonical.com> Message-ID: References: <20200505131730.22118-1-kai.heng.feng@canonical.com> <7E88D4A8-8056-4E12-8B2C-27307A7C5E7D@canonical.com> <68C336BB-C2E1-4DE4-8137-18F7FBEF140C@canonical.com> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 12 Jun 2020, Kai-Heng Feng wrote: > >>> PCI_DEV_FLAGS_NO_D3 should not be used outside of PCI core. > >>> > >>> Instead, we can use pci_save_state() to hint PCI core that the device > >>> should stay at D0 during suspend. > >> > >> Your changes are doing more than just changing the flag. Can you > >> explain more about the other changes? > > > > By using pci_save_state(), in addition to keep itself stay at D0, the parent bridge will also stay at D0. > > So it's a better approach to achieve the same thing. > > > >> Also make sure that you test on both platforms which has regular S3 and > >> S0ix (modern standby system). > > > > Actually I don't have any physical hardware to test the patch, I found the issue when I search for D3 quirks through the source code. > > > > Can you guys do a quick smoketest for this patch? > > Tested this patch on an S2idle system with intel-ish (Latitude 9510) and > it works fine. Please consider merging this patch, thanks! Thanks for testing. Could you please resubmit v2 with the updated changelog (explaining the relationship to the parent bridge mode and the related changes your code is doing), and resubmit so that I can queue it in hid.git? Thanks. -- Jiri Kosina SUSE Labs