From: Jiri Kosina <jikos@kernel.org>
To: "Filipe Laíns" <lains@archlinux.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: logitech-hidpp: add support for Unified Battery (1004) feature
Date: Mon, 18 Jan 2021 11:02:37 +0100 (CET) [thread overview]
Message-ID: <nycvar.YFH.7.76.2101181100040.5622@cbobk.fhfr.pm> (raw)
In-Reply-To: <d65b0829d31ed6eb15f69b8771718d38a56a2502.camel@archlinux.org>
On Fri, 8 Jan 2021, Filipe Laíns wrote:
> Yeah :head_scratch:
> There is a header comment at the start of each feature section, which I think
> does a good job pointing this out. IMO the problem with the naming is more for
> people who see its usage in other parts of the code, but I guess that is C for
> you right? Names don't scale well with code quantity :P
Alright ... thug life :) Let's just keep it the way it is.
> > > > Could you please use standard kernel commenting style here?
> > >
> > > Oops, sorry. Will do :)
I have adjusted the wrong comment and applied. Thanks,
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2021-01-18 21:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-04 18:29 [PATCH] HID: logitech-hidpp: add support for Unified Battery (1004) feature lains
2021-01-06 9:34 ` Bastien Nocera
2021-01-06 18:48 ` Filipe Laíns
2021-01-06 19:17 ` Bastien Nocera
2021-01-08 13:44 ` Jiri Kosina
2021-01-08 14:53 ` Filipe Laíns
2021-01-08 14:55 ` Jiri Kosina
2021-01-08 15:01 ` Filipe Laíns
2021-01-18 10:02 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2101181100040.5622@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=lains@archlinux.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.