From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E00B9C433DB for ; Fri, 5 Feb 2021 09:22:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8BCF764F95 for ; Fri, 5 Feb 2021 09:22:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229763AbhBEJV6 (ORCPT ); Fri, 5 Feb 2021 04:21:58 -0500 Received: from mail.kernel.org ([198.145.29.99]:33620 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230326AbhBEJSb (ORCPT ); Fri, 5 Feb 2021 04:18:31 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 89F7464F46; Fri, 5 Feb 2021 09:17:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612516670; bh=6EY/hJO5lsOUp1lV62vlliw5zVpXQuMcomOmxe0tenY=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=Iic+OCjomMgcXz+Hem4eVlglBXXf+TRuYLnQuE0bwynBS7Lb5wNeH8wa1vDMbq3kw jy8xf83fkz5Oa0tmJSzjJqXaijLXyxi0m1R10BuL44HFIT9rBEtypFrL/60Ecgv4iA mFrGqG6DXWYr8oz35yG4xxW4Ino79uF5p8Ho5rMtxwSLT5IshZwh93A7OXJ5LI98Hs s7ynDuVMarvJoVzIAM1mw77I+qV3rJ0uNpatBaHdW4f0gShrCsW4JwvvEb3QwXiDiT yZFmUnbEin95mSxmeKKVfZLuBbKmVzXAKTPWhJre6sAuZdQXETYvJFbyMwNws8VYlB UdgQ94gmABzwQ== Date: Fri, 5 Feb 2021 10:17:47 +0100 (CET) From: Jiri Kosina To: Jiapeng Chong cc: benjamin.tissoires@redhat.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] HID: wacom: convert sysfs sprintf/snprintf family to sysfs_emit In-Reply-To: <1612253940-19396-1-git-send-email-jiapeng.chong@linux.alibaba.com> Message-ID: References: <1612253940-19396-1-git-send-email-jiapeng.chong@linux.alibaba.com> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2 Feb 2021, Jiapeng Chong wrote: > Fix the following coccicheck warning: > > ./drivers/hid/wacom_sys.c:1828:8-16: WARNING: use scnprintf or sprintf. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong > --- > drivers/hid/wacom_sys.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c > index aa9e488..8328ef1 100644 > --- a/drivers/hid/wacom_sys.c > +++ b/drivers/hid/wacom_sys.c > @@ -1825,7 +1825,7 @@ static ssize_t wacom_show_speed(struct device *dev, > struct hid_device *hdev = to_hid_device(dev); > struct wacom *wacom = hid_get_drvdata(hdev); > > - return snprintf(buf, PAGE_SIZE, "%i\n", wacom->wacom_wac.bt_high_speed); > + return sysfs_emit(buf, "%i\n", wacom->wacom_wac.bt_high_speed); > } Applied, thanks. -- Jiri Kosina SUSE Labs