From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38C5BC2B9F7 for ; Wed, 26 May 2021 10:39:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 101B6613D3 for ; Wed, 26 May 2021 10:39:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234137AbhEZKlT (ORCPT ); Wed, 26 May 2021 06:41:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:52634 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234050AbhEZKlF (ORCPT ); Wed, 26 May 2021 06:41:05 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1B089613D3; Wed, 26 May 2021 10:39:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622025574; bh=XkkR+3D/FW9VYxBOYTi3kuPLSQb/fFmFtNWeOGh98uU=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=bGJcvcujacwa2IPyL5izJYMIWtVxwBpUeou1i8mqK/XXq7Y52M3LW71d+rogG8ZXi nSzo3U58Io9VJ/eYtQ/JE/lNguf+UXD8UeG3/uX96fMFlBbR2zw/HtlkPZ6scJIpKo 0M/u6PGuxw4QwVAlqYPItzDwjmR9zuC2lBxBPv/nC3kq/v8tWaVtXLkifJOhbZ1z0P O5FY0RiH8W8zgaKiXe91N7cc6SAhF5tOJMQaFZeuNNtfit8xP92bXGbwzBL+zcIkdv Nj4dYAoWfCsFmqdN4WZTTklN2IhX5ZV2m2mXDxEct3Rck4NcJns7uiHoapcrIDO1PN genHFjPxf2rhQ== Date: Wed, 26 May 2021 12:39:31 +0200 (CEST) From: Jiri Kosina To: =?ISO-8859-15?Q?Filipe_La=EDns?= cc: trix@redhat.com, benjamin.tissoires@redhat.com, pedro@pedrovanzella.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] HID: logitech-hidpp: initialize level variable In-Reply-To: Message-ID: References: <20210507191819.71092-1-trix@redhat.com> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 16 May 2021, Filipe Laíns wrote: > > Static analysis reports this representative problem > > > > hid-logitech-hidpp.c:1356:23: warning: Assigned value is > >   garbage or undefined > >         hidpp->battery.level = level; > >                              ^ ~~~~~ > > > > In some cases, 'level' is never set in hidpp20_battery_map_status_voltage() > > Since level is not available on all hw, initialize level to unknown. > > > > Fixes: be281368f297 ("hid-logitech-hidpp: read battery voltage from newer > > devices") > > Signed-off-by: Tom Rix > > --- > >  drivers/hid/hid-logitech-hidpp.c | 1 + > >  1 file changed, 1 insertion(+) > > > > diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech- > > hidpp.c > > index 69670ca7e1e1..61635e629469 100644 > > --- a/drivers/hid/hid-logitech-hidpp.c > > +++ b/drivers/hid/hid-logitech-hidpp.c > > @@ -1265,6 +1265,7 @@ static int hidpp20_battery_map_status_voltage(u8 > > data[3], int *voltage, > >         int status; > >   > >         long flags = (long) data[2]; > > +       *level = POWER_SUPPLY_CAPACITY_LEVEL_UNKNOWN; > >   > >         if (flags & 0x80) > >                 switch (flags & 0x07) { > > Hi Tom, > > Taking a look at how this function is used, it does make sense to initialize the > level, thank you :) > > Reviewed-by: Filipe Laíns Applied, thanks. -- Jiri Kosina SUSE Labs