From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D156BC47082 for ; Wed, 26 May 2021 10:49:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AEA40613D8 for ; Wed, 26 May 2021 10:49:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234192AbhEZKuh (ORCPT ); Wed, 26 May 2021 06:50:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:54296 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233959AbhEZKug (ORCPT ); Wed, 26 May 2021 06:50:36 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C143F610A8; Wed, 26 May 2021 10:49:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622026145; bh=TSSvNDUIoJTXJ/LJROSxxiw8o+OmuykYbaXrTyzuKis=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=D7TqMxxwmLrc1ZUcvLvWWEuIixbxveLpgPtE3SlJhz3FUUgn7Ub0e9p2OrH3K0qAM OIMy/iASQ10VGqf1yZVOVbUUyG3cXLLh2IommX6TpqqeOETT1rke7bOyGr+WW1mRUA /QRkR9WrQTuq/ohhBaVvZeEMjG2nsYaNPY8n7Wvefq1VcLey8ANj9lP8QQ6DT8C6Ji OsBFS9LfCFFDrG4ldQgRo2M3WpvGgVE8lstMzE5rsbs0xenT6ODAL385E6pKW0udj3 urKmbszXyN0u2RCwPBd97Trf3gc822Us2GWXlQ+Vb5O9M8oxLj24wHbgDt4hV4Eu8R B0xAfkYmaAhiw== Date: Wed, 26 May 2021 12:49:00 +0200 (CEST) From: Jiri Kosina To: Arnd Bergmann cc: Benjamin Tissoires , Nathan Chancellor , Nick Desaulniers , Julian Sax , Arnd Bergmann , Hans de Goede , Douglas Anderson , Kai-Heng Feng , Xiaofei Tan , Coiby Xu , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com Subject: Re: [PATCH] HID: i2c-hid: fix format string mismatch In-Reply-To: <20210514135901.2924982-1-arnd@kernel.org> Message-ID: References: <20210514135901.2924982-1-arnd@kernel.org> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 14 May 2021, Arnd Bergmann wrote: > From: Arnd Bergmann > > clang doesn't like printing a 32-bit integer using %hX format string: > > drivers/hid/i2c-hid/i2c-hid-core.c:994:18: error: format specifies type 'unsigned short' but the argument has type '__u32' (aka 'unsigned int') [-Werror,-Wformat] > client->name, hid->vendor, hid->product); > ^~~~~~~~~~~ > drivers/hid/i2c-hid/i2c-hid-core.c:994:31: error: format specifies type 'unsigned short' but the argument has type '__u32' (aka 'unsigned int') [-Werror,-Wformat] > client->name, hid->vendor, hid->product); > ^~~~~~~~~~~~ > > Use an explicit cast to truncate it to the low 16 bits instead. > > Fixes: 9ee3e06610fd ("HID: i2c-hid: override HID descriptors for certain devices") > Signed-off-by: Arnd Bergmann Applied, thanks Arnd. -- Jiri Kosina SUSE Labs