From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44A13C47089 for ; Wed, 26 May 2021 10:51:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 28DCB613E6 for ; Wed, 26 May 2021 10:51:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233911AbhEZKwp (ORCPT ); Wed, 26 May 2021 06:52:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:54770 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234215AbhEZKwh (ORCPT ); Wed, 26 May 2021 06:52:37 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 22B74613D8; Wed, 26 May 2021 10:51:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622026266; bh=S9/pAYFIAyH3CJvdhr0NwqSNGC3fJicd7BJ2pjYbvPA=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=FeiU9VWzXwgElY7tn01m8NmxVq7xFXgMpI1g2rr1o7durQr5Qncrx5luZxH8IW3Hr ahkP3oBPNs8ZYKg7zFqZiGTBonEdoZln2YDV3VlzaXyPhYcrRlBoT+5ErTFnobxnw8 OsWMSWjuk6Jz7ACW5jvMty2bJkP3pJDwKGMJDZiws+42phGDLx7BSKk1fUZ1UhTluO dF0i9+YurklDHg3AYzOEPW4EKknns4VtwbN0b98szOYfqnp2wopG2I/Kd6ZKtsZdgR DrEzPJUBVwTRhp/bGLFFmIxkZ36BmtLLThDS+4pYLf+nBgn4yKjPwmOOKTEvI60xJT dOyeJBrgIN3nw== Date: Wed, 26 May 2021 12:51:03 +0200 (CEST) From: Jiri Kosina To: Johan Hovold cc: Benjamin Tissoires , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, syzbot+ee6f6e2e68886ca256a8@syzkaller.appspotmail.com, stable@vger.kernel.org, Claudio Mettler , Marek Wyborski , Sean O'Brien Subject: Re: [PATCH] HID: magicmouse: fix NULL-deref on disconnect In-Reply-To: <20210517100430.20509-1-johan@kernel.org> Message-ID: References: <20210517100430.20509-1-johan@kernel.org> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 17 May 2021, Johan Hovold wrote: > Commit 9d7b18668956 ("HID: magicmouse: add support for Apple Magic > Trackpad 2") added a sanity check for an Apple trackpad but returned > success instead of -ENODEV when the check failed. This means that the > remove callback will dereference the never-initialised driver data > pointer when the driver is later unbound (e.g. on USB disconnect). > > Reported-by: syzbot+ee6f6e2e68886ca256a8@syzkaller.appspotmail.com > Fixes: 9d7b18668956 ("HID: magicmouse: add support for Apple Magic Trackpad 2") > Cc: stable@vger.kernel.org # 4.20 > Cc: Claudio Mettler > Cc: Marek Wyborski > Cc: Sean O'Brien > Signed-off-by: Johan Hovold Applied, thanks Johan. -- Jiri Kosina SUSE Labs