From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-12.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable
	autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 8B5B7C433FE
	for <linux-kernel@archiver.kernel.org>; Thu, 16 Sep 2021 07:15:42 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 6F59360F4A
	for <linux-kernel@archiver.kernel.org>; Thu, 16 Sep 2021 07:15:42 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S234713AbhIPHRB (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Thu, 16 Sep 2021 03:17:01 -0400
Received: from mail.kernel.org ([198.145.29.99]:42064 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S232254AbhIPHQ7 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 16 Sep 2021 03:16:59 -0400
Received: by mail.kernel.org (Postfix) with ESMTPSA id E172160F51;
        Thu, 16 Sep 2021 07:15:37 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1631776539;
        bh=XR0iDHgJpz1GsMhQZUOrZND8ovGzw3mdUlGSBvzw0rY=;
        h=Date:From:To:cc:Subject:In-Reply-To:References:From;
        b=M1rGMdBB/f3uAvoZJYaEMutJ54nUbNMjSsgtlgWtsuNiQZzJaXLCrmOLl+54YWTYb
         IlTlwfWgkmYLNn96xqFdcODcG9Utlor5iSNLSUPnn8/JctcDjP25ImY1Ju8g2e8ZMr
         9FwpM+jk3DR37pi8NrZgCNQbiAHRtmb/uIsdgw8e6xgXxJL/cHdoKTOz2zT0+0P83G
         C3MoaMokvpKG6H4vn/fRjtPoIu/qetwy9w1YKZES/rjnjEGrDGSU7pYKWlTTsGeDru
         QZRXRu3/hG0Ita24VX0h7sfQES5uyOmByW3WuQgOlRNcSQdXaFt4jiJnGRZ1t1UIwq
         m1Y8lI8WWh5VA==
Date:   Thu, 16 Sep 2021 09:15:36 +0200 (CEST)
From:   Jiri Kosina <jikos@kernel.org>
To:     Evgeny Novikov <novikov@ispras.ru>
cc:     Nehal Shah <nehal-bakulchandra.shah@amd.com>,
        Sandeep Singh <sandeep.singh@amd.com>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
        ldv-project@linuxtesting.org
Subject: Re: [PATCH] AMD_SFH: Fix potential NULL pointer dereference
In-Reply-To: <20210601163801.17848-1-novikov@ispras.ru>
Message-ID: <nycvar.YFH.7.76.2109160915270.15944@cbobk.fhfr.pm>
References: <20210601163801.17848-1-novikov@ispras.ru>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 1 Jun 2021, Evgeny Novikov wrote:

> devm_add_action_or_reset() can suddenly invoke amd_mp2_pci_remove() at
> registration that will cause NULL pointer dereference since
> corresponding data is not initialized yet. The patch moves
> initialization of data before devm_add_action_or_reset().
> 
> Found by Linux Driver Verification project (linuxtesting.org).
> 
> Signed-off-by: Evgeny Novikov <novikov@ispras.ru>

Applied, thank you.

-- 
Jiri Kosina
SUSE Labs