From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3AC9A2C81 for ; Thu, 11 Nov 2021 16:25:07 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id A3C246124C; Thu, 11 Nov 2021 16:25:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1636647906; bh=dw0x+LBQ552ApvZujaQIillgV6iC1yb5QQ5PK/digpQ=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=AQu3TUpVccJo4t7u3W3hOW69QX8iDiJz8OrLBhAO1QJQhPdKguQishmbKqVi6KrON y4Y1KdAToySCDwJx9OJe8PlwiVd8iH+62xubOBPXSX4/je/rqHZlzpwqUDKGGJOlBe JHrylfyQcRyOxdnTwLdaz4cDrFyiXV5nKWjAf4NHj3/Zdrk464+HTyk5p+abcqtEpH 0QAFVoqJ6ikODrnzHA9r0CSTLyuEMKHkXiLqX9H8Dt0CAzgbM9DN6/KfakeV/fxgb1 co0YrhJzDbDXLs/8QRANEXorz+wzMF9NoJJZ4drQ4H+AWxwdjD6deloua9TyTpidos Z9Jv8NfiG3S6g== Date: Thu, 11 Nov 2021 17:25:01 +0100 (CET) From: Jiri Kosina To: Arnd Bergmann cc: Srinivas Pandruvada , Benjamin Tissoires , Benson Leung , Sumesh K Naduvalath , Hans de Goede , Mark Gross , Nathan Chancellor , Nick Desaulniers , =?ISO-8859-15?Q?Thomas_Wei=DFschuh?= , Arnd Bergmann , Guenter Roeck , Lee Jones , =?ISO-8859-15?Q?Uwe_Kleine-K=F6nig?= , Greg Kroah-Hartman , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH] HID: intel-ish-hid: fix module device-id handling In-Reply-To: <20211111085842.2846422-1-arnd@kernel.org> Message-ID: References: <20211111085842.2846422-1-arnd@kernel.org> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 11 Nov 2021, Arnd Bergmann wrote: > From: Arnd Bergmann > > A late addititon to the intel-ish-hid framework caused a build failure > with clang, and introduced an ABI to the module loader that stops working > if any driver ever needs to bind to more than one UUID: > > drivers/hid/intel-ish-hid/ishtp-fw-loader.c:1067:4: error: initializer element is not a compile-time constant > > Change the ishtp_device_id to have correct documentation and a driver_data > field like all the other ones, and change the drivers to use the ID table > as the primary identification in a way that works with all compilers > and avoids duplciating the identifiers. > > Fixes: f155dfeaa4ee ("platform/x86: isthp_eclite: only load for matching devices") > Fixes: facfe0a4fdce ("platform/chrome: chros_ec_ishtp: only load for matching devices") > Fixes: 0d0cccc0fd83 ("HID: intel-ish-hid: hid-client: only load for matching devices") > Fixes: 44e2a58cb880 ("HID: intel-ish-hid: fw-loader: only load for matching devices") > Fixes: cb1a2c6847f7 ("HID: intel-ish-hid: use constants for modaliases") > Fixes: fa443bc3c1e4 ("HID: intel-ish-hid: add support for MODULE_DEVICE_TABLE()") > Signed-off-by: Arnd Bergmann I have fixed the ecl_ishtp_cl_driver.id initialization and applied. Thanks a lot for spotting and fixing this, Arnd. -- Jiri Kosina SUSE Labs