All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Kosina <jikos@kernel.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Pablo Ceballos <pceballos@google.com>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	lkml <linux-kernel@vger.kernel.org>,
	"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>
Subject: Re: [PATCH] HID: Driver for Google Hangouts Meet Speakermic
Date: Thu, 12 May 2022 12:53:06 +0200 (CEST)	[thread overview]
Message-ID: <nycvar.YFH.7.76.2205121252090.28985@cbobk.fhfr.pm> (raw)
In-Reply-To: <CAKdAkRQ7yxFFGJg41UxptxapKiP4bmHsfw7dRNE+LPzs1PRk=A@mail.gmail.com>

On Thu, 12 May 2022, Dmitry Torokhov wrote:

> > > This driver works around a problem with the HID usage sent by this
> > > device for the mute button. It prevents key events from being generated
> > > for that HID usage since they would be incorrect.
> > >
> > > Signed-off-by: Pablo Ceballos <pceballos@google.com>
> >
> > Applied to hid.git#for-5.19/google. Thanks,
> 
> I am curious, could not this be achieved without a kernel driver by
> simply using udev to map this usage code to KEY_RESERVED?

Hmm, good point, using KEY_RESERVED mapping to achieve the key being 
actually ignored didn't immediately occur to me.

Pablo, could you please verify that it behaves in the expected way, and 
confirm that we could drop the 'driver' in favor of udev rule?

Thanks,

-- 
Jiri Kosina
SUSE Labs


  reply	other threads:[~2022-05-12 10:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-05 18:39 [PATCH] HID: Driver for Google Hangouts Meet Speakermic Pablo Ceballos
2022-04-12 22:20 ` Pablo Ceballos
2022-04-21  7:48 ` Jiri Kosina
2022-05-12  9:34   ` Dmitry Torokhov
2022-05-12 10:53     ` Jiri Kosina [this message]
2022-05-12 22:35       ` Pablo Ceballos
2022-05-12 22:47         ` Dmitry Torokhov
2022-05-16 15:03           ` Pablo Ceballos
2022-05-16 18:23           ` Benjamin Tissoires
2022-05-22 15:05             ` Pavel Machek
2022-05-23  6:50               ` Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=nycvar.YFH.7.76.2205121252090.28985@cbobk.fhfr.pm \
    --to=jikos@kernel.org \
    --cc=benjamin.tissoires@redhat.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pceballos@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.