From: Jiri Kosina <jikos@kernel.org>
To: Basavaraj Natikar <Basavaraj.Natikar@amd.com>
Cc: benjamin.tissoires@redhat.com, rdunlap@infradead.org,
linux-input@vger.kernel.org, linux-next@vger.kernel.org,
sfr@canb.auug.org.au
Subject: Re: [PATCH for-next 0/2] Fixes to amd_sfh driver
Date: Sat, 23 Jul 2022 20:11:16 +0200 (CEST) [thread overview]
Message-ID: <nycvar.YFH.7.76.2207232011090.19850@cbobk.fhfr.pm> (raw)
In-Reply-To: <20220723061033.1377061-1-Basavaraj.Natikar@amd.com>
On Sat, 23 Jul 2022, Basavaraj Natikar wrote:
> Changes includes to handle "no sensors" case and fix of implicit
> declaration error on i386.
>
> Link: https://lore.kernel.org/all/92ed10f9-2c84-ad42-20d1-f8a101f78f08@infradead.org/
> '''
> From: Randy Dunlap <rdunlap@infradead.org>
> Changes since 20220721:
>
> on i386:
>
> ../drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_interface.c: In function ‘amd_stop_sensor’:
> ../drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_interface.c:48:9: error: implicit declaration of function ‘writeq’; did you mean ‘writel’? [-Werror=implicit-function-declaration]
> 48 | writeq(0x0, privdata->mmio + AMD_C2P_MSG(1));
> | ^~~~~~
> | writel
> '''
>
> Basavaraj Natikar (2):
> HID: amd_sfh: Fix implicit declaration error on i386
> HID: amd_sfh: Handle condition of "no sensors"
>
> drivers/hid/amd-sfh-hid/amd_sfh_client.c | 2 ++
> drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_interface.c | 2 ++
> 2 files changed, 4 insertions(+)
Queued in hid.git, thanks.
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2022-07-23 18:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-23 6:10 [PATCH for-next 0/2] Fixes to amd_sfh driver Basavaraj Natikar
2022-07-23 6:10 ` [PATCH for-next 1/2] HID: amd_sfh: Fix implicit declaration error on i386 Basavaraj Natikar
2022-07-23 6:10 ` [PATCH for-next 2/2] HID: amd_sfh: Handle condition of "no sensors" Basavaraj Natikar
2022-07-23 18:11 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2207232011090.19850@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=Basavaraj.Natikar@amd.com \
--cc=benjamin.tissoires@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.