From: Nicolas Pitre <nicolas.pitre@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Thomas Gleixner <tglx@linutronix.de>,
y2038@lists.linaro.org, Al Viro <viro@zeniv.linux.org.uk>,
Deepa Dinamani <deepa.kernel@gmail.com>,
John Stultz <john.stultz@linaro.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] posix-stubs: use get_timespec64() and put_timespec64()
Date: Fri, 13 Oct 2017 15:22:54 -0400 (EDT) [thread overview]
Message-ID: <nycvar.YSQ.7.76.1710131522270.1750@knanqh.ubzr> (raw)
In-Reply-To: <20171013183009.3442318-1-arnd@arndb.de>
On Fri, 13 Oct 2017, Arnd Bergmann wrote:
> This is a follow-up to commit 5c4994102fb5 ("posix-timers:
> Use get_timespec64() and put_timespec64()"), which left two
> system call using copy_from_user()/copy_to_user(). We can
> change them as well for consistency.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Nicolas Pitre <nico@linaro.org>
> ---
> kernel/time/posix-stubs.c | 20 ++++++++------------
> 1 file changed, 8 insertions(+), 12 deletions(-)
>
> diff --git a/kernel/time/posix-stubs.c b/kernel/time/posix-stubs.c
> index 06f34feb635e..b258bee13b02 100644
> --- a/kernel/time/posix-stubs.c
> +++ b/kernel/time/posix-stubs.c
> @@ -117,8 +117,7 @@ SYSCALL_DEFINE4(clock_nanosleep, const clockid_t, which_clock, int, flags,
> const struct timespec __user *, rqtp,
> struct timespec __user *, rmtp)
> {
> - struct timespec64 t64;
> - struct timespec t;
> + struct timespec64 t;
>
> switch (which_clock) {
> case CLOCK_REALTIME:
> @@ -129,16 +128,15 @@ SYSCALL_DEFINE4(clock_nanosleep, const clockid_t, which_clock, int, flags,
> return -EINVAL;
> }
>
> - if (copy_from_user(&t, rqtp, sizeof (struct timespec)))
> + if (get_timespec64(&t, rqtp))
> return -EFAULT;
> - t64 = timespec_to_timespec64(t);
> - if (!timespec64_valid(&t64))
> + if (!timespec64_valid(&t))
> return -EINVAL;
> if (flags & TIMER_ABSTIME)
> rmtp = NULL;
> current->restart_block.nanosleep.type = rmtp ? TT_NATIVE : TT_NONE;
> current->restart_block.nanosleep.rmtp = rmtp;
> - return hrtimer_nanosleep(&t64, flags & TIMER_ABSTIME ?
> + return hrtimer_nanosleep(&t, flags & TIMER_ABSTIME ?
> HRTIMER_MODE_ABS : HRTIMER_MODE_REL,
> which_clock);
> }
> @@ -203,8 +201,7 @@ COMPAT_SYSCALL_DEFINE4(clock_nanosleep, clockid_t, which_clock, int, flags,
> struct compat_timespec __user *, rqtp,
> struct compat_timespec __user *, rmtp)
> {
> - struct timespec64 t64;
> - struct timespec t;
> + struct timespec64 t;
>
> switch (which_clock) {
> case CLOCK_REALTIME:
> @@ -215,16 +212,15 @@ COMPAT_SYSCALL_DEFINE4(clock_nanosleep, clockid_t, which_clock, int, flags,
> return -EINVAL;
> }
>
> - if (compat_get_timespec(&t, rqtp))
> + if (compat_get_timespec64(&t, rqtp))
> return -EFAULT;
> - t64 = timespec_to_timespec64(t);
> - if (!timespec64_valid(&t64))
> + if (!timespec64_valid(&t))
> return -EINVAL;
> if (flags & TIMER_ABSTIME)
> rmtp = NULL;
> current->restart_block.nanosleep.type = rmtp ? TT_COMPAT : TT_NONE;
> current->restart_block.nanosleep.compat_rmtp = rmtp;
> - return hrtimer_nanosleep(&t64, flags & TIMER_ABSTIME ?
> + return hrtimer_nanosleep(&t, flags & TIMER_ABSTIME ?
> HRTIMER_MODE_ABS : HRTIMER_MODE_REL,
> which_clock);
> }
> --
> 2.9.0
>
>
next prev parent reply other threads:[~2017-10-13 19:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-13 18:29 [PATCH] posix-stubs: use get_timespec64() and put_timespec64() Arnd Bergmann
2017-10-13 19:22 ` Nicolas Pitre [this message]
2017-10-17 15:42 ` [tip:timers/core] posix-stubs: Use " tip-bot for Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YSQ.7.76.1710131522270.1750@knanqh.ubzr \
--to=nicolas.pitre@linaro.org \
--cc=arnd@arndb.de \
--cc=deepa.kernel@gmail.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.