Re: [PATCH v3 2/2] net: tulip: add .can_recieve routine

From: P J P <ppandit@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Li Qiang <pangpei.lq@antfin.com>,
	Jason Wang <jasowang@redhat.com>,
	Sven Schnelle <svens@stackframe.org>,
	Qemu Developers <qemu-devel@nongnu.org>,
	Ziming Zhang <ezrakiez@gmail.com>
Subject: Re: [PATCH v3 2/2] net: tulip: add .can_recieve routine
Date: Mon, 16 Mar 2020 23:31:08 +0530 (IST)	[thread overview]
Message-ID: <nycvar.YSQ.7.76.2003162325500.5086@xnncv> (raw)
In-Reply-To: <20200306130853.GM1335569@stefanha-x1.localdomain>

  Hello Stefan, Jason,

+-- On Fri, 6 Mar 2020, Stefan Hajnoczi wrote --+
| > +static int
| > +tulip_can_receive(NetClientState *nc)
| > +{
| > +    TULIPState *s = qemu_get_nic_opaque(nc);
| > +
| > +    if (s->rx_frame_len || tulip_rx_stopped(s)) {
| > +        return false;
| > +    }
| > +
| > +    return true;
| > +}
| 
| Are the required qemu_flush_queued_packets() calls in place so that
| packet transfer wakes up again when .can_receive() transitions from
| false to true?

  Yes, qemu_flush_queued_packets() calls are in tulip_write(). Do we need to 
call tulip_can_receive() before each call?

Thank you.
--
Prasad J Pandit / Red Hat Product Security Team
8685 545E B54C 486B C6EB 271E E285 8B5A F050 DE8D