From: P J P <ppandit@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Fam Zheng" <fam@euphon.net>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Alexander Bulekov" <alxndr@bu.edu>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Ding Ren" <rding@gatech.edu>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [PATCH v3] exec: set map length to zero when returning NULL
Date: Tue, 26 May 2020 16:48:17 +0530 (IST) [thread overview]
Message-ID: <nycvar.YSQ.7.77.849.2005261631400.62159@xnncv> (raw)
In-Reply-To: <CAFEAcA9N7n4mpznFBXgZeZnFXhCaeJwfwvJVeAc6U3W2mjQPAQ@mail.gmail.com>
+-- On Tue, 26 May 2020, Peter Maydell wrote --+
| The doc comment for this function in include/exec/memory.h currently says
|
| "May return %NULL if resources needed to perform the mapping
| are exhausted."
|
| If we're tightening the API to guarantee to also set *plen to 0 in this
| failure case it would be good to capture that in the documentation, eg:
|
| "May return %NULL (and set *@plen to 0) if resources needed
| to perform the mapping are exhausted.)"
Sending patch v4. Thank you.
--
Prasad J Pandit / Red Hat Product Security Team
8685 545E B54C 486B C6EB 271E E285 8B5A F050 DE8D
prev parent reply other threads:[~2020-05-26 11:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 7:50 [PATCH v3] exec: set map length to zero when returning NULL P J P
2020-05-26 8:01 ` Philippe Mathieu-Daudé
2020-05-26 10:06 ` Philippe Mathieu-Daudé
2020-05-26 10:19 ` Peter Maydell
2020-05-26 11:18 ` P J P [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YSQ.7.77.849.2005261631400.62159@xnncv \
--to=ppandit@redhat.com \
--cc=alxndr@bu.edu \
--cc=fam@euphon.net \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rding@gatech.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.