All of lore.kernel.org
 help / color / mirror / Atom feed
From: P J P <ppandit@redhat.com>
To: BALATON Zoltan <balaton@eik.bme.hu>
Cc: Ren Ding <rding@gatech.edu>, Yi Ren <c4tren@gmail.com>,
	Gerd Hoffmann <kraxel@redhat.com>,
	Hanqing Zhao <hanqing@gatech.edu>,
	QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PATCH] ati-vga: increment mm_index in ati_mm_read/write
Date: Thu, 4 Jun 2020 00:38:54 +0530 (IST)	[thread overview]
Message-ID: <nycvar.YSQ.7.77.849.2006032325450.62159@xnncv> (raw)
In-Reply-To: <alpine.BSF.2.22.395.2006031740220.57649@zero.eik.bme.hu>

+-- On Wed, 3 Jun 2020, BALATON Zoltan wrote --+
| or even > MM_DATA + 3 may be best as that only refers to defines used in 
| that case. So maybe
| 
| +  } else if (s->regs.mm_index > MM_DATA + 3) {
| >     ati_mm_write(s, s->regs.mm_index + addr - MM_DATA, data, size);
| >  }
| >
| > and do the same in ati_mm_read() as well.

Sent patch v2. Thank you.
--
Prasad J Pandit / Red Hat Product Security Team
8685 545E B54C 486B C6EB 271E E285 8B5A F050 DE8D



      reply	other threads:[~2020-06-03 19:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-03 12:47 [PATCH] ati-vga: increment mm_index in ati_mm_read/write P J P
2020-06-03 13:44 ` Gerd Hoffmann
2020-06-03 13:56   ` BALATON Zoltan
2020-06-03 14:35   ` P J P
2020-06-03 15:32     ` Gerd Hoffmann
2020-06-03 15:38     ` BALATON Zoltan
2020-06-03 15:43       ` BALATON Zoltan
2020-06-03 19:08         ` P J P [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=nycvar.YSQ.7.77.849.2006032325450.62159@xnncv \
    --to=ppandit@redhat.com \
    --cc=balaton@eik.bme.hu \
    --cc=c4tren@gmail.com \
    --cc=hanqing@gatech.edu \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rding@gatech.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.