From: P J P <ppandit@redhat.com>
To: Li Qiang <liq3ea@gmail.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Alexander Bulekov <alxndr@bu.edu>,
Gerd Hoffmann <kraxel@redhat.com>,
Yongkang Jia <j_kangel@163.com>, Gaoning Pan <pgn@zju.edu.cn>,
Yi Ren <yunye.ry@alibaba-inc.com>
Subject: Re: [PATCH] hw: usb: hcd-ohci: check len and frame_number variables
Date: Tue, 15 Sep 2020 12:17:48 +0530 (IST) [thread overview]
Message-ID: <nycvar.YSQ.7.78.906.2009151150360.10832@xnncv> (raw)
In-Reply-To: <20200912014825.eg73ixfjkknzd46n@mozz.bu.edu>
+-- On Fri, 11 Sep 2020, Alexander Bulekov wrote --+
| > On 200911 2257, Li Qiang wrote:
| > > Could you also provide the reproducer?
* Sorry, we can not share reproducers on the list, I'm afraid.
* Thank you Alex for the -qtests.
| > > I think it is better to split this patch to 2 or three as the infinite
| > > loop as the buffer overflow are independent.
| > >
| > > 1. here the infinite loop
| > > 2. here the stack buffer overflow
| > > 3. Then here is the heap overflow.
| > >
| > > So I think it can be more easier to review to split this to 3 patches.
* These issues are in the same UHCI controller and share the same pattern,
triggered while processing ED/TD lists. They can be combined as a single
CVE.
* Infinite-loop is different. I'll break it into two patches, one for OOB
access and one to avoid an infinite loop case.
Thank you.
--
Prasad J Pandit / Red Hat Product Security Team
8685 545E B54C 486B C6EB 271E E285 8B5A F050 DE8D
prev parent reply other threads:[~2020-09-15 6:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-11 12:27 [PATCH] hw: usb: hcd-ohci: check len and frame_number variables P J P
2020-09-11 14:57 ` Li Qiang
2020-09-11 19:20 ` Alexander Bulekov
2020-09-12 1:48 ` Alexander Bulekov
2020-09-15 6:47 ` P J P [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YSQ.7.78.906.2009151150360.10832@xnncv \
--to=ppandit@redhat.com \
--cc=alxndr@bu.edu \
--cc=j_kangel@163.com \
--cc=kraxel@redhat.com \
--cc=liq3ea@gmail.com \
--cc=pgn@zju.edu.cn \
--cc=qemu-devel@nongnu.org \
--cc=yunye.ry@alibaba-inc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.