From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FD65C41604 for ; Wed, 7 Oct 2020 16:41:30 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AC4EC2064E for ; Wed, 7 Oct 2020 16:41:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XHXoSX/S"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=pobox.com header.i=@pobox.com header.b="sJ+WW/vG"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=fluxnic.net header.i=@fluxnic.net header.b="G+imyhL1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AC4EC2064E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=fluxnic.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:Message-ID:In-Reply-To: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0euMsjVeOSSITeYqWpnySSUroc3GU51BCWc3m3w199I=; b=XHXoSX/Si5TK3U0Cm3+mV+LMq KTp/njeSah/rxMZbxWR86AdqMbchzYTJKch/LHq8RpyonnM/eNpfFH2uMtR01+jZim95Ujwf1XkRO BRD087bL0pKfv1zRRy+DJSpmTHpl7c2pueKeLiemHnnJzgVr5nRvJ+P+aLUW+N7Emt8ILDoHiyVtY fDGvDSnH/vN/ERALAsHCllAIAVnRpVOUHARlYWtfA9hOIKgZZtvlzZFZi4k5euby+sQe6quGyiWNH 20aGXpJZouz4rPD1P9LiVY4rstYi6ItUCfldxxTZW+IS6mBdZQcrynaCoIBnTqwwssCS3Jl3pU7nZ AmB6vw0Nw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQCU7-0000NP-ID; Wed, 07 Oct 2020 16:40:11 +0000 Received: from pb-smtp2.pobox.com ([64.147.108.71]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQCU5-0000MZ-30 for linux-arm-kernel@lists.infradead.org; Wed, 07 Oct 2020 16:40:09 +0000 Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 864008C2FB; Wed, 7 Oct 2020 12:40:07 -0400 (EDT) (envelope-from nico@fluxnic.net) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=date:from:to :cc:subject:in-reply-to:message-id:references:mime-version :content-type; s=sasl; bh=2N4vHp0jr3b5yfSv4b+cHykyOso=; b=sJ+WW/ vGvUxR2b8ExOa+0ecurWFc++Z5fekrKGbgubbDwgQzb+J8amTmaj0DQi62ulQRS+ T9VQq12lBGf51EtMVpwDavH5tkhvxzwov5KJbz925Ql0nVo/cAEAD5ac9HshYlUS TXANVi7zmZSyGxuxRtrjw2OjxT57u2eHtuYg4= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id C42AE8C2FA; Wed, 7 Oct 2020 12:40:06 -0400 (EDT) (envelope-from nico@fluxnic.net) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=fluxnic.net; h=date:from:to:cc:subject:in-reply-to:message-id:references:mime-version:content-type; s=2016-12.pbsmtp; bh=Drh+/vrgDb0rjNXDhKcQPuhSMxu/axEP5uazpNVJyx8=; b=G+imyhL1SUdG6nH8HbHZ2Oh2w3IMnhd3vXXg9+qvdy/mBf3hdJElx08Opu751jjCkxxHjchYtG9R/nOpbcjLNX4Qp4qvSDAcQyif2SvSJhyk+MYJwhO6oi/V/ackTudMkzt67TQbk/NCx9Q8JpEZheEaLBgaD+thZSlcA3PSSKo= Received: from yoda.home (unknown [24.203.50.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id BF9258C2F7; Wed, 7 Oct 2020 12:40:04 -0400 (EDT) (envelope-from nico@fluxnic.net) Received: from xanadu.home (xanadu.home [192.168.2.2]) by yoda.home (Postfix) with ESMTPSA id 75C362DA0A99; Wed, 7 Oct 2020 12:40:03 -0400 (EDT) Date: Wed, 7 Oct 2020 12:40:03 -0400 (EDT) From: Nicolas Pitre To: Ard Biesheuvel Subject: Re: [PATCH v2 2/2] ARM: move device tree mapping out of linear region In-Reply-To: Message-ID: References: <20201007083944.27910-1-ardb@kernel.org> <20201007083944.27910-3-ardb@kernel.org> MIME-Version: 1.0 X-Pobox-Relay-ID: C098050A-08BB-11EB-BA6D-74DE23BA3BAF-78420484!pb-smtp2.pobox.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201007_124009_181257_73D22BC5 X-CRM114-Status: GOOD ( 15.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Linus Walleij , Florian Fainelli , Russell King , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 7 Oct 2020, Ard Biesheuvel wrote: > On Wed, 7 Oct 2020 at 17:28, Nicolas Pitre wrote: > > > > On Wed, 7 Oct 2020, Ard Biesheuvel wrote: > > > > > @@ -1078,13 +1078,18 @@ void __init hyp_mode_check(void) > > > void __init setup_arch(char **cmdline_p) > > > { > > > const struct machine_desc *mdesc = NULL; > > > + void *atags_vaddr; > > > > > > if (__atags_pointer) > > > - atags_vaddr = phys_to_virt(__atags_pointer); > > > + atags_vaddr = FDT_VIRT_ADDR(__atags_pointer); > > > > > > setup_processor(); > > > - if (atags_vaddr) > > > + if (atags_vaddr) { > > > mdesc = setup_machine_fdt(atags_vaddr); > > > > If __atags_pointer is zero, you'll end up with atags_vaddr being > > undefined here. I'm surprised the compiler didn't warn about that. > > > > Ah yes, well spotted. I'll add a NULL initializer. OK. Then you may add Reviewed-by: Nicolas Pitre Nicolas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel