From: Koen Kooi <koen@dominion.thruhere.net>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [meta-networking][PATCH] samba: fix the hardcoded path in init script
Date: Mon, 28 Nov 2016 09:17:43 +0100 [thread overview]
Message-ID: <o1gp73$b06$1@blaine.gmane.org> (raw)
In-Reply-To: <1B858668EC6A94408DCA5225FDFA85AA013A3560D2@ALA-MBA.corp.ad.wrs.com>
Op 26-11-16 om 07:26 schreef Huang, Jie (Jackie):
>
>
>> -----Original Message-----
>> From: openembedded-devel-bounces@lists.openembedded.org [mailto:openembedded-devel-
>> bounces@lists.openembedded.org] On Behalf Of Koen Kooi
>> Sent: Thursday, November 24, 2016 6:40 PM
>> To: openembedded-devel@lists.openembedded.org
>> Subject: Re: [oe] [meta-networking][PATCH] samba: fix the hardcoded path in init script
>>
>> Op 24-11-16 om 06:57 schreef jackie.huang@windriver.com:
>>> From: Jackie Huang <jackie.huang@windriver.com>
>>>
>>> Replace the hardcoded path with base_bindir in init script to fix the
>>> error: /etc/init.d/samba.sh: line 15: /usr/bin/ps: No such file or
>>> directory /etc/init.d/samba.sh: line 17: /usr/bin/sed: No such file or
>>> directory /etc/init.d/samba.sh: line 16: /usr/bin/grep: No such file or
>>> directory
>>>
>>> Signed-off-by: Jackie Huang <jackie.huang@windriver.com> ---
>>> meta-networking/recipes-connectivity/samba/samba_4.4.5.bb | 1 + 1 file
>>> changed, 1 insertion(+)
>>>
>>> diff --git a/meta-networking/recipes-connectivity/samba/samba_4.4.5.bb
>>> b/meta-networking/recipes-connectivity/samba/samba_4.4.5.bb index
>>> e9694d4..6c1e3ef 100644 ---
>>> a/meta-networking/recipes-connectivity/samba/samba_4.4.5.bb +++
>>> b/meta-networking/recipes-connectivity/samba/samba_4.4.5.bb @@ -111,6
>>> +111,7 @@ do_install_append() { -e
>>> 's,/opt/samba/smb.conf,${sysconfdir}/samba/smb.conf,g' \ -e
>>> 's,/opt/samba/log,${localstatedir}/log/samba,g' \ -e
>>> 's,/etc/init.d/samba.server,${sysconfdir}/init.d/samba.sh,g' \ +
>>> -e 's,/usr/bin,${base_bindir},g' \ -i ${D}${sysconfdir}/init.d/samba.sh
>>> fi
>>
>> Wouldn't it be better to completely remove the absolute paths?
>
> Yeah, the absolute paths don't seem to be necessary, and I think this
> check in the init script is not needed as well:
>
> if [ ! -d /usr/bin ]
> then # /usr not mounted
> exit
> fi
>
> I will make a path to remove them if you're agree.
Yes, agree. Thanks for looking into this.
prev parent reply other threads:[~2016-11-28 8:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-24 5:57 [meta-networking][PATCH] samba: fix the hardcoded path in init script jackie.huang
2016-11-24 10:40 ` Koen Kooi
2016-11-26 6:26 ` Huang, Jie (Jackie)
2016-11-28 8:17 ` Koen Kooi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='o1gp73$b06$1@blaine.gmane.org' \
--to=koen@dominion.thruhere.net \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.