From: Kalle Valo <quic_kvalo@quicinc.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: <kbuild@lists.01.org>, Carl Huang <quic_cjhuang@quicinc.com>,
<lkp@intel.com>, <kbuild-all@lists.01.org>,
Linux Memory Management List <linux-mm@kvack.org>,
<ath11k@lists.infradead.org>, Wen Gong <quic_wgong@quicinc.com>
Subject: Re: [linux-next:master 408/8237] drivers/net/wireless/ath/ath11k/wow.c:712 ath11k_wow_op_resume() warn: inconsistent returns '&ar->conf_mutex'.
Date: Wed, 4 May 2022 19:23:12 +0300 [thread overview]
Message-ID: <o5hh7658dxr.fsf@quicinc.com> (raw)
In-Reply-To: <202205032236.kofEquX3-lkp@intel.com> (Dan Carpenter's message of "Wed, 4 May 2022 11:46:27 +0300")
+ ath11k, wen
Dan Carpenter <dan.carpenter@oracle.com> writes:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head: 44a2f39e611ac0bc1f17c288a583d7f2e5684aa7
> commit: 90bf5c8d0f7ecddf96fc1cd9434af4e157b51970 [408/8237] ath11k:
> purge rx pktlog when entering WoW
> config: i386-randconfig-m021-20220502
> (https://download.01.org/0day-ci/archive/20220503/202205032236.kofEquX3-lkp@intel.com/config)
> compiler: gcc-11 (Debian 11.2.0-20) 11.2.0
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> smatch warnings:
> drivers/net/wireless/ath/ath11k/wow.c:712 ath11k_wow_op_resume() warn:
> inconsistent returns '&ar->conf_mutex'.
>
> vim +712 drivers/net/wireless/ath/ath11k/wow.c
>
> ba9177fcef21fa Carl Huang 2022-03-14 653 int
> ath11k_wow_op_resume(struct ieee80211_hw *hw)
> ba9177fcef21fa Carl Huang 2022-03-14 654 {
> ba9177fcef21fa Carl Huang 2022-03-14 655 struct ath11k *ar = hw->priv;
> ba9177fcef21fa Carl Huang 2022-03-14 656 int ret;
> ba9177fcef21fa Carl Huang 2022-03-14 657
> ba9177fcef21fa Carl Huang 2022-03-14 658 mutex_lock(&ar->conf_mutex);
> ba9177fcef21fa Carl Huang 2022-03-14 659
> ba9177fcef21fa Carl Huang 2022-03-14 660 ret = ath11k_hif_resume(ar->ab);
> ba9177fcef21fa Carl Huang 2022-03-14 661 if (ret) {
> ba9177fcef21fa Carl Huang 2022-03-14 662 ath11k_warn(ar->ab, "failed
> to resume hif: %d\n", ret);
> ba9177fcef21fa Carl Huang 2022-03-14 663 goto exit;
> ba9177fcef21fa Carl Huang 2022-03-14 664 }
> ba9177fcef21fa Carl Huang 2022-03-14 665
> ba9177fcef21fa Carl Huang 2022-03-14 666 ath11k_hif_ce_irq_enable(ar->ab);
> ba9177fcef21fa Carl Huang 2022-03-14 667 ath11k_hif_irq_enable(ar->ab);
> ba9177fcef21fa Carl Huang 2022-03-14 668
> 90bf5c8d0f7ecd Carl Huang 2022-03-14 669 ret = ath11k_dp_rx_pktlog_start(ar->ab);
> 90bf5c8d0f7ecd Carl Huang 2022-03-14 670 if (ret) {
> 90bf5c8d0f7ecd Carl Huang 2022-03-14 671 ath11k_warn(ar->ab, "failed
> to start rx pktlog from wow: %d\n", ret);
> 90bf5c8d0f7ecd Carl Huang 2022-03-14 672 return ret;
>
> goto exit;
Carl or Wen, are you able to send a fix for this?
WARNING: multiple messages have this Message-ID
From: Kalle Valo <quic_kvalo@quicinc.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: <kbuild@lists.01.org>, Carl Huang <quic_cjhuang@quicinc.com>,
<lkp@intel.com>, <kbuild-all@lists.01.org>,
Linux Memory Management List <linux-mm@kvack.org>,
<ath11k@lists.infradead.org>, Wen Gong <quic_wgong@quicinc.com>
Subject: Re: [linux-next:master 408/8237] drivers/net/wireless/ath/ath11k/wow.c:712 ath11k_wow_op_resume() warn: inconsistent returns '&ar->conf_mutex'.
Date: Wed, 4 May 2022 19:23:12 +0300 [thread overview]
Message-ID: <o5hh7658dxr.fsf@quicinc.com> (raw)
In-Reply-To: <202205032236.kofEquX3-lkp@intel.com> (Dan Carpenter's message of "Wed, 4 May 2022 11:46:27 +0300")
+ ath11k, wen
Dan Carpenter <dan.carpenter@oracle.com> writes:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head: 44a2f39e611ac0bc1f17c288a583d7f2e5684aa7
> commit: 90bf5c8d0f7ecddf96fc1cd9434af4e157b51970 [408/8237] ath11k:
> purge rx pktlog when entering WoW
> config: i386-randconfig-m021-20220502
> (https://download.01.org/0day-ci/archive/20220503/202205032236.kofEquX3-lkp@intel.com/config)
> compiler: gcc-11 (Debian 11.2.0-20) 11.2.0
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> smatch warnings:
> drivers/net/wireless/ath/ath11k/wow.c:712 ath11k_wow_op_resume() warn:
> inconsistent returns '&ar->conf_mutex'.
>
> vim +712 drivers/net/wireless/ath/ath11k/wow.c
>
> ba9177fcef21fa Carl Huang 2022-03-14 653 int
> ath11k_wow_op_resume(struct ieee80211_hw *hw)
> ba9177fcef21fa Carl Huang 2022-03-14 654 {
> ba9177fcef21fa Carl Huang 2022-03-14 655 struct ath11k *ar = hw->priv;
> ba9177fcef21fa Carl Huang 2022-03-14 656 int ret;
> ba9177fcef21fa Carl Huang 2022-03-14 657
> ba9177fcef21fa Carl Huang 2022-03-14 658 mutex_lock(&ar->conf_mutex);
> ba9177fcef21fa Carl Huang 2022-03-14 659
> ba9177fcef21fa Carl Huang 2022-03-14 660 ret = ath11k_hif_resume(ar->ab);
> ba9177fcef21fa Carl Huang 2022-03-14 661 if (ret) {
> ba9177fcef21fa Carl Huang 2022-03-14 662 ath11k_warn(ar->ab, "failed
> to resume hif: %d\n", ret);
> ba9177fcef21fa Carl Huang 2022-03-14 663 goto exit;
> ba9177fcef21fa Carl Huang 2022-03-14 664 }
> ba9177fcef21fa Carl Huang 2022-03-14 665
> ba9177fcef21fa Carl Huang 2022-03-14 666 ath11k_hif_ce_irq_enable(ar->ab);
> ba9177fcef21fa Carl Huang 2022-03-14 667 ath11k_hif_irq_enable(ar->ab);
> ba9177fcef21fa Carl Huang 2022-03-14 668
> 90bf5c8d0f7ecd Carl Huang 2022-03-14 669 ret = ath11k_dp_rx_pktlog_start(ar->ab);
> 90bf5c8d0f7ecd Carl Huang 2022-03-14 670 if (ret) {
> 90bf5c8d0f7ecd Carl Huang 2022-03-14 671 ath11k_warn(ar->ab, "failed
> to start rx pktlog from wow: %d\n", ret);
> 90bf5c8d0f7ecd Carl Huang 2022-03-14 672 return ret;
>
> goto exit;
Carl or Wen, are you able to send a fix for this?
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
WARNING: multiple messages have this Message-ID
From: Kalle Valo <quic_kvalo@quicinc.com>
To: kbuild-all@lists.01.org
Subject: Re: [linux-next:master 408/8237] drivers/net/wireless/ath/ath11k/wow.c:712 ath11k_wow_op_resume() warn: inconsistent returns '&ar->conf_mutex'.
Date: Wed, 04 May 2022 19:23:12 +0300 [thread overview]
Message-ID: <o5hh7658dxr.fsf@quicinc.com> (raw)
In-Reply-To: <202205032236.kofEquX3-lkp@intel.com>
[-- Attachment #1: Type: text/plain, Size: 2313 bytes --]
+ ath11k, wen
Dan Carpenter <dan.carpenter@oracle.com> writes:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head: 44a2f39e611ac0bc1f17c288a583d7f2e5684aa7
> commit: 90bf5c8d0f7ecddf96fc1cd9434af4e157b51970 [408/8237] ath11k:
> purge rx pktlog when entering WoW
> config: i386-randconfig-m021-20220502
> (https://download.01.org/0day-ci/archive/20220503/202205032236.kofEquX3-lkp(a)intel.com/config)
> compiler: gcc-11 (Debian 11.2.0-20) 11.2.0
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> smatch warnings:
> drivers/net/wireless/ath/ath11k/wow.c:712 ath11k_wow_op_resume() warn:
> inconsistent returns '&ar->conf_mutex'.
>
> vim +712 drivers/net/wireless/ath/ath11k/wow.c
>
> ba9177fcef21fa Carl Huang 2022-03-14 653 int
> ath11k_wow_op_resume(struct ieee80211_hw *hw)
> ba9177fcef21fa Carl Huang 2022-03-14 654 {
> ba9177fcef21fa Carl Huang 2022-03-14 655 struct ath11k *ar = hw->priv;
> ba9177fcef21fa Carl Huang 2022-03-14 656 int ret;
> ba9177fcef21fa Carl Huang 2022-03-14 657
> ba9177fcef21fa Carl Huang 2022-03-14 658 mutex_lock(&ar->conf_mutex);
> ba9177fcef21fa Carl Huang 2022-03-14 659
> ba9177fcef21fa Carl Huang 2022-03-14 660 ret = ath11k_hif_resume(ar->ab);
> ba9177fcef21fa Carl Huang 2022-03-14 661 if (ret) {
> ba9177fcef21fa Carl Huang 2022-03-14 662 ath11k_warn(ar->ab, "failed
> to resume hif: %d\n", ret);
> ba9177fcef21fa Carl Huang 2022-03-14 663 goto exit;
> ba9177fcef21fa Carl Huang 2022-03-14 664 }
> ba9177fcef21fa Carl Huang 2022-03-14 665
> ba9177fcef21fa Carl Huang 2022-03-14 666 ath11k_hif_ce_irq_enable(ar->ab);
> ba9177fcef21fa Carl Huang 2022-03-14 667 ath11k_hif_irq_enable(ar->ab);
> ba9177fcef21fa Carl Huang 2022-03-14 668
> 90bf5c8d0f7ecd Carl Huang 2022-03-14 669 ret = ath11k_dp_rx_pktlog_start(ar->ab);
> 90bf5c8d0f7ecd Carl Huang 2022-03-14 670 if (ret) {
> 90bf5c8d0f7ecd Carl Huang 2022-03-14 671 ath11k_warn(ar->ab, "failed
> to start rx pktlog from wow: %d\n", ret);
> 90bf5c8d0f7ecd Carl Huang 2022-03-14 672 return ret;
>
> goto exit;
Carl or Wen, are you able to send a fix for this?
next prev parent reply other threads:[~2022-05-04 16:23 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-03 14:36 [linux-next:master 408/8237] drivers/net/wireless/ath/ath11k/wow.c:712 ath11k_wow_op_resume() warn: inconsistent returns '&ar->conf_mutex' kernel test robot
2022-05-04 8:46 ` Dan Carpenter
2022-05-04 8:46 ` Dan Carpenter
2022-05-04 16:23 ` Kalle Valo [this message]
2022-05-04 16:23 ` Kalle Valo
2022-05-04 16:23 ` Kalle Valo
2022-05-05 1:29 ` Carl Huang
2022-05-05 1:29 ` Carl Huang
2022-05-05 5:58 ` Dan Carpenter
2022-05-05 5:58 ` Dan Carpenter
2022-05-05 5:58 ` Dan Carpenter
2022-05-05 5:58 ` Dan Carpenter
2022-05-06 8:46 ` Kalle Valo
2022-05-06 8:46 ` Kalle Valo
2022-05-06 8:46 ` Kalle Valo
2022-05-06 9:58 ` [kbuild-all] " Chen, Rong A
2022-05-06 9:58 ` Chen, Rong A
2022-05-06 10:24 ` Dan Carpenter
2022-05-06 10:24 ` Dan Carpenter
2022-05-06 10:24 ` [kbuild-all] " Dan Carpenter
2022-05-06 10:24 ` Dan Carpenter
2022-05-06 13:25 ` Kalle Valo
2022-05-06 13:25 ` Kalle Valo
2022-05-06 13:25 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=o5hh7658dxr.fsf@quicinc.com \
--to=quic_kvalo@quicinc.com \
--cc=ath11k@lists.infradead.org \
--cc=dan.carpenter@oracle.com \
--cc=kbuild-all@lists.01.org \
--cc=kbuild@lists.01.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=quic_cjhuang@quicinc.com \
--cc=quic_wgong@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.