From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753913Ab1HSMRp (ORCPT ); Fri, 19 Aug 2011 08:17:45 -0400 Received: from mail-fx0-f46.google.com ([209.85.161.46]:47828 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751090Ab1HSMRn convert rfc822-to-8bit (ORCPT ); Fri, 19 Aug 2011 08:17:43 -0400 Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes To: "Yang Rui Rui" Cc: "Alan Stern" , "Sergei Shtylyov" , "Felipe Balbi" , "Sebastian Andrzej Siewior" , "Yang Ruirui R" , "Greg Kroah-Hartman" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCHv2] usb: gadget: get rid of USB_GADGET_DUALSPEED and USB_GADGET_SUPERSPEED References: <4E4DC418.8050009@tieto.com> Date: Fri, 19 Aug 2011 14:17:40 +0200 MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT From: "Michal Nazarewicz" Message-ID: In-Reply-To: <4E4DC418.8050009@tieto.com> User-Agent: Opera Mail/11.50 (Linux) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On 08/19/2011 01:05 AM, Michal Nazarewicz wrote: >> For the most part, usb_composite_probe() is called only once in module's >> init function. As far as I know, only g_ffs calls it several times. So >> in all cases expect for g_ffs, composite_driver.speed = >> min(composite_driver.speed, >> driver->max_speed) should have the same effect as composite_driver.speed >> = driver->max_speed. On Fri, 19 Aug 2011 04:02:00 +0200, Yang Rui Rui wrote: > For original code, ifndef CONFIG_USB_GADGET_SUPERSPEED and max_speed = > USB_SPEED_SUPER then the result will be: > > composite_driver.speed = min(USB_SPEED_HIGH, USB_SPEED_SUPER) > > For patched code, composite_driver.speed = USB_SPEED_SUPER OK, I see your point. This is the issue that we are discussing in another “branch” of the thread. It seems either usb_gadget_driver_probe() should make sure driver->speed is not too high or each UDC need to handle gadgets which support speed higher then the UDC can handle. -- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michal "mina86" Nazarewicz (o o) ooo +----------ooO--(_)--Ooo--