From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755967Ab1HWTFi (ORCPT ); Tue, 23 Aug 2011 15:05:38 -0400 Received: from smtp-out.google.com ([74.125.121.67]:16035 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755916Ab1HWTF2 (ORCPT ); Tue, 23 Aug 2011 15:05:28 -0400 DomainKey-Signature: a=rsa-sha1; s=beta; d=google.com; c=nofws; q=dns; h=dkim-signature:content-type:to:cc:subject:references:date: mime-version:content-transfer-encoding:from:organization:message-id: in-reply-to:user-agent:x-system-of-record; b=eWm2mR/ZmKfCtRGKmqoxRc8qNmxEdv40k8/bf7xV9Vc6a2KICF86LhEi5804PdenI ETFeKBTVJlhknFwCeaylA== Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes To: "Felipe Balbi" , "Alan Stern" Cc: "Sebastian Andrzej Siewior" , "Yang Rui Rui" , "Dave Young" , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv3 2/4] usb: gadget: replace "is_dualspeed" with "max_speed" References: Date: Tue, 23 Aug 2011 21:05:22 +0200 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: "Michal Nazarewicz" Organization: Google Message-ID: In-Reply-To: User-Agent: Opera Mail/11.50 (Linux) X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 23 Aug 2011 20:00:25 +0200, Alan Stern wrote: > For the time being, perhaps the best answer is to use the _lowest_ > max_speed value among all the function drivers. It's the simplest > answer and most likely to be correct most of the time. In theory, one could create a composite function with only SS/HS descriptors. So it would work for SS/HS but not for FS. I'm not saying that it would make sense (or that it's not a bug) but that adds to the discussion. -- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michal "mina86" Nazarewicz (o o) ooo +----------ooO--(_)--Ooo--