From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chunhe Lan Subject: Re: [PATCH 3/3 v2] mmc: Use mmc_delay() instead of mdelay() for time delay Date: Tue, 6 Sep 2011 14:52:18 +0800 Message-ID: References: <1314345310-15041-1-git-send-email-Chunhe.Lan@freescale.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Return-path: Received: from tx2ehsobe004.messaging.microsoft.com ([65.55.88.14]:31551 "EHLO TX2EHSOBE008.bigfish.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752984Ab1IFGux (ORCPT ); Tue, 6 Sep 2011 02:50:53 -0400 In-Reply-To: Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Kumar Gala , Chunhe Lan , Chris Ball Cc: linux-mmc@vger.kernel.org, Shengzhou Liu , PPC list On Thu, 01 Sep 2011 12:42:08 +0800, Kumar Gala wrote: > > On Aug 26, 2011, at 2:55 AM, Chunhe Lan wrote: > >> The mmc_delay() is a wrapper function for mdelay() and msleep(). >> >> o mdelay() -- block the system when busy-waiting. >> o msleep() -- suspend the currently running task to enable CPU >> to process other tasks, so it is non-blocking >> regarding the whole system. >> >> When the desired delay time is more than a period of timer interrupt, >> just use msleep(). Change mdelay() to mmc_delay() to avoid chewing >> CPU when busy wait. >> >> Signed-off-by: Shengzhou Liu >> Signed-off-by: Chunhe Lan >> Cc: Chris Ball >> --- >> drivers/mmc/host/sdhci.c | 10 +++++----- >> 1 files changed, 5 insertions(+), 5 deletions(-) > > It might be good to either merge patch 2/3 & 3/3 or rename them since > they have same commit message. > > Chris, > > Any comments on closing on these patches? > Hello Chris, Do you any comments on these patches ? If not, can you apply these patches to mmc-next ? Thanks. -Jack > - k From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from TX2EHSOBE008.bigfish.com (tx2ehsobe004.messaging.microsoft.com [65.55.88.14]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (Client CN "mail.global.frontbridge.com", Issuer "Microsoft Secure Server Authority" (verified OK)) by ozlabs.org (Postfix) with ESMTPS id 4ABA5B6F7C for ; Tue, 6 Sep 2011 16:50:57 +1000 (EST) Content-Type: text/plain; charset="utf-8"; format=flowed; delsp=yes To: Kumar Gala , Chunhe Lan , Chris Ball Subject: Re: [PATCH 3/3 v2] mmc: Use mmc_delay() instead of mdelay() for time delay References: <1314345310-15041-1-git-send-email-Chunhe.Lan@freescale.com> Date: Tue, 6 Sep 2011 14:52:18 +0800 MIME-Version: 1.0 From: Chunhe Lan Message-ID: In-Reply-To: Cc: Shengzhou Liu , linux-mmc@vger.kernel.org, PPC list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, 01 Sep 2011 12:42:08 +0800, Kumar Gala wrote: > > On Aug 26, 2011, at 2:55 AM, Chunhe Lan wrote: > >> The mmc_delay() is a wrapper function for mdelay() and msleep(). >> >> o mdelay() -- block the system when busy-waiting. >> o msleep() -- suspend the currently running task to enable CPU >> to process other tasks, so it is non-blocking >> regarding the whole system. >> >> When the desired delay time is more than a period of timer interrupt, >> just use msleep(). Change mdelay() to mmc_delay() to avoid chewing >> CPU when busy wait. >> >> Signed-off-by: Shengzhou Liu >> Signed-off-by: Chunhe Lan >> Cc: Chris Ball >> --- >> drivers/mmc/host/sdhci.c | 10 +++++----- >> 1 files changed, 5 insertions(+), 5 deletions(-) > > It might be good to either merge patch 2/3 & 3/3 or rename them since > they have same commit message. > > Chris, > > Any comments on closing on these patches? > Hello Chris, Do you any comments on these patches ? If not, can you apply these patches to mmc-next ? Thanks. -Jack > - k