From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932678Ab2AMUEj (ORCPT ); Fri, 13 Jan 2012 15:04:39 -0500 Received: from mail-ee0-f46.google.com ([74.125.83.46]:44618 "EHLO mail-ee0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758988Ab2AMUEg convert rfc822-to-8bit (ORCPT ); Fri, 13 Jan 2012 15:04:36 -0500 Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes To: "Marek Szyprowski" , "Mel Gorman" Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-mm@kvack.org, linaro-mm-sig@lists.linaro.org, "Kyungmin Park" , "Russell King" , "Andrew Morton" , "KAMEZAWA Hiroyuki" , "Daniel Walker" , "Arnd Bergmann" , "Jesse Barker" , "Jonathan Corbet" , "Shariq Hasnain" , "Chunsang Jeong" , "Dave Hansen" , "Benjamin Gaignard" Subject: Re: [PATCH 04/11] mm: page_alloc: introduce alloc_contig_range() References: <1325162352-24709-1-git-send-email-m.szyprowski@samsung.com> <1325162352-24709-5-git-send-email-m.szyprowski@samsung.com> <20120110141613.GB3910@csn.ul.ie> Date: Fri, 13 Jan 2012 21:04:31 +0100 MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT From: "Michal Nazarewicz" Message-ID: In-Reply-To: <20120110141613.GB3910@csn.ul.ie> User-Agent: Opera Mail/11.60 (Linux) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Thu, Dec 29, 2011 at 01:39:05PM +0100, Marek Szyprowski wrote: >> From: Michal Nazarewicz >> + /* Make sure all pages are isolated. */ >> + if (!ret) { >> + lru_add_drain_all(); >> + drain_all_pages(); >> + if (WARN_ON(test_pages_isolated(start, end))) >> + ret = -EBUSY; >> + } On Tue, 10 Jan 2012 15:16:13 +0100, Mel Gorman wrote: > Another global IPI seems overkill. Drain pages only from the local CPU > (drain_pages(get_cpu()); put_cpu()) and test if the pages are isolated. Is get_cpu() + put_cpu() required? Won't drain_local_pages() work? -- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michał “mina86” Nazarewicz (o o) ooo +------------------ooO--(_)--Ooo-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx163.postini.com [74.125.245.163]) by kanga.kvack.org (Postfix) with SMTP id 645406B004F for ; Fri, 13 Jan 2012 15:04:36 -0500 (EST) Received: by eaan1 with SMTP id n1so359908eaa.14 for ; Fri, 13 Jan 2012 12:04:34 -0800 (PST) Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes Subject: Re: [PATCH 04/11] mm: page_alloc: introduce alloc_contig_range() References: <1325162352-24709-1-git-send-email-m.szyprowski@samsung.com> <1325162352-24709-5-git-send-email-m.szyprowski@samsung.com> <20120110141613.GB3910@csn.ul.ie> Date: Fri, 13 Jan 2012 21:04:31 +0100 MIME-Version: 1.0 Content-Transfer-Encoding: Quoted-Printable From: "Michal Nazarewicz" Message-ID: In-Reply-To: <20120110141613.GB3910@csn.ul.ie> Sender: owner-linux-mm@kvack.org List-ID: To: Marek Szyprowski , Mel Gorman Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-mm@kvack.org, linaro-mm-sig@lists.linaro.org, Kyungmin Park , Russell King , Andrew Morton , KAMEZAWA Hiroyuki , Daniel Walker , Arnd Bergmann , Jesse Barker , Jonathan Corbet , Shariq Hasnain , Chunsang Jeong , Dave Hansen , Benjamin Gaignard > On Thu, Dec 29, 2011 at 01:39:05PM +0100, Marek Szyprowski wrote: >> From: Michal Nazarewicz >> + /* Make sure all pages are isolated. */ >> + if (!ret) { >> + lru_add_drain_all(); >> + drain_all_pages(); >> + if (WARN_ON(test_pages_isolated(start, end))) >> + ret =3D -EBUSY; >> + } On Tue, 10 Jan 2012 15:16:13 +0100, Mel Gorman wrote: > Another global IPI seems overkill. Drain pages only from the local CPU= > (drain_pages(get_cpu()); put_cpu()) and test if the pages are isolated= . Is get_cpu() + put_cpu() required? Won't drain_local_pages() work? -- = Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=3D./ `o ..o | Computer Science, Micha=C5=82 =E2=80=9Cmina86=E2=80=9D Nazarewicz= (o o) ooo +------------------ooO--(_)--Ooo-- -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: mina86@mina86.com (Michal Nazarewicz) Date: Fri, 13 Jan 2012 21:04:31 +0100 Subject: [PATCH 04/11] mm: page_alloc: introduce alloc_contig_range() In-Reply-To: <20120110141613.GB3910@csn.ul.ie> References: <1325162352-24709-1-git-send-email-m.szyprowski@samsung.com> <1325162352-24709-5-git-send-email-m.szyprowski@samsung.com> <20120110141613.GB3910@csn.ul.ie> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org > On Thu, Dec 29, 2011 at 01:39:05PM +0100, Marek Szyprowski wrote: >> From: Michal Nazarewicz >> + /* Make sure all pages are isolated. */ >> + if (!ret) { >> + lru_add_drain_all(); >> + drain_all_pages(); >> + if (WARN_ON(test_pages_isolated(start, end))) >> + ret = -EBUSY; >> + } On Tue, 10 Jan 2012 15:16:13 +0100, Mel Gorman wrote: > Another global IPI seems overkill. Drain pages only from the local CPU > (drain_pages(get_cpu()); put_cpu()) and test if the pages are isolated. Is get_cpu() + put_cpu() required? Won't drain_local_pages() work? -- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Micha? ?mina86? Nazarewicz (o o) ooo +------------------ooO--(_)--Ooo--