From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752952Ab1FNSky (ORCPT ); Tue, 14 Jun 2011 14:40:54 -0400 Received: from mail-fx0-f46.google.com ([209.85.161.46]:63241 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751145Ab1FNSku convert rfc822-to-8bit (ORCPT ); Tue, 14 Jun 2011 14:40:50 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:content-type:to:cc:subject:references:date:mime-version :content-transfer-encoding:from:message-id:in-reply-to:user-agent; b=EZ37+CatjcwYrsfV7tUS25EC/rF0I2nLIs6mHPh8nfGXhKJygJR3/Ovlv9BNaLEitC TDVNpm2+Kg8F5xQ/KDUbCxmFpMJAp9yS5JE/AHA+OtkhbbvNr4LIOdNRqNt0ahjQNX0N T3I6mhYbaCn8tNuWt/drMoOYH5gbxl+Ci9Sc8= Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes To: "Arnd Bergmann" Cc: "Marek Szyprowski" , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-mm@kvack.org, linaro-mm-sig@lists.linaro.org, "'Kyungmin Park'" , "'Andrew Morton'" , "'KAMEZAWA Hiroyuki'" , "'Ankita Garg'" , "'Daniel Walker'" , "'Mel Gorman'" , "'Jesse Barker'" Subject: Re: [PATCH 08/10] mm: cma: Contiguous Memory Allocator added References: <1307699698-29369-1-git-send-email-m.szyprowski@samsung.com> <201106141803.00876.arnd@arndb.de> <201106142030.07549.arnd@arndb.de> Date: Tue, 14 Jun 2011 20:40:46 +0200 MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT From: "Michal Nazarewicz" Message-ID: In-Reply-To: <201106142030.07549.arnd@arndb.de> User-Agent: Opera Mail/11.10 (Linux) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Tuesday 14 June 2011 18:58:35 Michal Nazarewicz wrote: >> Is having support for multiple regions a bad thing? Frankly, >> removing this support will change code from reading context passed >> as argument to code reading context from global variable. Nothing >> is gained; functionality is lost. On Tue, 14 Jun 2011 20:30:07 +0200, Arnd Bergmann wrote: > What is bad IMHO is making them the default, which forces the board > code to care about memory management details. I would much prefer > to have contiguous allocation parameters tuned automatically to just > work on most boards before we add ways to do board-specific hacks. I see those as orthogonal problems. The code can have support for multiple contexts but by default use a single global context exported as cma_global variable (or some such). And I'm not arguing against having “contiguous allocation parameters tuned automatically to just work on most boards”. I just don't see the reason to delete functionality that is already there, does not add much code and can be useful. -- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michal "mina86" Nazarewicz (o o) ooo +----------ooO--(_)--Ooo-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail172.messagelabs.com (mail172.messagelabs.com [216.82.254.3]) by kanga.kvack.org (Postfix) with ESMTP id 74A4C6B0012 for ; Tue, 14 Jun 2011 14:40:57 -0400 (EDT) Received: by fxm18 with SMTP id 18so5633336fxm.14 for ; Tue, 14 Jun 2011 11:40:48 -0700 (PDT) Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes Subject: Re: [PATCH 08/10] mm: cma: Contiguous Memory Allocator added References: <1307699698-29369-1-git-send-email-m.szyprowski@samsung.com> <201106141803.00876.arnd@arndb.de> <201106142030.07549.arnd@arndb.de> Date: Tue, 14 Jun 2011 20:40:46 +0200 MIME-Version: 1.0 Content-Transfer-Encoding: Quoted-Printable From: "Michal Nazarewicz" Message-ID: In-Reply-To: <201106142030.07549.arnd@arndb.de> Sender: owner-linux-mm@kvack.org List-ID: To: Arnd Bergmann Cc: Marek Szyprowski , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-mm@kvack.org, linaro-mm-sig@lists.linaro.org, 'Kyungmin Park' , 'Andrew Morton' , 'KAMEZAWA Hiroyuki' , 'Ankita Garg' , 'Daniel Walker' , 'Mel Gorman' , 'Jesse Barker' > On Tuesday 14 June 2011 18:58:35 Michal Nazarewicz wrote: >> Is having support for multiple regions a bad thing? Frankly, >> removing this support will change code from reading context passed >> as argument to code reading context from global variable. Nothing >> is gained; functionality is lost. On Tue, 14 Jun 2011 20:30:07 +0200, Arnd Bergmann wrote: > What is bad IMHO is making them the default, which forces the board > code to care about memory management details. I would much prefer > to have contiguous allocation parameters tuned automatically to just > work on most boards before we add ways to do board-specific hacks. I see those as orthogonal problems. The code can have support for multiple contexts but by default use a single global context exported as cma_global variable (or some such). And I'm not arguing against having =E2=80=9Ccontiguous allocation parame= ters tuned automatically to just work on most boards=E2=80=9D. I just don't = see the reason to delete functionality that is already there, does not add much code and can be useful. -- = Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=3D./ `o ..o | Computer Science, Michal "mina86" Nazarewicz (o o) ooo +----------ooO--(_)--Ooo-- -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: mina86@mina86.com (Michal Nazarewicz) Date: Tue, 14 Jun 2011 20:40:46 +0200 Subject: [PATCH 08/10] mm: cma: Contiguous Memory Allocator added In-Reply-To: <201106142030.07549.arnd@arndb.de> References: <1307699698-29369-1-git-send-email-m.szyprowski@samsung.com> <201106141803.00876.arnd@arndb.de> <201106142030.07549.arnd@arndb.de> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org > On Tuesday 14 June 2011 18:58:35 Michal Nazarewicz wrote: >> Is having support for multiple regions a bad thing? Frankly, >> removing this support will change code from reading context passed >> as argument to code reading context from global variable. Nothing >> is gained; functionality is lost. On Tue, 14 Jun 2011 20:30:07 +0200, Arnd Bergmann wrote: > What is bad IMHO is making them the default, which forces the board > code to care about memory management details. I would much prefer > to have contiguous allocation parameters tuned automatically to just > work on most boards before we add ways to do board-specific hacks. I see those as orthogonal problems. The code can have support for multiple contexts but by default use a single global context exported as cma_global variable (or some such). And I'm not arguing against having ?contiguous allocation parameters tuned automatically to just work on most boards?. I just don't see the reason to delete functionality that is already there, does not add much code and can be useful. -- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michal "mina86" Nazarewicz (o o) ooo +----------ooO--(_)--Ooo--