* [PATCH] ixgbe: Report PAUSE flags to ethtool
[not found] <op.vwnklt0q6ywr33@esapekka-pc.rad1>
@ 2011-06-08 6:33 ` Esa-Pekka Pyokkimies
0 siblings, 0 replies; only message in thread
From: Esa-Pekka Pyokkimies @ 2011-06-08 6:33 UTC (permalink / raw)
To: netdev
Hello!
I noticed that ixgbe driver doesn't report SUPPORTED_Pause and
ADVERTISED_Pause flags to ethtool. This means that ethtool
always reports:
Supported pause frame use: No
Advertised pause frame use: No
I added reporting for capabilities and advertising.
I tested it with our ixgbe card and latest ethtool
from git repo. I also need to add capability to
change advertising parameters with "ethtool -s advertise %x",
but will send in a different patch if this patch looks ok.
Signed-off-by: Esa-Pekka Pyokkimies <esa-pekka.pyokkimies@stonesoft.com>
---
diff --git a/drivers/net/ixgbe/ixgbe_ethtool.c
b/drivers/net/ixgbe/ixgbe_ethtool.c
index cb1555b..6005116 100644
--- a/drivers/net/ixgbe/ixgbe_ethtool.c
+++ b/drivers/net/ixgbe/ixgbe_ethtool.c
@@ -150,6 +150,7 @@ static int ixgbe_get_settings(struct net_device
*netdev,
bool link_up;
ecmd->supported = SUPPORTED_10000baseT_Full;
+ ecmd->supported |= SUPPORTED_Pause;
ecmd->autoneg = AUTONEG_ENABLE;
ecmd->transceiver = XCVR_EXTERNAL;
if ((hw->phy.media_type == ixgbe_media_type_copper) ||
@@ -231,6 +232,21 @@ static int ixgbe_get_settings(struct net_device
*netdev,
ecmd->autoneg = AUTONEG_DISABLE;
}
+ if (hw->fc.current_mode == ixgbe_fc_full) {
+ ecmd->advertising |= ADVERTISED_Pause;
+ } else if (hw->fc.current_mode == ixgbe_fc_rx_pause) {
+ ecmd->advertising |= ADVERTISED_Pause;
+ ecmd->advertising |= ADVERTISED_Asym_Pause;
+ } else if (hw->fc.current_mode == ixgbe_fc_tx_pause) {
+ ecmd->advertising |= ADVERTISED_Asym_Pause;
+ } else if (hw->fc.current_mode == ixgbe_fc_none) {
+ /* Correctly initialized */
+ } else if (hw->fc.current_mode == ixgbe_fc_pfc) {
+ /* Ethtool doesn't know about this mode */
+ } else {
+ /* Future modes */
+ }
+
/* Get PHY type */
switch (adapter->hw.phy.type) {
case ixgbe_phy_tn:
--
Using Opera's revolutionary email client: http://www.opera.com/mail/
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2011-06-08 6:55 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <op.vwnklt0q6ywr33@esapekka-pc.rad1>
2011-06-08 6:33 ` [PATCH] ixgbe: Report PAUSE flags to ethtool Esa-Pekka Pyokkimies
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.