From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755429Ab1FJRQu (ORCPT ); Fri, 10 Jun 2011 13:16:50 -0400 Received: from mail-fx0-f46.google.com ([209.85.161.46]:59110 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752889Ab1FJRQs (ORCPT ); Fri, 10 Jun 2011 13:16:48 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:content-type:to:cc:subject:references:date:mime-version :content-transfer-encoding:from:message-id:in-reply-to:user-agent; b=OW+mmgJz4We28vj2ImqQYLuHWZYuGxBADnW5fiDBZiPSXWNT3NjUCfXNNaGVOaQFRE 7EIadGz+l+q+CzYZovE3RkQtYKbL2jSf4laHbdg38Ai6Z1vrchOMYLdyBw+efAeLX2Rt G+D2Ji9o2gwu0Xe3EP9iVU1IDzzbtaOyYwhK0= Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes To: "Marek Szyprowski" , "Alan Cox" Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-mm@kvack.org, linaro-mm-sig@lists.linaro.org, "'Kyungmin Park'" , "'Andrew Morton'" , "'KAMEZAWA Hiroyuki'" , "'Ankita Garg'" , "'Daniel Walker'" , "'Johan MOSSBERG'" , "'Mel Gorman'" , "'Arnd Bergmann'" , "'Jesse Barker'" Subject: Re: [PATCH 02/10] lib: genalloc: Generic allocator improvements References: <1307699698-29369-1-git-send-email-m.szyprowski@samsung.com> <1307699698-29369-3-git-send-email-m.szyprowski@samsung.com> <20110610122451.15af86d1@lxorguk.ukuu.org.uk> <000c01cc2769$02669b70$0733d250$%szyprowski@samsung.com> <20110610135217.701a2fd2@lxorguk.ukuu.org.uk> Date: Fri, 10 Jun 2011 19:16:45 +0200 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: "Michal Nazarewicz" Message-ID: In-Reply-To: <20110610135217.701a2fd2@lxorguk.ukuu.org.uk> User-Agent: Opera Mail/11.10 (Linux) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 10 Jun 2011 14:52:17 +0200, Alan Cox wrote: >> I plan to replace it with lib/bitmap.c bitmap_* based allocator >> (similar like >> it it is used by dma_declare_coherent_memory() and friends in >> drivers/base/dma-coherent.c). We need something really simple for CMA >> area >> management. >> >> IMHO allocate_resource and friends a bit too heavy here, but good to >> know >> that such allocator also exists. > > Not sure I'd class allocate_resource as heavyweight but providing it's > using something that already exists rather than inventing yet another > allocator. genalloc is already in the kernel and is used in a few places, so we either let everyone use it as they see fit or we deprecate the library. If we don't deprecate it I see no reason why CMA should not use it. -- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michal "mina86" Nazarewicz (o o) ooo +----------ooO--(_)--Ooo-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail138.messagelabs.com (mail138.messagelabs.com [216.82.249.35]) by kanga.kvack.org (Postfix) with ESMTP id 8EFF86B004A for ; Fri, 10 Jun 2011 13:16:50 -0400 (EDT) Received: by fxm18 with SMTP id 18so2481897fxm.14 for ; Fri, 10 Jun 2011 10:16:47 -0700 (PDT) Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes Subject: Re: [PATCH 02/10] lib: genalloc: Generic allocator improvements References: <1307699698-29369-1-git-send-email-m.szyprowski@samsung.com> <1307699698-29369-3-git-send-email-m.szyprowski@samsung.com> <20110610122451.15af86d1@lxorguk.ukuu.org.uk> <000c01cc2769$02669b70$0733d250$%szyprowski@samsung.com> <20110610135217.701a2fd2@lxorguk.ukuu.org.uk> Date: Fri, 10 Jun 2011 19:16:45 +0200 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: "Michal Nazarewicz" Message-ID: In-Reply-To: <20110610135217.701a2fd2@lxorguk.ukuu.org.uk> Sender: owner-linux-mm@kvack.org List-ID: To: Marek Szyprowski , Alan Cox Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-mm@kvack.org, linaro-mm-sig@lists.linaro.org, 'Kyungmin Park' , 'Andrew Morton' , 'KAMEZAWA Hiroyuki' , 'Ankita Garg' , 'Daniel Walker' , 'Johan MOSSBERG' , 'Mel Gorman' , 'Arnd Bergmann' , 'Jesse Barker' On Fri, 10 Jun 2011 14:52:17 +0200, Alan Cox wrote: >> I plan to replace it with lib/bitmap.c bitmap_* based allocator >> (similar like >> it it is used by dma_declare_coherent_memory() and friends in >> drivers/base/dma-coherent.c). We need something really simple for CMA >> area >> management. >> >> IMHO allocate_resource and friends a bit too heavy here, but good to >> know >> that such allocator also exists. > > Not sure I'd class allocate_resource as heavyweight but providing it's > using something that already exists rather than inventing yet another > allocator. genalloc is already in the kernel and is used in a few places, so we either let everyone use it as they see fit or we deprecate the library. If we don't deprecate it I see no reason why CMA should not use it. -- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michal "mina86" Nazarewicz (o o) ooo +----------ooO--(_)--Ooo-- -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: mina86@mina86.com (Michal Nazarewicz) Date: Fri, 10 Jun 2011 19:16:45 +0200 Subject: [PATCH 02/10] lib: genalloc: Generic allocator improvements In-Reply-To: <20110610135217.701a2fd2@lxorguk.ukuu.org.uk> References: <1307699698-29369-1-git-send-email-m.szyprowski@samsung.com> <1307699698-29369-3-git-send-email-m.szyprowski@samsung.com> <20110610122451.15af86d1@lxorguk.ukuu.org.uk> <000c01cc2769$02669b70$0733d250$%szyprowski@samsung.com> <20110610135217.701a2fd2@lxorguk.ukuu.org.uk> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, 10 Jun 2011 14:52:17 +0200, Alan Cox wrote: >> I plan to replace it with lib/bitmap.c bitmap_* based allocator >> (similar like >> it it is used by dma_declare_coherent_memory() and friends in >> drivers/base/dma-coherent.c). We need something really simple for CMA >> area >> management. >> >> IMHO allocate_resource and friends a bit too heavy here, but good to >> know >> that such allocator also exists. > > Not sure I'd class allocate_resource as heavyweight but providing it's > using something that already exists rather than inventing yet another > allocator. genalloc is already in the kernel and is used in a few places, so we either let everyone use it as they see fit or we deprecate the library. If we don't deprecate it I see no reason why CMA should not use it. -- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michal "mina86" Nazarewicz (o o) ooo +----------ooO--(_)--Ooo--