All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michal Nazarewicz" <mina86@mina86.com>
To: "Felipe Balbi" <balbi@ti.com>, "Michal Nazarewicz" <mpn@google.com>
Cc: "Greg Kroah-Hartman" <gregkh@suse.de>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: f_mass_storage: remove deprecated fsg_add()
Date: Thu, 12 Apr 2012 12:13:32 +0200	[thread overview]
Message-ID: <op.wcndcuqd3l0zgt@mpn-glaptop> (raw)
In-Reply-To: <1ad5f25435fc5d2cd094ae1c68d7831b8b2737ca.1331896818.git.mina86@mina86.com>

On Fri, 16 Mar 2012 12:21:15 +0100, Michal Nazarewicz <mpn@google.com> wrote:
> From: Michal Nazarewicz <mina86@mina86.com>
>
> There are no in-tree fsg_add() users and it has been deprecated
> since 2.6.35 [1dc90985d1: fsg_add() renamed to fsg_bind_config()] so
> out-of-tree users had more then enough time to convert.  Removing.

Signed-off-by: Michal Nazarewicz <mina86@mina86.com>

> ---
>  drivers/usb/gadget/f_mass_storage.c |    7 -------
>  1 file changed, 7 deletions(-)
>
> diff --git a/drivers/usb/gadget/f_mass_storage.c b/drivers/usb/gadget/f_mass_storage.c
> index a371e96..47383f4 100644
> --- a/drivers/usb/gadget/f_mass_storage.c
> +++ b/drivers/usb/gadget/f_mass_storage.c
> @@ -3110,13 +3110,6 @@ static int fsg_bind_config(struct usb_composite_dev *cdev,
>  	return rc;
>  }
>-static inline int __deprecated __maybe_unused
> -fsg_add(struct usb_composite_dev *cdev, struct usb_configuration *c,
> -	struct fsg_common *common)
> -{
> -	return fsg_bind_config(cdev, c, common);
> -}
> -
> /************************* Module parameters *************************/
>

-- 
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michał “mina86” Nazarewicz    (o o)
ooo +----<email/xmpp: mpn@google.com>--------------ooO--(_)--Ooo--

  parent reply	other threads:[~2012-04-12 10:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-16 11:21 [PATCH] usb: gadget: f_mass_storage: remove deprecated fsg_add() Michal Nazarewicz
2012-03-16 11:25 ` Michal Nazarewicz
2012-04-11  9:41   ` Felipe Balbi
2012-04-11 15:25     ` Greg Kroah-Hartman
2012-04-11 19:49       ` Michal Nazarewicz
2012-04-12  7:52         ` Felipe Balbi
2012-04-12 10:16           ` Michal Nazarewicz
2012-04-12 10:13 ` Michal Nazarewicz [this message]
2012-04-12 11:25   ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=op.wcndcuqd3l0zgt@mpn-glaptop \
    --to=mina86@mina86.com \
    --cc=balbi@ti.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mpn@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.