From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michal Wajdeczko" Subject: Re: [PATCH 06/12] drm/i915/guc: unify guc irq handling Date: Wed, 10 Jul 2019 19:04:16 +0200 Message-ID: References: <20190710005437.3496-1-daniele.ceraolospurio@intel.com> <20190710005437.3496-7-daniele.ceraolospurio@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed"; DelSp="yes" Content-Transfer-Encoding: base64 Return-path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9012588DAA for ; Wed, 10 Jul 2019 17:04:19 +0000 (UTC) In-Reply-To: <20190710005437.3496-7-daniele.ceraolospurio@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: intel-gfx@lists.freedesktop.org, Daniele Ceraolo Spurio List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCAxMCBKdWwgMjAxOSAwMjo1NDozMSArMDIwMCwgRGFuaWVsZSBDZXJhb2xvIFNwdXJp byAgCjxkYW5pZWxlLmNlcmFvbG9zcHVyaW9AaW50ZWwuY29tPiB3cm90ZToKCj4gVGhlIDE2LWJp dCBndWMgaXJxIHZlY3RvciBpcyB1bmNoYW5nZWQgYWNyb3NzIGdlbnMsIHRoZSBvbmx5IHRoaW5n IHRoYXQKPiBtb3ZlZCBpcyBpdHMgcG9zaXRpb24gKGZyb20gdGhlIHVwcGVyIDE2IGJpdHMgb2Yg dGhlIFBNIHJlZ3MgdG8gaXRzIG93bgo+IHJlZ2lzdGVyKS4gSW5zdGVhZCBvZiBkdXBsaWNhdGlu ZyBhbGwgZGVmaW5lcyBhbmQgZnVuY3Rpb25zIHRvIGhhbmRsZQo+IHRoZSAyIGRpZmZlcmVudCBw b3NpdGlvbnMsIHdlIGNhbiB3b3JrIG9uIHRoZSB2ZWN0b3IgYW5kIHNoaWZ0IGl0IGFzCj4gYXBw cm9wcmlhdGUuIFdoaWxlIGF0IGl0LCB1cGRhdGUgdGhlIGhhbmRsZXIgdG8gd29yayBvbiBpbnRl bF9ndWMuCj4KPiBTaWduZWQtb2ZmLWJ5OiBEYW5pZWxlIENlcmFvbG8gU3B1cmlvIDxkYW5pZWxl LmNlcmFvbG9zcHVyaW9AaW50ZWwuY29tPgo+IENjOiBNaWNoYWwgV2FqZGVjemtvIDxtaWNoYWwu d2FqZGVjemtvQGludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9p cnEuYyAgICAgIHwgMjQgKysrKysrKystLS0tLS0tLS0tLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfcmVnLmggICAgICB8IDEwIC0tLS0tLS0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9ndWNfcmVnLmggfCAzMiArKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tCj4gIDMg ZmlsZXMgY2hhbmdlZCwgMjUgaW5zZXJ0aW9ucygrKSwgNDEgZGVsZXRpb25zKC0pCj4KPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEuYyAgCj4gYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pOTE1X2lycS5jCj4gaW5kZXggODMxZDE4NWMwN2QyLi40MmQ2ZDhiZmFjNzAg MTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEuYwo+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfaXJxLmMKPiBAQCAtMjY0LDcgKzI2NCw3IEBAIHN0YXRp YyB2b2lkIGdlbjJfaXJxX2luaXQoc3RydWN0IGludGVsX3VuY29yZSAgCj4gKnVuY29yZSwKPiAg CWdlbjJfaXJxX2luaXQoKHVuY29yZSksIGltcl92YWwsIGllcl92YWwpCj4gc3RhdGljIHZvaWQg Z2VuNl9ycHNfaXJxX2hhbmRsZXIoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LCB1 MzIgIAo+IHBtX2lpcik7Cj4gLXN0YXRpYyB2b2lkIGdlbjlfZ3VjX2lycV9oYW5kbGVyKHN0cnVj dCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwgdTMyICAKPiBwbV9paXIpOwo+ICtzdGF0aWMg dm9pZCBndWNfaXJxX2hhbmRsZXIoc3RydWN0IGludGVsX2d1YyAqZ3VjLCB1MTYgZ3VjX2lpcik7 Cj4gLyogRm9yIGRpc3BsYXkgaG90cGx1ZyBpbnRlcnJ1cHQgKi8KPiAgc3RhdGljIGlubGluZSB2 b2lkCj4gQEAgLTY1OCw4ICs2NTgsNyBAQCB2b2lkIGdlbjExX2VuYWJsZV9ndWNfaW50ZXJydXB0 cyhzdHJ1Y3QgaW50ZWxfZ3VjICAKPiAqZ3VjKQo+IAlzcGluX2xvY2tfaXJxKCZkZXZfcHJpdi0+ aXJxX2xvY2spOwo+ICAJaWYgKCFndWMtPmludGVycnVwdHMuZW5hYmxlZCkgewo+IC0JCXUzMiBl dmVudHMgPSBSRUdfRklFTERfUFJFUChFTkdJTkUxX01BU0ssCj4gLQkJCQkJICAgIEdFTjExX0dV Q19JTlRSX0dVQzJIT1NUKTsKPiArCQl1MzIgZXZlbnRzID0gUkVHX0ZJRUxEX1BSRVAoRU5HSU5F MV9NQVNLLCBHVUNfSU5UUl9HVUMySE9TVCk7Cj4gCQlXQVJOX09OX09OQ0UoZ2VuMTFfcmVzZXRf b25lX2lpcigmZGV2X3ByaXYtPmd0LCAwLCBHRU4xMV9HVUMpKTsKPiAgCQlJOTE1X1dSSVRFKEdF TjExX0dVQ19TR19JTlRSX0VOQUJMRSwgZXZlbnRzKTsKPiBAQCAtMTY1Niw3ICsxNjU1LDcgQEAg c3RhdGljIHZvaWQgZ2VuOF9ndF9pcnFfaGFuZGxlcihzdHJ1Y3QgIAo+IGRybV9pOTE1X3ByaXZh dGUgKmk5MTUsCj4gCWlmIChtYXN0ZXJfY3RsICYgKEdFTjhfR1RfUE1fSVJRIHwgR0VOOF9HVF9H VUNfSVJRKSkgewo+ICAJCWdlbjZfcnBzX2lycV9oYW5kbGVyKGk5MTUsIGd0X2lpclsyXSk7Cj4g LQkJZ2VuOV9ndWNfaXJxX2hhbmRsZXIoaTkxNSwgZ3RfaWlyWzJdKTsKPiArCQlndWNfaXJxX2hh bmRsZXIoJmk5MTUtPmd1YywgZ3RfaWlyWzJdID4+IDE2KTsKPiAgCX0KPiAgfQo+IEBAIC0xOTU1 LDE2ICsxOTU0LDEwIEBAIHN0YXRpYyB2b2lkIGdlbjZfcnBzX2lycV9oYW5kbGVyKHN0cnVjdCAg Cj4gZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIHUzMiBwbV9paXIpCj4gIAkJRFJNX0RFQlVH KCJDb21tYW5kIHBhcnNlciBlcnJvciwgcG1faWlyIDB4JTA4eFxuIiwgcG1faWlyKTsKPiAgfQo+ IC1zdGF0aWMgdm9pZCBnZW45X2d1Y19pcnFfaGFuZGxlcihzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0 ZSAqZGV2X3ByaXYsIHUzMiAgCj4gZ3RfaWlyKQo+ICtzdGF0aWMgdm9pZCBndWNfaXJxX2hhbmRs ZXIoc3RydWN0IGludGVsX2d1YyAqZ3VjLCB1MTYgaWlyKQoKbWF5YmUgaXQncyB0aGUgZ29vZCB0 aW1lIHRvIG1vdmUgdGhpcyBoYW5kbGVyIG91dCB0byBpbnRlbF9ndWMuYyA/Cgo+ICB7Cj4gLQlp ZiAoZ3RfaWlyICYgR0VOOV9HVUNfVE9fSE9TVF9JTlRfRVZFTlQpCj4gLQkJaW50ZWxfZ3VjX3Rv X2hvc3RfZXZlbnRfaGFuZGxlcigmZGV2X3ByaXYtPmd1Yyk7Cj4gLX0KPiAtCj4gLXN0YXRpYyB2 b2lkIGdlbjExX2d1Y19pcnFfaGFuZGxlcihzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqaTkxNSwg dTE2ICAKPiBpaXIpCj4gLXsKPiAtCWlmIChpaXIgJiBHRU4xMV9HVUNfSU5UUl9HVUMySE9TVCkK PiAtCQlpbnRlbF9ndWNfdG9faG9zdF9ldmVudF9oYW5kbGVyKCZpOTE1LT5ndWMpOwo+ICsJaWYg KGlpciAmIEdVQ19JTlRSX0dVQzJIT1NUKQo+ICsJCWludGVsX2d1Y190b19ob3N0X2V2ZW50X2hh bmRsZXIoZ3VjKTsKPiAgfQo+IHN0YXRpYyB2b2lkIGk5eHhfcGlwZXN0YXRfaXJxX3Jlc2V0KHN0 cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiBAQCAtMzA5Miw3ICszMDg1LDcgQEAg Z2VuMTFfb3RoZXJfaXJxX2hhbmRsZXIoc3RydWN0IGludGVsX2d0ICpndCwgY29uc3QgIAo+IHU4 IGluc3RhbmNlLAo+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUgPSBndC0+aTkxNTsK PiAJaWYgKGluc3RhbmNlID09IE9USEVSX0dVQ19JTlNUQU5DRSkKPiAtCQlyZXR1cm4gZ2VuMTFf Z3VjX2lycV9oYW5kbGVyKGk5MTUsIGlpcik7Cj4gKwkJcmV0dXJuIGd1Y19pcnFfaGFuZGxlcigm aTkxNS0+Z3VjLCBpaXIpOwo+IAlpZiAoaW5zdGFuY2UgPT0gT1RIRVJfR1RQTV9JTlNUQU5DRSkK PiAgCQlyZXR1cm4gZ2VuMTFfcnBzX2lycV9oYW5kbGVyKGd0LCBpaXIpOwo+IEBAIC00NzY0LDgg KzQ3NTcsOSBAQCB2b2lkIGludGVsX2lycV9pbml0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICAK PiAqZGV2X3ByaXYpCj4gIAlmb3IgKGkgPSAwOyBpIDwgTUFYX0wzX1NMSUNFUzsgKytpKQo+ICAJ CWRldl9wcml2LT5sM19wYXJpdHkucmVtYXBfaW5mb1tpXSA9IE5VTEw7Cj4gKwkvKiBwcmUtZ2Vu MTEgdGhlIGd1YyBpcnFzIGJpdHMgYXJlIGluIHRoZSB1cHBlciAxNiBiaXRzIG9mIHRoZSBwbSBy ZWcgIAo+ICovCgpzL2dlbjExL0dlbjExCnMvZ3VjL0d1QwoKPiAgCWlmIChIQVNfR1VDX1NDSEVE KGRldl9wcml2KSAmJiBJTlRFTF9HRU4oZGV2X3ByaXYpIDwgMTEpCj4gLQkJZGV2X3ByaXYtPnBt X2d1Y19ldmVudHMgPSBHRU45X0dVQ19UT19IT1NUX0lOVF9FVkVOVDsKPiArCQlkZXZfcHJpdi0+ cG1fZ3VjX2V2ZW50cyA9IEdVQ19JTlRSX0dVQzJIT1NUIDw8IDE2OwoKbWF5YmUgd2Ugc2hvdWxk IGFkZCBkZWZpbml0aW9uIGZvciB0aGlzIG1hc2sgaW4gUE0gcmVnaXN0ZXIKCiNkZWZpbmUgR0VO OF9QTV9JSVJfR1VDX01BU0sgMHhGRkZGMDAwMAoKYW5kIHRoZW4KCglkZXZfcHJpdi0+cG1fZ3Vj X2V2ZW50cyA9IFJFR19GSUVMRF9QUkVQKEdFTjhfUE1fSUlSX0dVQ19NQVNLLAoJICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBHVUNfSU5UUl9HVUMySE9TVCkKYW5kIGlu IGdlbjhfZ3RfaXJxX2hhbmRsZXIoKSBlYXJsaWVyIGFib3ZlCgoJZ3VjX2lycV9oYW5kbGVyKCZp OTE1LT5ndWMsIFJFR19GSUVMRF9HRVQoR0VOOF9QTV9JSVJfR1VDX01BU0ssCgkgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBndF9paXJbMl0pKTsKCQo+IAkvKiBMZXQn cyB0cmFjayB0aGUgZW5hYmxlZCBycHMgZXZlbnRzICovCj4gIAlpZiAoSVNfVkFMTEVZVklFVyhk ZXZfcHJpdikpCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmgg IAo+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaAo+IGluZGV4IDU4OThmNTllM2Rk Ny4uNGRjMzFlNDg4YjgwIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf cmVnLmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oCj4gQEAgLTczNDIs MTYgKzczNDIsNiBAQCBlbnVtIHsKPiAgI2RlZmluZSBHRU44X0dUX0lJUih3aGljaCkgX01NSU8o MHg0NDMwOCArICgweDEwICogKHdoaWNoKSkpCj4gICNkZWZpbmUgR0VOOF9HVF9JRVIod2hpY2gp IF9NTUlPKDB4NDQzMGMgKyAoMHgxMCAqICh3aGljaCkpKQo+IC0jZGVmaW5lIEdFTjlfR1VDX1RP X0hPU1RfSU5UX0VWRU5UCSgxIDw8IDMxKQo+IC0jZGVmaW5lIEdFTjlfR1VDX0VYRUNfRVJST1Jf RVZFTlQJKDEgPDwgMzApCj4gLSNkZWZpbmUgR0VOOV9HVUNfRElTUExBWV9FVkVOVAkJKDEgPDwg MjkpCj4gLSNkZWZpbmUgR0VOOV9HVUNfU0VNQV9TSUdOQUxfRVZFTlQJKDEgPDwgMjgpCj4gLSNk ZWZpbmUgR0VOOV9HVUNfSU9NTVVfTVNHX0VWRU5UCSgxIDw8IDI3KQo+IC0jZGVmaW5lIEdFTjlf R1VDX0RCX1JJTkdfRVZFTlQJCSgxIDw8IDI2KQo+IC0jZGVmaW5lIEdFTjlfR1VDX0RNQV9ET05F X0VWRU5UCQkoMSA8PCAyNSkKPiAtI2RlZmluZSBHRU45X0dVQ19GQVRBTF9FUlJPUl9FVkVOVAko MSA8PCAyNCkKPiAtI2RlZmluZSBHRU45X0dVQ19OT1RJRklDQVRJT05fRVZFTlQJKDEgPDwgMjMp Cj4gLQo+ICAjZGVmaW5lIEdFTjhfUkNTX0lSUV9TSElGVCAwCj4gICNkZWZpbmUgR0VOOF9CQ1Nf SVJRX1NISUZUIDE2Cj4gICNkZWZpbmUgR0VOOF9WQ1MwX0lSUV9TSElGVCAwICAvKiBOQjogVkNT MSBpbiBic3BlYyEgKi8KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf Z3VjX3JlZy5oICAKPiBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Y19yZWcuaAo+IGlu ZGV4IGE1YWI3YmM1NTA0Yy4uZTNjYmIyMzI5OWNlIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2d1Y19yZWcuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2d1Y19yZWcuaAo+IEBAIC0xNDEsMjEgKzE0MSwyMSBAQCBzdHJ1Y3QgZ3VjX2Rvb3JiZWxs X2luZm8gewo+ICAjZGVmaW5lIEdVQ19QTV9QMjRDX0lFUgkJCV9NTUlPKDB4QzU1QykKPiAvKiBH dUMgSW50ZXJydXB0IFZlY3RvciAqLwo+IC0jZGVmaW5lIEdFTjExX0dVQ19JTlRSX0dVQzJIT1NU CQkoMSA8PCAxNSkKPiAtI2RlZmluZSBHRU4xMV9HVUNfSU5UUl9FWEVDX0VSUk9SCSgxIDw8IDE0 KQo+IC0jZGVmaW5lIEdFTjExX0dVQ19JTlRSX0RJU1BMQVlfRVZFTlQJKDEgPDwgMTMpCj4gLSNk ZWZpbmUgR0VOMTFfR1VDX0lOVFJfU0VNX1NJRwkJKDEgPDwgMTIpCj4gLSNkZWZpbmUgR0VOMTFf R1VDX0lOVFJfSU9NTVUyR1VDCSgxIDw8IDExKQo+IC0jZGVmaW5lIEdFTjExX0dVQ19JTlRSX0RP T1JCRUxMX1JBTkcJKDEgPDwgMTApCj4gLSNkZWZpbmUgR0VOMTFfR1VDX0lOVFJfRE1BX0RPTkUJ CSgxIDw8ICA5KQo+IC0jZGVmaW5lIEdFTjExX0dVQ19JTlRSX0ZBVEFMX0VSUk9SCSgxIDw8ICA4 KQo+IC0jZGVmaW5lIEdFTjExX0dVQ19JTlRSX05PVElGX0VSUk9SCSgxIDw8ICA3KQo+IC0jZGVm aW5lIEdFTjExX0dVQ19JTlRSX1NXX0lOVF82CQkoMSA8PCAgNikKPiAtI2RlZmluZSBHRU4xMV9H VUNfSU5UUl9TV19JTlRfNQkJKDEgPDwgIDUpCj4gLSNkZWZpbmUgR0VOMTFfR1VDX0lOVFJfU1df SU5UXzQJCSgxIDw8ICA0KQo+IC0jZGVmaW5lIEdFTjExX0dVQ19JTlRSX1NXX0lOVF8zCQkoMSA8 PCAgMykKPiAtI2RlZmluZSBHRU4xMV9HVUNfSU5UUl9TV19JTlRfMgkJKDEgPDwgIDIpCj4gLSNk ZWZpbmUgR0VOMTFfR1VDX0lOVFJfU1dfSU5UXzEJCSgxIDw8ICAxKQo+IC0jZGVmaW5lIEdFTjEx X0dVQ19JTlRSX1NXX0lOVF8wCQkoMSA8PCAgMCkKPiArI2RlZmluZSBHVUNfSU5UUl9HVUMySE9T VAkJQklUKDE1KQo+ICsjZGVmaW5lIEdVQ19JTlRSX0VYRUNfRVJST1IJCUJJVCgxNCkKPiArI2Rl ZmluZSBHVUNfSU5UUl9ESVNQTEFZX0VWRU5UCQlCSVQoMTMpCj4gKyNkZWZpbmUgR1VDX0lOVFJf U0VNX1NJRwkJQklUKDEyKQo+ICsjZGVmaW5lIEdVQ19JTlRSX0lPTU1VMkdVQwkJQklUKDExKQo+ ICsjZGVmaW5lIEdVQ19JTlRSX0RPT1JCRUxMX1JBTkcJCUJJVCgxMCkKPiArI2RlZmluZSBHVUNf SU5UUl9ETUFfRE9ORQkJQklUKDkpCj4gKyNkZWZpbmUgR1VDX0lOVFJfRkFUQUxfRVJST1IJCUJJ VCg4KQo+ICsjZGVmaW5lIEdVQ19JTlRSX05PVElGX0VSUk9SCQlCSVQoNykKPiArI2RlZmluZSBH VUNfSU5UUl9TV19JTlRfNgkJQklUKDYpCj4gKyNkZWZpbmUgR1VDX0lOVFJfU1dfSU5UXzUJCUJJ VCg1KQo+ICsjZGVmaW5lIEdVQ19JTlRSX1NXX0lOVF80CQlCSVQoNCkKPiArI2RlZmluZSBHVUNf SU5UUl9TV19JTlRfMwkJQklUKDMpCj4gKyNkZWZpbmUgR1VDX0lOVFJfU1dfSU5UXzIJCUJJVCgy KQo+ICsjZGVmaW5lIEdVQ19JTlRSX1NXX0lOVF8xCQlCSVQoMSkKPiArI2RlZmluZSBHVUNfSU5U Ul9TV19JTlRfMAkJQklUKDApCgpzaG91bGRuJ3Qgd2UgdXNlIFJFR19CSVQgaGVyZT8KCndpdGgv d2l0aG91dCBhYm92ZSBuaXRzLApSZXZpZXdlZC1ieTogTWljaGFsIFdhamRlY3prbyA8bWljaGFs LndhamRlY3prb0BpbnRlbC5jb20+Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2ludGVsLWdmeA==